|
 |
73b8f2 |
From 5580cac5502cd518adad0a3682fd53aeeaf86a86 Mon Sep 17 00:00:00 2001
|
|
|
73b8f2 |
From: Frediano Ziglio <fziglio@redhat.com>
|
|
|
73b8f2 |
Date: Thu, 17 Sep 2015 15:01:05 +0100
|
|
|
73b8f2 |
Subject: [PATCH 57/57] Prevent leak if size from red_get_data_chunks don't
|
|
|
73b8f2 |
match in red_get_image
|
|
|
73b8f2 |
|
|
|
73b8f2 |
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
|
|
|
73b8f2 |
---
|
|
|
73b8f2 |
server/red_parse_qxl.c | 2 ++
|
|
|
73b8f2 |
1 file changed, 2 insertions(+)
|
|
|
73b8f2 |
|
|
|
73b8f2 |
diff --git a/server/red_parse_qxl.c b/server/red_parse_qxl.c
|
|
|
73b8f2 |
index 8e3dd55..bd0c408 100644
|
|
|
73b8f2 |
--- a/server/red_parse_qxl.c
|
|
|
73b8f2 |
+++ b/server/red_parse_qxl.c
|
|
|
73b8f2 |
@@ -530,6 +530,7 @@ static SpiceImage *red_get_image(RedMemSlotInfo *slots, int group_id,
|
|
|
73b8f2 |
&chunks, qxl->bitmap.data);
|
|
|
73b8f2 |
spice_assert(size == bitmap_size);
|
|
|
73b8f2 |
if (size != bitmap_size) {
|
|
|
73b8f2 |
+ red_put_data_chunks(&chunks);
|
|
|
73b8f2 |
goto error;
|
|
|
73b8f2 |
}
|
|
|
73b8f2 |
red->u.bitmap.data = red_get_image_data_chunked(slots, group_id,
|
|
|
73b8f2 |
@@ -550,6 +551,7 @@ static SpiceImage *red_get_image(RedMemSlotInfo *slots, int group_id,
|
|
|
73b8f2 |
&chunks, (QXLDataChunk *)qxl->quic.data);
|
|
|
73b8f2 |
spice_assert(size == red->u.quic.data_size);
|
|
|
73b8f2 |
if (size != red->u.quic.data_size) {
|
|
|
73b8f2 |
+ red_put_data_chunks(&chunks);
|
|
|
73b8f2 |
goto error;
|
|
|
73b8f2 |
}
|
|
|
73b8f2 |
red->u.quic.data = red_get_image_data_chunked(slots, group_id,
|
|
|
73b8f2 |
--
|
|
|
73b8f2 |
2.4.3
|
|
|
73b8f2 |
|