From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001

From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= <fidencio@redhat.com>

Date: Mon, 1 Sep 2014 00:38:36 +0200

Subject: [PATCH] server: Don't dump the bitmap when the format is invalid

Caught by covscan:

spice/server/spice_bitmap_utils.c:54: var_decl: Declaring variable "n_pixel_bits" without initializer.

spice/server/spice_bitmap_utils.c:106: uninit_use: Using uninitialized value "n_pixel_bits".

Resolves: rhbz#885717

(cherry picked from commit 94edda22553ba351c869b58cd984a79cfc6c2180)

---

 server/red_worker.c | 1 +

 1 file changed, 1 insertion(+)

diff --git a/server/red_worker.c b/server/red_worker.c

index d7962c5..945f4f1 100644

--- a/server/red_worker.c

+++ b/server/red_worker.c

@@ -12296,6 +12296,7 @@ static void dump_bitmap(RedWorker *worker, SpiceBitmap *bitmap, uint32_t group_i

         break;

     default:

         spice_error("invalid bitmap format  %u", bitmap->format);

+        return;

     }

     if (!rgb) {