|
 |
ad1357 |
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
ad1357 |
From: Frediano Ziglio <fziglio@redhat.com>
|
|
|
ad1357 |
Date: Fri, 6 Oct 2017 08:57:42 +0100
|
|
|
ad1357 |
Subject: [spice-server] red-channel: Remove
|
|
|
ad1357 |
red_channel_init_outgoing_messages_window
|
|
|
ad1357 |
|
|
|
ad1357 |
This function does not make much sense anymore.
|
|
|
ad1357 |
Is called by RedVmcChannel which doesn't use RedChannelClient ACKs
|
|
|
ad1357 |
so the variable changed are not used.
|
|
|
ad1357 |
Moreover, at red_vmc_channel_constructed() time, there will be no
|
|
|
ad1357 |
clients yet, so red_channel_init_outgoing_messages() will be a no-op.
|
|
|
ad1357 |
|
|
|
ad1357 |
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
|
|
|
ad1357 |
Acked-by: Christophe Fergeau <cfergeau@redhat.com>
|
|
|
ad1357 |
---
|
|
|
ad1357 |
server/red-channel.c | 8 --------
|
|
|
ad1357 |
server/red-channel.h | 3 ---
|
|
|
ad1357 |
server/spicevmc.c | 2 --
|
|
|
ad1357 |
3 files changed, 13 deletions(-)
|
|
|
ad1357 |
|
|
|
ad1357 |
diff --git a/server/red-channel.c b/server/red-channel.c
|
|
|
ad1357 |
index b5094829e..8c507f202 100644
|
|
|
ad1357 |
--- a/server/red-channel.c
|
|
|
ad1357 |
+++ b/server/red-channel.c
|
|
|
ad1357 |
@@ -421,14 +421,6 @@ void red_channel_push(RedChannel *channel)
|
|
|
ad1357 |
g_list_foreach(channel->priv->clients, (GFunc)red_channel_client_push, NULL);
|
|
|
ad1357 |
}
|
|
|
ad1357 |
|
|
|
ad1357 |
-// TODO: this function doesn't make sense because the window should be client (WAN/LAN)
|
|
|
ad1357 |
-// specific
|
|
|
ad1357 |
-void red_channel_init_outgoing_messages_window(RedChannel *channel)
|
|
|
ad1357 |
-{
|
|
|
ad1357 |
- g_list_foreach(channel->priv->clients,
|
|
|
ad1357 |
- (GFunc)red_channel_client_init_outgoing_messages_window, NULL);
|
|
|
ad1357 |
-}
|
|
|
ad1357 |
-
|
|
|
ad1357 |
void red_channel_pipes_add(RedChannel *channel, RedPipeItem *item)
|
|
|
ad1357 |
{
|
|
|
ad1357 |
RedChannelClient *rcc;
|
|
|
ad1357 |
diff --git a/server/red-channel.h b/server/red-channel.h
|
|
|
ad1357 |
index e0fe94fec..281ed0c9e 100644
|
|
|
ad1357 |
--- a/server/red-channel.h
|
|
|
ad1357 |
+++ b/server/red-channel.h
|
|
|
ad1357 |
@@ -157,9 +157,6 @@ void red_channel_destroy(RedChannel *channel);
|
|
|
ad1357 |
/* return true if all the channel clients support the cap */
|
|
|
ad1357 |
bool red_channel_test_remote_cap(RedChannel *channel, uint32_t cap);
|
|
|
ad1357 |
|
|
|
ad1357 |
-/* should be called when a new channel is ready to send messages */
|
|
|
ad1357 |
-void red_channel_init_outgoing_messages_window(RedChannel *channel);
|
|
|
ad1357 |
-
|
|
|
ad1357 |
// helper to push a new item to all channels
|
|
|
ad1357 |
typedef RedPipeItem *(*new_pipe_item_t)(RedChannelClient *rcc, void *data, int num);
|
|
|
ad1357 |
int red_channel_pipes_new_add(RedChannel *channel, new_pipe_item_t creator, void *data);
|
|
|
ad1357 |
diff --git a/server/spicevmc.c b/server/spicevmc.c
|
|
|
ad1357 |
index 6b9b96fc8..a1685483d 100644
|
|
|
ad1357 |
--- a/server/spicevmc.c
|
|
|
ad1357 |
+++ b/server/spicevmc.c
|
|
|
ad1357 |
@@ -246,8 +246,6 @@ red_vmc_channel_constructed(GObject *object)
|
|
|
ad1357 |
red_channel_set_cap(RED_CHANNEL(self), SPICE_SPICEVMC_CAP_DATA_COMPRESS_LZ4);
|
|
|
ad1357 |
#endif
|
|
|
ad1357 |
|
|
|
ad1357 |
- red_channel_init_outgoing_messages_window(RED_CHANNEL(self));
|
|
|
ad1357 |
-
|
|
|
ad1357 |
reds_register_channel(reds, RED_CHANNEL(self));
|
|
|
ad1357 |
}
|
|
|
ad1357 |
|