From 0fa0ce0acdddc5e517bf06df9da33c9cda6d600e Mon Sep 17 00:00:00 2001 From: Frediano Ziglio Date: Thu, 15 Nov 2018 21:55:11 +0000 Subject: [PATCH] udscs: Avoid file descriptor leak If connection fails the socket descriptor is not closed causing a leak. Signed-off-by: Frediano Ziglio Acked-by: Victor Toso (cherry picked from commit 2d6d0d2acd3248e981361c2f3d8b253da8f04048) Note: - Conflict due g_free() usage upstream while downstream we have free() being used. --- src/udscs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/udscs.c b/src/udscs.c index f04a31c..96a9f61 100644 --- a/src/udscs.c +++ b/src/udscs.c @@ -192,6 +192,7 @@ struct udscs_connection *udscs_connect(const char *socketname, if (conn->debug) { syslog(LOG_DEBUG, "connect %s: %m", socketname); } + close(conn->fd); free(conn); return NULL; } -- 2.20.1