From 12708a0fc9f3da1d1cc492bb3a49844b02e76b40 Mon Sep 17 00:00:00 2001 From: Uri Lublin Date: Sun, 11 Oct 2020 20:59:17 +0300 Subject: [PATCH vd_agent_linux 17/17] vdagentd: do not allow to use an already used file-xfer id Signed-off-by: Uri Lublin Acked-by: Frediano Ziglio --- src/vdagentd/vdagentd.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/vdagentd/vdagentd.c b/src/vdagentd/vdagentd.c index 9243cfb..279e7c3 100644 --- a/src/vdagentd/vdagentd.c +++ b/src/vdagentd/vdagentd.c @@ -404,6 +404,13 @@ static void do_client_file_xfer(VirtioPort *vport, "Cancelling client file-xfer request %u", s->id, VD_AGENT_FILE_XFER_STATUS_ERROR, (void*) &error, detail_size); return; + } else if (g_hash_table_lookup(active_xfers, GUINT_TO_POINTER(s->id)) != NULL) { + // id is already used -- client is confused + send_file_xfer_status(vport, + "File transfer ID is already used. " + "Cancelling client file-xfer request %u", + s->id, VD_AGENT_FILE_XFER_STATUS_ERROR, NULL, 0); + return; } msg_type = VDAGENTD_FILE_XFER_START; id = s->id; -- 2.26.2