Blame SOURCES/0036-vdagent-x11-Turn-some-error-messages-into-debugging-.patch

a547b4
From 81c96df492e8f8b01640634fcd79234f63f5228e Mon Sep 17 00:00:00 2001
a547b4
From: Hans de Goede <hdegoede@redhat.com>
a547b4
Date: Tue, 13 Aug 2013 12:19:54 +0200
a547b4
Subject: [PATCH 36/36] vdagent-x11: Turn some error messages into debugging
a547b4
 messages (rhbz#918310)
a547b4
a547b4
Some bad clients, ie autocutsel, don't stick to the icccm spec, causing us to
a547b4
flood the logs with error messages, turn these into debug messages instead,
a547b4
so that they are only shown when debuggging / verbose logging is turned on.
a547b4
a547b4
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
a547b4
(cherry picked from commit d39230cee236bc6b8b150c7687d49a46f519bd2b)
a547b4
---
a547b4
 src/vdagent-x11.c | 11 ++++++-----
a547b4
 1 file changed, 6 insertions(+), 5 deletions(-)
a547b4
a547b4
diff --git a/src/vdagent-x11.c b/src/vdagent-x11.c
a547b4
index e72fd24..c925b43 100644
a547b4
--- a/src/vdagent-x11.c
a547b4
+++ b/src/vdagent-x11.c
a547b4
@@ -761,8 +761,8 @@ static uint32_t vdagent_x11_target_to_type(struct vdagent_x11 *x11,
a547b4
         }
a547b4
     }
a547b4
 
a547b4
-    SELPRINTF("unexpected selection type %s",
a547b4
-              vdagent_x11_get_atom_name(x11, target));
a547b4
+    VSELPRINTF("unexpected selection type %s",
a547b4
+               vdagent_x11_get_atom_name(x11, target));
a547b4
     return VD_AGENT_CLIPBOARD_NONE;
a547b4
 }
a547b4
 
a547b4
@@ -834,7 +834,8 @@ static void vdagent_x11_handle_selection_notify(struct vdagent_x11 *x11,
a547b4
     type = vdagent_x11_target_to_type(x11, selection,
a547b4
                                       x11->conversion_req->target);
a547b4
     if (type == VD_AGENT_CLIPBOARD_NONE)
a547b4
-        syslog(LOG_ERR, "internal error conversion_req has bad target");
a547b4
+        SELPRINTF("internal error conversion_req has bad target %s",
a547b4
+                  vdagent_x11_get_atom_name(x11, x11->conversion_req->target));
a547b4
     if (len == 0) { /* No errors so far */
a547b4
         len = vdagent_x11_get_selection(x11, event, selection,
a547b4
                                         x11->conversion_req->target,
a547b4
@@ -1064,7 +1065,7 @@ static void vdagent_x11_handle_selection_request(struct vdagent_x11 *x11)
a547b4
     type = vdagent_x11_target_to_type(x11, selection,
a547b4
                                       event->xselectionrequest.target);
a547b4
     if (type == VD_AGENT_CLIPBOARD_NONE) {
a547b4
-        syslog(LOG_ERR, "guest app requested a non-advertised target");
a547b4
+        VSELPRINTF("guest app requested a non-advertised target");
a547b4
         vdagent_x11_send_selection_notify(x11, None, NULL);
a547b4
         return;
a547b4
     }
a547b4
@@ -1310,7 +1311,7 @@ void vdagent_x11_clipboard_release(struct vdagent_x11 *x11, uint8_t selection)
a547b4
     }
a547b4
 
a547b4
     if (x11->clipboard_owner[selection] != owner_client) {
a547b4
-        SELPRINTF("received release while not owning client clipboard");
a547b4
+        VSELPRINTF("received release while not owning client clipboard");
a547b4
         return;
a547b4
     }
a547b4
 
a547b4
-- 
a547b4
2.20.1
a547b4