|
 |
0985ad |
From 6bfbd03e83fc8fcf783d4431607d7d6129af58b0 Mon Sep 17 00:00:00 2001
|
|
|
0985ad |
From: Victor Toso <me@victortoso.com>
|
|
|
0985ad |
Date: Fri, 12 Jul 2019 11:12:42 +0200
|
|
|
0985ad |
Subject: [PATCH 4/9] vdagent: simple fix for address-of-packed-member
|
|
|
0985ad |
MIME-Version: 1.0
|
|
|
0985ad |
Content-Type: text/plain; charset=UTF-8
|
|
|
0985ad |
Content-Transfer-Encoding: 8bit
|
|
|
0985ad |
|
|
|
0985ad |
Seems to be a false positive but as this message only happens when user
|
|
|
0985ad |
client connects, we can copy this array to make compiling warn free.
|
|
|
0985ad |
|
|
|
0985ad |
> src/vdagent/vdagent.c: In function ‘daemon_read_complete’:
|
|
|
0985ad |
> src/vdagent/vdagent.c:226:71: error: taking address of packed member of
|
|
|
0985ad |
> ‘struct VDAgentAudioVolumeSync’ may result in an unaligned pointer
|
|
|
0985ad |
> value [-Werror=address-of-packed-member]
|
|
|
0985ad |
> 226 | vdagent_audio_playback_sync(avs->mute, avs->nchannels, avs->volume);
|
|
|
0985ad |
> | ~~~^~~~~~~~
|
|
|
0985ad |
> src/vdagent/vdagent.c:228:69: error: taking address of packed member of
|
|
|
0985ad |
> ‘struct VDAgentAudioVolumeSync’ may result in an unaligned pointer
|
|
|
0985ad |
> value [-Werror=address-of-packed-member]
|
|
|
0985ad |
> 228 | vdagent_audio_record_sync(avs->mute, avs->nchannels, avs->volume);
|
|
|
0985ad |
> | ~~~^~~~~~~~
|
|
|
0985ad |
|
|
|
0985ad |
Signed-off-by: Victor Toso <victortoso@redhat.com>
|
|
|
0985ad |
Acked-by: Frediano Ziglio <fziglio@redhat.com>
|
|
|
0985ad |
---
|
|
|
0985ad |
src/vdagent/vdagent.c | 7 +++++--
|
|
|
0985ad |
1 file changed, 5 insertions(+), 2 deletions(-)
|
|
|
0985ad |
|
|
|
0985ad |
diff --git a/src/vdagent/vdagent.c b/src/vdagent/vdagent.c
|
|
|
0985ad |
index d799d1f..0e2e73e 100644
|
|
|
0985ad |
--- a/src/vdagent/vdagent.c
|
|
|
0985ad |
+++ b/src/vdagent/vdagent.c
|
|
|
0985ad |
@@ -222,11 +222,14 @@ static void daemon_read_complete(struct udscs_connection **connp,
|
|
|
0985ad |
break;
|
|
|
0985ad |
case VDAGENTD_AUDIO_VOLUME_SYNC: {
|
|
|
0985ad |
VDAgentAudioVolumeSync *avs = (VDAgentAudioVolumeSync *)data;
|
|
|
0985ad |
+ uint16_t *volume = g_memdup(avs->volume, sizeof(uint16_t) * avs->nchannels);
|
|
|
0985ad |
+
|
|
|
0985ad |
if (avs->is_playback) {
|
|
|
0985ad |
- vdagent_audio_playback_sync(avs->mute, avs->nchannels, avs->volume);
|
|
|
0985ad |
+ vdagent_audio_playback_sync(avs->mute, avs->nchannels, volume);
|
|
|
0985ad |
} else {
|
|
|
0985ad |
- vdagent_audio_record_sync(avs->mute, avs->nchannels, avs->volume);
|
|
|
0985ad |
+ vdagent_audio_record_sync(avs->mute, avs->nchannels, volume);
|
|
|
0985ad |
}
|
|
|
0985ad |
+ g_free(volume);
|
|
|
0985ad |
break;
|
|
|
0985ad |
}
|
|
|
0985ad |
case VDAGENTD_FILE_XFER_DATA:
|
|
|
0985ad |
--
|
|
|
0985ad |
2.21.0
|
|
|
0985ad |
|