Blame SOURCES/0004-Not-having-the-virtio-channel-is-not-an-error-instea.patch
|
 |
a547b4 |
From 528a816d2be5fccb531e7711a4c2efea7dbd0348 Mon Sep 17 00:00:00 2001
|
|
|
a547b4 |
From: Colin Walters <walters@verbum.org>
|
|
|
a547b4 |
Date: Tue, 11 Jun 2013 15:21:13 -0400
|
|
|
a547b4 |
Subject: [PATCH] Not having the virtio channel is not an error; instead
|
|
|
a547b4 |
silently do nothing
|
|
|
a547b4 |
|
|
|
a547b4 |
Fedora for example bundles the SPICE agent by default; however, we
|
|
|
a547b4 |
don't want to spew an error when running non-virtualized, or with
|
|
|
a547b4 |
plain VNC.
|
|
|
a547b4 |
|
|
|
a547b4 |
Let's just silently exit; while we could change LOG_ERR -> LOG_INFO
|
|
|
a547b4 |
or something, that's still pointless noise in most people's syslog.
|
|
|
a547b4 |
|
|
|
a547b4 |
Someone who was debugging a misconfigured SPICE setup would pretty
|
|
|
a547b4 |
quickly notice that they were missing the virtio port.
|
|
|
a547b4 |
|
|
|
a547b4 |
(This patch is part of a larger initiative to reduce error
|
|
|
a547b4 |
spew on default startup in common deployment scenarios such as
|
|
|
a547b4 |
KVM+VNC.)
|
|
|
a547b4 |
|
|
|
a547b4 |
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|
|
a547b4 |
---
|
|
|
a547b4 |
src/vdagent.c | 4 +---
|
|
|
a547b4 |
1 file changed, 1 insertion(+), 3 deletions(-)
|
|
|
a547b4 |
|
|
|
a547b4 |
diff --git a/src/vdagent.c b/src/vdagent.c
|
|
|
a547b4 |
index 9e238d3..10ebf6e 100644
|
|
|
a547b4 |
--- a/src/vdagent.c
|
|
|
a547b4 |
+++ b/src/vdagent.c
|
|
|
a547b4 |
@@ -226,9 +226,7 @@ int main(int argc, char *argv[])
|
|
|
a547b4 |
LOG_USER);
|
|
|
a547b4 |
|
|
|
a547b4 |
if (file_test(portdev) != 0) {
|
|
|
a547b4 |
- syslog(LOG_ERR, "Missing virtio device '%s': %s",
|
|
|
a547b4 |
- portdev, strerror(errno));
|
|
|
a547b4 |
- return 1;
|
|
|
a547b4 |
+ return 0;
|
|
|
a547b4 |
}
|
|
|
a547b4 |
|
|
|
a547b4 |
if (do_daemonize)
|