commit 923a68777927eaaee3c5fa289053ac3a87d353f9 Author: Bryn M. Reeves Date: Tue Oct 15 17:00:09 2013 +0100 Remove useless os.path.exists check for brctl executable The networking module previously checked that its hard-coded path for the brctl command existed before collecting output. This was missed in the conversion to using policy defined PATH search for external commands in commit e0d132e. Similar problems were fixed in commits 8b10cb0, 374da99, 8883155. Signed-off-by: Bryn M. Reeves diff --git a/sos/plugins/networking.py b/sos/plugins/networking.py index 90e1b58..9724a4f 100644 --- a/sos/plugins/networking.py +++ b/sos/plugins/networking.py @@ -111,12 +111,11 @@ class Networking(Plugin): self.add_cmd_output("ethtool -c "+eth) self.add_cmd_output("ethtool -g "+eth) - if os.path.exists("brctl"): - brctl_file=self.add_cmd_output("brctl show") - brctl_out=self.call_ext_prog("brctl show") - if brctl_out: - for br_name in self.get_bridge_name(brctl_out): - self.add_cmd_output("brctl showstp "+br_name) + brctl_file=self.add_cmd_output("brctl show") + brctl_out=self.call_ext_prog("brctl show") + if brctl_out: + for br_name in self.get_bridge_name(brctl_out): + self.add_cmd_output("brctl showstp "+br_name) if self.get_option("traceroute"): self.add_cmd_output("/bin/traceroute -n %s" % self.trace_host)