From fc831f0072c8f751f8fc2f46eb5c3e6aa9eba0a9 Mon Sep 17 00:00:00 2001 From: Pavel Moravec Date: Mon, 8 Jun 2020 14:58:15 +0200 Subject: [PATCH] [gluster] fix gluster volume splitlines iteration Iterate via "gluster volue info" output split to lines, and dont truncate the trailing character (a relict from past different content parsing). Resolves: #2106 Signed-off-by: Pavel Moravec Signed-off-by: Jake Hunsaker --- sos/plugins/gluster.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sos/plugins/gluster.py b/sos/plugins/gluster.py index eb236f1e..9540d323 100644 --- a/sos/plugins/gluster.py +++ b/sos/plugins/gluster.py @@ -104,10 +104,10 @@ class Gluster(Plugin, RedHatPlugin): volume_cmd = self.collect_cmd_output("gluster volume info") if volume_cmd['status'] == 0: - for line in volume_cmd['output']: + for line in volume_cmd['output'].splitlines(): if not line.startswith("Volume Name:"): continue - volname = line[12:-1] + volname = line[12:] self.add_cmd_output([ "gluster volume get %s all" % volname, "gluster volume geo-replication %s status" % volname, -- 2.26.2