9eb798
From 96ff6873b024718fcbb7b011eee58aab84c3086f Mon Sep 17 00:00:00 2001
9eb798
From: Alexander Bokovoy <abokovoy@redhat.com>
9eb798
Date: Mon, 11 Sep 2017 15:32:38 +0300
9eb798
Subject: [PATCH 11/17] Move a helper to build DN to a format.c
9eb798
9eb798
---
9eb798
 src/back-sch-nss.c | 45 ++-------------------------------------------
9eb798
 src/format.c       | 41 +++++++++++++++++++++++++++++++++++++++++
9eb798
 src/format.h       |  2 ++
9eb798
 3 files changed, 45 insertions(+), 43 deletions(-)
9eb798
9eb798
diff --git a/src/back-sch-nss.c b/src/back-sch-nss.c
9eb798
index db63e59..e4d027e 100644
9eb798
--- a/src/back-sch-nss.c
9eb798
+++ b/src/back-sch-nss.c
9eb798
@@ -186,47 +186,6 @@ backend_search_filter_has_cn_uid(Slapi_Filter *filter, void *arg)
9eb798
 	return SLAPI_FILTER_SCAN_CONTINUE;
9eb798
 }
9eb798
 
9eb798
-static char *
9eb798
-backend_build_dn(const char *attribute, const char *value,
9eb798
-		 const char *container_sdn)
9eb798
-{
9eb798
-	Slapi_RDN *rdn;
9eb798
-	Slapi_DN *sdn;
9eb798
-	char *val, *dn = NULL;
9eb798
-	const char *ndn, *hexchars = "0123456789ABCDEF";
9eb798
-	int i;
9eb798
-
9eb798
-	val = malloc(strlen(value) * 3 + 1);
9eb798
-	if (val == NULL) {
9eb798
-		return NULL;
9eb798
-	}
9eb798
-	rdn = slapi_rdn_new();
9eb798
-	if (rdn == NULL) {
9eb798
-		free(val);
9eb798
-		return NULL;
9eb798
-	}
9eb798
-        for (i = 0; value[i] != '\0'; i++) {
9eb798
-		val[i * 3] = '\\';
9eb798
-		val[i * 3 + 1] = hexchars[(value[i] & 0xf0) >> 4];
9eb798
-		val[i * 3 + 2] = hexchars[value[i] & 0xf];
9eb798
-	}
9eb798
-	val[i * 3] = '\0';
9eb798
-	if (slapi_rdn_add(rdn, attribute, val) == 1) {
9eb798
-		sdn = slapi_sdn_new_dn_byval(container_sdn);
9eb798
-		if (sdn != NULL) {
9eb798
-			sdn = slapi_sdn_add_rdn(sdn, rdn);
9eb798
-			ndn = slapi_sdn_get_ndn(sdn);
9eb798
-			if (ndn != NULL) {
9eb798
-				dn = slapi_ch_strdup(ndn);
9eb798
-			}
9eb798
-			slapi_sdn_free(&sdn;;
9eb798
-		}
9eb798
-	}
9eb798
-	free(val);
9eb798
-	slapi_rdn_free(&rdn;;
9eb798
-	return dn;
9eb798
-}
9eb798
-
9eb798
 static Slapi_Entry *
9eb798
 backend_make_user_entry_from_nsswitch_passwd(struct passwd *pwd,
9eb798
 					     char *container_sdn,
9eb798
@@ -257,7 +216,7 @@ backend_make_user_entry_from_nsswitch_passwd(struct passwd *pwd,
9eb798
 		return NULL;
9eb798
 	}
9eb798
 
9eb798
-	dn = backend_build_dn("uid", name, container_sdn);
9eb798
+	dn = format_build_dn("uid", name, container_sdn);
9eb798
 	if (dn == NULL) {
9eb798
 		slapi_log_error(SLAPI_LOG_FATAL,
9eb798
 				cbdata->state->plugin_desc->spd_id,
9eb798
@@ -556,7 +515,7 @@ backend_make_group_entry_from_nsswitch_group(struct group *grp,
9eb798
 		return NULL;
9eb798
 	}
9eb798
 
9eb798
-	dn = backend_build_dn("cn", grp->gr_name, container_sdn);
9eb798
+	dn = format_build_dn("cn", grp->gr_name, container_sdn);
9eb798
 	if (dn == NULL) {
9eb798
 		slapi_log_error(SLAPI_LOG_FATAL,
9eb798
 				cbdata->state->plugin_desc->spd_id,
9eb798
diff --git a/src/format.c b/src/format.c
9eb798
index ee6b8f3..ae4824c 100644
9eb798
--- a/src/format.c
9eb798
+++ b/src/format.c
9eb798
@@ -4825,3 +4825,44 @@ format_escape_for_filter(const char *unescaped)
9eb798
 	}
9eb798
 	return ret;
9eb798
 }
9eb798
+
9eb798
+char *
9eb798
+format_build_dn(const char *attribute, const char *value,
9eb798
+		const char *container_sdn)
9eb798
+{
9eb798
+	Slapi_RDN *rdn;
9eb798
+	Slapi_DN *sdn;
9eb798
+	char *val, *dn = NULL;
9eb798
+	const char *ndn, *hexchars = "0123456789ABCDEF";
9eb798
+	int i;
9eb798
+
9eb798
+	val = malloc(strlen(value) * 3 + 1);
9eb798
+	if (val == NULL) {
9eb798
+		return NULL;
9eb798
+	}
9eb798
+	rdn = slapi_rdn_new();
9eb798
+	if (rdn == NULL) {
9eb798
+		free(val);
9eb798
+		return NULL;
9eb798
+	}
9eb798
+        for (i = 0; value[i] != '\0'; i++) {
9eb798
+		val[i * 3] = '\\';
9eb798
+		val[i * 3 + 1] = hexchars[(value[i] & 0xf0) >> 4];
9eb798
+		val[i * 3 + 2] = hexchars[value[i] & 0xf];
9eb798
+	}
9eb798
+	val[i * 3] = '\0';
9eb798
+	if (slapi_rdn_add(rdn, attribute, val) == 1) {
9eb798
+		sdn = slapi_sdn_new_dn_byval(container_sdn);
9eb798
+		if (sdn != NULL) {
9eb798
+			sdn = slapi_sdn_add_rdn(sdn, rdn);
9eb798
+			ndn = slapi_sdn_get_ndn(sdn);
9eb798
+			if (ndn != NULL) {
9eb798
+				dn = slapi_ch_strdup(ndn);
9eb798
+			}
9eb798
+			slapi_sdn_free(&sdn;;
9eb798
+		}
9eb798
+	}
9eb798
+	free(val);
9eb798
+	slapi_rdn_free(&rdn;;
9eb798
+	return dn;
9eb798
+}
9eb798
diff --git a/src/format.h b/src/format.h
9eb798
index 4cde2dc..626d4a9 100644
9eb798
--- a/src/format.h
9eb798
+++ b/src/format.h
9eb798
@@ -83,4 +83,6 @@ char **format_get_data_set(struct plugin_state *state,
9eb798
 			   unsigned int **data_lengths);
9eb798
 
9eb798
 char *format_escape_for_filter(const char *unescaped);
9eb798
+char *format_build_dn(const char *attribute, const char *value,
9eb798
+		      const char *container_sdn);
9eb798
 #endif
9eb798
-- 
9eb798
2.13.6
9eb798