595b88
From 663824ef4ca927aa2b4319b69e0bfa68282ec719 Mon Sep 17 00:00:00 2001
595b88
From: Serge Hallyn <serge@hallyn.com>
595b88
Date: Sat, 22 May 2021 11:42:02 -0500
595b88
Subject: [PATCH] Fix useradd with SUB_UID_COUNT=0
595b88
595b88
Closes #298
595b88
595b88
Fix useradd when SUB_UID_COUNT=0 in login.defs.
595b88
595b88
Signed-off-by: Serge Hallyn <serge@hallyn.com>
595b88
---
595b88
 src/useradd.c | 8 ++++++--
595b88
 1 file changed, 6 insertions(+), 2 deletions(-)
595b88
595b88
diff --git a/src/useradd.c b/src/useradd.c
595b88
index 06accb2f..9862ae55 100644
595b88
--- a/src/useradd.c
595b88
+++ b/src/useradd.c
595b88
@@ -2386,6 +2386,8 @@ int main (int argc, char **argv)
595b88
 #ifdef ENABLE_SUBIDS
595b88
 	uid_t uid_min;
595b88
 	uid_t uid_max;
595b88
+	unsigned long subuid_count;
595b88
+	unsigned long subgid_count;
595b88
 #endif
595b88
 
595b88
 	/*
595b88
@@ -2427,9 +2429,11 @@ int main (int argc, char **argv)
595b88
 #ifdef ENABLE_SUBIDS
595b88
 	uid_min = (uid_t) getdef_ulong ("UID_MIN", 1000UL);
595b88
 	uid_max = (uid_t) getdef_ulong ("UID_MAX", 60000UL);
595b88
-	is_sub_uid = sub_uid_file_present () && !rflg &&
595b88
+	subuid_count = getdef_ulong ("SUB_UID_COUNT", 65536);
595b88
+	subgid_count = getdef_ulong ("SUB_GID_COUNT", 65536);
595b88
+	is_sub_uid = subuid_count > 0 && sub_uid_file_present () && !rflg &&
595b88
 	    (!user_id || (user_id <= uid_max && user_id >= uid_min));
595b88
-	is_sub_gid = sub_gid_file_present () && !rflg &&
595b88
+	is_sub_gid = subgid_count > 0 && sub_gid_file_present () && !rflg &&
595b88
 	    (!user_id || (user_id <= uid_max && user_id >= uid_min));
595b88
 #endif				/* ENABLE_SUBIDS */
595b88
 
595b88
-- 
595b88
2.30.2
595b88