595b88
diff -up shadow-4.6/configure.ac.libsubid_creation shadow-4.6/configure.ac
595b88
--- shadow-4.6/configure.ac.libsubid_creation	2021-10-19 16:12:02.663748272 +0200
595b88
+++ shadow-4.6/configure.ac	2021-10-19 16:13:07.194697194 +0200
595b88
@@ -1,11 +1,21 @@
595b88
 dnl Process this file with autoconf to produce a configure script.
595b88
-AC_PREREQ([2.64])
595b88
+AC_PREREQ([2.69])
595b88
+m4_define([libsubid_abi_major], 1)
595b88
+m4_define([libsubid_abi_minor], 0)
595b88
+m4_define([libsubid_abi_micro], 0)
595b88
+m4_define([libsubid_abi], [libsubid_abi_major.libsubid_abi_minor.libsubid_abi_micro])
595b88
 AC_INIT([shadow], [4.6], [pkg-shadow-devel@lists.alioth.debian.org], [],
595b88
 	[https://github.com/shadow-maint/shadow])
595b88
 AM_INIT_AUTOMAKE([1.11 foreign dist-xz])
595b88
+AC_CONFIG_MACRO_DIRS([m4])
595b88
 AM_SILENT_RULES([yes])
595b88
 AC_CONFIG_HEADERS([config.h])
595b88
 
595b88
+AC_SUBST([LIBSUBID_ABI_MAJOR], [libsubid_abi_major])
595b88
+AC_SUBST([LIBSUBID_ABI_MINOR], [libsubid_abi_minor])
595b88
+AC_SUBST([LIBSUBID_ABI_MICRO], [libsubid_abi_micro])
595b88
+AC_SUBST([LIBSUBID_ABI], [libsubid_abi])
595b88
+
595b88
 dnl Some hacks...
595b88
 test "$prefix" = "NONE" && prefix="/usr"
595b88
 test "$prefix" = "/usr" && exec_prefix=""
595b88
@@ -22,8 +22,8 @@ test "$prefix" = "/usr" && exec_prefix=""
595b88
 
595b88
 AC_GNU_SOURCE
595b88
 
595b88
-AM_DISABLE_SHARED
595b88
 AM_ENABLE_STATIC
595b88
+AM_ENABLE_SHARED
595b88
 
595b88
 AM_MAINTAINER_MODE
595b88
 
595b88
@@ -725,6 +725,7 @@ AC_CONFIG_FILES([
595b88
 	man/zh_TW/Makefile
595b88
 	libmisc/Makefile
595b88
 	lib/Makefile
595b88
+	libsubid/Makefile
595b88
 	src/Makefile
595b88
 	contrib/Makefile
595b88
 	etc/Makefile
595b88
diff -up shadow-4.6/libsubid/api.c.libsubid_creation shadow-4.6/libsubid/api.c
595b88
--- shadow-4.6/libsubid/api.c.libsubid_creation	2021-10-19 16:12:02.661748243 +0200
595b88
+++ shadow-4.6/libsubid/api.c	2021-10-19 16:12:02.661748243 +0200
595b88
@@ -0,0 +1,231 @@
595b88
+/*
595b88
+ * Copyright (c) 2020 Serge Hallyn
595b88
+ * All rights reserved.
595b88
+ *
595b88
+ * Redistribution and use in source and binary forms, with or without
595b88
+ * modification, are permitted provided that the following conditions
595b88
+ * are met:
595b88
+ * 1. Redistributions of source code must retain the above copyright
595b88
+ *    notice, this list of conditions and the following disclaimer.
595b88
+ * 2. Redistributions in binary form must reproduce the above copyright
595b88
+ *    notice, this list of conditions and the following disclaimer in the
595b88
+ *    documentation and/or other materials provided with the distribution.
595b88
+ * 3. The name of the copyright holders or contributors may not be used to
595b88
+ *    endorse or promote products derived from this software without
595b88
+ *    specific prior written permission.
595b88
+ *
595b88
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
595b88
+ * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
595b88
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
595b88
+ * PARTICULAR PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE COPYRIGHT
595b88
+ * HOLDERS OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
595b88
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
595b88
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
595b88
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
595b88
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
595b88
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
595b88
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
595b88
+ */
595b88
+
595b88
+#include <config.h>
595b88
+#include <fcntl.h>
595b88
+#include <stdio.h>
595b88
+#include <errno.h>
595b88
+#include <stdlib.h>
595b88
+#include <pwd.h>
595b88
+#include <stdbool.h>
595b88
+#include "subordinateio.h"
595b88
+#include "idmapping.h"
595b88
+#include "api.h"
595b88
+
595b88
+static struct subordinate_range **get_subid_ranges(const char *owner, enum subid_type id_type)
595b88
+{
595b88
+	struct subordinate_range **ranges = NULL;
595b88
+
595b88
+	switch (id_type) {
595b88
+	case ID_TYPE_UID:
595b88
+		if (!sub_uid_open(O_RDONLY)) {
595b88
+			return NULL;
595b88
+		}
595b88
+		break;
595b88
+	case ID_TYPE_GID:
595b88
+		if (!sub_gid_open(O_RDONLY)) {
595b88
+			return NULL;
595b88
+		}
595b88
+		break;
595b88
+	default:
595b88
+		return NULL;
595b88
+	}
595b88
+
595b88
+	ranges = list_owner_ranges(owner, id_type);
595b88
+
595b88
+	if (id_type == ID_TYPE_UID)
595b88
+		sub_uid_close();
595b88
+	else
595b88
+		sub_gid_close();
595b88
+
595b88
+	return ranges;
595b88
+}
595b88
+
595b88
+struct subordinate_range **get_subuid_ranges(const char *owner)
595b88
+{
595b88
+	return get_subid_ranges(owner, ID_TYPE_UID);
595b88
+}
595b88
+
595b88
+struct subordinate_range **get_subgid_ranges(const char *owner)
595b88
+{
595b88
+	return get_subid_ranges(owner, ID_TYPE_GID);
595b88
+}
595b88
+
595b88
+void subid_free_ranges(struct subordinate_range **ranges)
595b88
+{
595b88
+	return free_subordinate_ranges(ranges);
595b88
+}
595b88
+
595b88
+int get_subid_owner(unsigned long id, uid_t **owner, enum subid_type id_type)
595b88
+{
595b88
+	int ret = -1;
595b88
+
595b88
+	switch (id_type) {
595b88
+	case ID_TYPE_UID:
595b88
+		if (!sub_uid_open(O_RDONLY)) {
595b88
+			return -1;
595b88
+		}
595b88
+		break;
595b88
+	case ID_TYPE_GID:
595b88
+		if (!sub_gid_open(O_RDONLY)) {
595b88
+			return -1;
595b88
+		}
595b88
+		break;
595b88
+	default:
595b88
+		return -1;
595b88
+	}
595b88
+
595b88
+	ret = find_subid_owners(id, owner, id_type);
595b88
+
595b88
+	if (id_type == ID_TYPE_UID)
595b88
+		sub_uid_close();
595b88
+	else
595b88
+		sub_gid_close();
595b88
+
595b88
+	return ret;
595b88
+}
595b88
+
595b88
+int get_subuid_owners(uid_t uid, uid_t **owner)
595b88
+{
595b88
+	return get_subid_owner((unsigned long)uid, owner, ID_TYPE_UID);
595b88
+}
595b88
+
595b88
+int get_subgid_owners(gid_t gid, uid_t **owner)
595b88
+{
595b88
+	return get_subid_owner((unsigned long)gid, owner, ID_TYPE_GID);
595b88
+}
595b88
+
595b88
+bool grant_subid_range(struct subordinate_range *range, bool reuse,
595b88
+		       enum subid_type id_type)
595b88
+{
595b88
+	bool ret;
595b88
+
595b88
+	switch (id_type) {
595b88
+	case ID_TYPE_UID:
595b88
+		if (!sub_uid_lock()) {
595b88
+			printf("Failed loging subuids (errno %d)\n", errno);
595b88
+			return false;
595b88
+		}
595b88
+		if (!sub_uid_open(O_CREAT | O_RDWR)) {
595b88
+			printf("Failed opening subuids (errno %d)\n", errno);
595b88
+			sub_uid_unlock();
595b88
+			return false;
595b88
+		}
595b88
+		break;
595b88
+	case ID_TYPE_GID:
595b88
+		if (!sub_gid_lock()) {
595b88
+			printf("Failed loging subgids (errno %d)\n", errno);
595b88
+			return false;
595b88
+		}
595b88
+		if (!sub_gid_open(O_CREAT | O_RDWR)) {
595b88
+			printf("Failed opening subgids (errno %d)\n", errno);
595b88
+			sub_gid_unlock();
595b88
+			return false;
595b88
+		}
595b88
+		break;
595b88
+	default:
595b88
+		return false;
595b88
+	}
595b88
+
595b88
+	ret = new_subid_range(range, id_type, reuse);
595b88
+
595b88
+	if (id_type == ID_TYPE_UID) {
595b88
+		sub_uid_close();
595b88
+		sub_uid_unlock();
595b88
+	} else {
595b88
+		sub_gid_close();
595b88
+		sub_gid_unlock();
595b88
+	}
595b88
+
595b88
+	return ret;
595b88
+}
595b88
+
595b88
+bool grant_subuid_range(struct subordinate_range *range, bool reuse)
595b88
+{
595b88
+	return grant_subid_range(range, reuse, ID_TYPE_UID);
595b88
+}
595b88
+
595b88
+bool grant_subgid_range(struct subordinate_range *range, bool reuse)
595b88
+{
595b88
+	return grant_subid_range(range, reuse, ID_TYPE_GID);
595b88
+}
595b88
+
595b88
+bool free_subid_range(struct subordinate_range *range, enum subid_type id_type)
595b88
+{
595b88
+	bool ret;
595b88
+
595b88
+	switch (id_type) {
595b88
+	case ID_TYPE_UID:
595b88
+		if (!sub_uid_lock()) {
595b88
+			printf("Failed loging subuids (errno %d)\n", errno);
595b88
+			return false;
595b88
+		}
595b88
+		if (!sub_uid_open(O_CREAT | O_RDWR)) {
595b88
+			printf("Failed opening subuids (errno %d)\n", errno);
595b88
+			sub_uid_unlock();
595b88
+			return false;
595b88
+		}
595b88
+		break;
595b88
+	case ID_TYPE_GID:
595b88
+		if (!sub_gid_lock()) {
595b88
+			printf("Failed loging subgids (errno %d)\n", errno);
595b88
+			return false;
595b88
+		}
595b88
+		if (!sub_gid_open(O_CREAT | O_RDWR)) {
595b88
+			printf("Failed opening subgids (errno %d)\n", errno);
595b88
+			sub_gid_unlock();
595b88
+			return false;
595b88
+		}
595b88
+		break;
595b88
+	default:
595b88
+		return false;
595b88
+	}
595b88
+
595b88
+	ret = release_subid_range(range, id_type);
595b88
+
595b88
+	if (id_type == ID_TYPE_UID) {
595b88
+		sub_uid_close();
595b88
+		sub_uid_unlock();
595b88
+	} else {
595b88
+		sub_gid_close();
595b88
+		sub_gid_unlock();
595b88
+	}
595b88
+
595b88
+	return ret;
595b88
+}
595b88
+
595b88
+bool free_subuid_range(struct subordinate_range *range)
595b88
+{
595b88
+	return free_subid_range(range, ID_TYPE_UID);
595b88
+}
595b88
+
595b88
+bool free_subgid_range(struct subordinate_range *range)
595b88
+{
595b88
+	return free_subid_range(range, ID_TYPE_GID);
595b88
+}
595b88
diff -up shadow-4.6/libsubid/api.h.libsubid_creation shadow-4.6/libsubid/api.h
595b88
--- shadow-4.6/libsubid/api.h.libsubid_creation	2021-10-19 16:12:02.661748243 +0200
595b88
+++ shadow-4.6/libsubid/api.h	2021-10-19 16:12:02.662748257 +0200
595b88
@@ -0,0 +1,17 @@
595b88
+#include "subid.h"
595b88
+#include <stdbool.h>
595b88
+
595b88
+struct subordinate_range **get_subuid_ranges(const char *owner);
595b88
+struct subordinate_range **get_subgid_ranges(const char *owner);
595b88
+void subid_free_ranges(struct subordinate_range **ranges);
595b88
+
595b88
+int get_subuid_owners(uid_t uid, uid_t **owner);
595b88
+int get_subgid_owners(gid_t gid, uid_t **owner);
595b88
+
595b88
+/* range should be pre-allocated with owner and count filled in, start is
595b88
+ * ignored, can be 0 */
595b88
+bool grant_subuid_range(struct subordinate_range *range, bool reuse);
595b88
+bool grant_subgid_range(struct subordinate_range *range, bool reuse);
595b88
+
595b88
+bool free_subuid_range(struct subordinate_range *range);
595b88
+bool free_subgid_range(struct subordinate_range *range);
595b88
diff -up shadow-4.6/libsubid/Makefile.am.libsubid_creation shadow-4.6/libsubid/Makefile.am
595b88
--- shadow-4.6/libsubid/Makefile.am.libsubid_creation	2021-10-19 16:12:02.661748243 +0200
595b88
+++ shadow-4.6/libsubid/Makefile.am	2021-10-19 16:12:02.662748257 +0200
595b88
@@ -0,0 +1,24 @@
595b88
+lib_LTLIBRARIES = libsubid.la
595b88
+libsubid_la_LDFLAGS = -Wl,-soname,libsubid.so.@LIBSUBID_ABI@ \
595b88
+	-shared -version-info @LIBSUBID_ABI_MAJOR@
595b88
+libsubid_la_SOURCES = api.c
595b88
+
595b88
+MISCLIBS = \
595b88
+	$(LIBAUDIT) \
595b88
+	$(LIBSELINUX) \
595b88
+	$(LIBSEMANAGE) \
595b88
+	$(LIBCRYPT_NOPAM) \
595b88
+	$(LIBSKEY) \
595b88
+	$(LIBMD) \
595b88
+	$(LIBCRYPT) \
595b88
+	$(LIBTCB)
595b88
+
595b88
+libsubid_la_LIBADD = \
595b88
+	$(top_srcdir)/lib/libshadow.la \
595b88
+	$(MISCLIBS) \
595b88
+	$(top_srcdir)/libmisc/libmisc.a
595b88
+
595b88
+AM_CPPFLAGS = \
595b88
+	-I${top_srcdir}/lib \
595b88
+	-I${top_srcdir}/libmisc \
595b88
+	-DLOCALEDIR=\"$(datadir)/locale\"
595b88
diff -up shadow-4.6/libsubid/subid.h.libsubid_creation shadow-4.6/libsubid/subid.h
595b88
--- shadow-4.6/libsubid/subid.h.libsubid_creation	2021-10-19 16:12:02.661748243 +0200
595b88
+++ shadow-4.6/libsubid/subid.h	2021-10-19 16:12:02.661748243 +0200
595b88
@@ -0,0 +1,17 @@
595b88
+#include <sys/types.h>
595b88
+
595b88
+#ifndef SUBID_RANGE_DEFINED
595b88
+#define SUBID_RANGE_DEFINED 1
595b88
+struct subordinate_range {
595b88
+	const char *owner;
595b88
+	unsigned long start;
595b88
+	unsigned long count;
595b88
+};
595b88
+
595b88
+enum subid_type {
595b88
+	ID_TYPE_UID = 1,
595b88
+	ID_TYPE_GID = 2
595b88
+};
595b88
+
595b88
+#define SUBID_NFIELDS 3
595b88
+#endif
595b88
diff -up shadow-4.6/lib/subordinateio.c.libsubid_creation shadow-4.6/lib/subordinateio.c
595b88
--- shadow-4.6/lib/subordinateio.c.libsubid_creation	2021-10-19 16:12:02.654748139 +0200
595b88
+++ shadow-4.6/lib/subordinateio.c	2021-10-19 16:12:02.661748243 +0200
595b88
@@ -13,14 +13,7 @@
595b88
 #include "subordinateio.h"
595b88
 #include <sys/types.h>
595b88
 #include <pwd.h>
595b88
-
595b88
-struct subordinate_range {
595b88
-	const char *owner;
595b88
-	unsigned long start;
595b88
-	unsigned long count;
595b88
-};
595b88
-
595b88
-#define NFIELDS 3
595b88
+#include <ctype.h>
595b88
 
595b88
 /*
595b88
  * subordinate_dup: create a duplicate range
595b88
@@ -78,7 +71,7 @@ static void *subordinate_parse (const ch
595b88
 	static char rangebuf[1024];
595b88
 	int i;
595b88
 	char *cp;
595b88
-	char *fields[NFIELDS];
595b88
+	char *fields[SUBID_NFIELDS];
595b88
 
595b88
 	/*
595b88
 	 * Copy the string to a temporary buffer so the substrings can
595b88
@@ -93,7 +86,7 @@ static void *subordinate_parse (const ch
595b88
 	 * field.  The fields are converted into NUL terminated strings.
595b88
 	 */
595b88
 
595b88
-	for (cp = rangebuf, i = 0; (i < NFIELDS) && (NULL != cp); i++) {
595b88
+	for (cp = rangebuf, i = 0; (i < SUBID_NFIELDS) && (NULL != cp); i++) {
595b88
 		fields[i] = cp;
595b88
 		while (('\0' != *cp) && (':' != *cp)) {
595b88
 			cp++;
595b88
@@ -108,10 +101,10 @@ static void *subordinate_parse (const ch
595b88
 	}
595b88
 
595b88
 	/*
595b88
-	 * There must be exactly NFIELDS colon separated fields or
595b88
+	 * There must be exactly SUBID_NFIELDS colon separated fields or
595b88
 	 * the entry is invalid.  Also, fields must be non-blank.
595b88
 	 */
595b88
-	if (i != NFIELDS || *fields[0] == '\0' || *fields[1] == '\0' || *fields[2] == '\0')
595b88
+	if (i != SUBID_NFIELDS || *fields[0] == '\0' || *fields[1] == '\0' || *fields[2] == '\0')
595b88
 		return NULL;
595b88
 	range.owner = fields[0];
595b88
 	if (getulong (fields[1], &range.start) == 0)
595b88
@@ -319,6 +312,39 @@ static bool have_range(struct commonio_d
595b88
 	return false;
595b88
 }
595b88
 
595b88
+static bool append_range(struct subordinate_range ***ranges, const struct subordinate_range *new, int n)
595b88
+{
595b88
+	struct subordinate_range *tmp;
595b88
+	if (!*ranges) {
595b88
+		*ranges = malloc(2 * sizeof(struct subordinate_range **));
595b88
+		if (!*ranges)
595b88
+			return false;
595b88
+	} else {
595b88
+		struct subordinate_range **new;
595b88
+		new = realloc(*ranges, (n + 2) * (sizeof(struct subordinate_range **)));
595b88
+		if (!new)
595b88
+			return false;
595b88
+		*ranges = new;
595b88
+	}
595b88
+	(*ranges)[n] = (*ranges)[n+1] = NULL;
595b88
+	tmp = subordinate_dup(new);
595b88
+	if (!tmp)
595b88
+		return false;
595b88
+	(*ranges)[n] = tmp;
595b88
+	return true;
595b88
+}
595b88
+
595b88
+void free_subordinate_ranges(struct subordinate_range **ranges)
595b88
+{
595b88
+	int i;
595b88
+
595b88
+	if (!ranges)
595b88
+		return;
595b88
+	for (i = 0; ranges[i]; i++)
595b88
+		subordinate_free(ranges[i]);
595b88
+	free(ranges);
595b88
+}
595b88
+
595b88
 /*
595b88
  * subordinate_range_cmp: compare uid ranges
595b88
  *
595b88
@@ -697,6 +723,160 @@ gid_t sub_gid_find_free_range(gid_t min,
595b88
 	start = find_free_range (&subordinate_gid_db, min, max, count);
595b88
 	return start == ULONG_MAX ? (gid_t) -1 : start;
595b88
 }
595b88
+
595b88
+/*
595b88
+ struct subordinate_range **list_owner_ranges(const char *owner, enum subid_type id_type)
595b88
+ *
595b88
+ * @owner: username
595b88
+ * @id_type: UID or GUID
595b88
+ *
595b88
+ * Returns the subuid or subgid ranges which are owned by the specified
595b88
+ * user.  Username may be a username or a string representation of a
595b88
+ * UID number.  If id_type is UID, then subuids are returned, else
595b88
+ * subgids are returned.  If there is an error, < 0 is returned.
595b88
+ *
595b88
+ * The caller must free the subordinate range list.
595b88
+ */
595b88
+struct subordinate_range **list_owner_ranges(const char *owner, enum subid_type id_type)
595b88
+{
595b88
+	// TODO - need to handle owner being either uid or username
595b88
+	const struct subordinate_range *range;
595b88
+	struct subordinate_range **ranges = NULL;
595b88
+	struct commonio_db *db;
595b88
+	int size = 0;
595b88
+
595b88
+	if (id_type == ID_TYPE_UID)
595b88
+		db = &subordinate_uid_db;
595b88
+	else
595b88
+		db = &subordinate_gid_db;
595b88
+
595b88
+	commonio_rewind(db);
595b88
+	while ((range = commonio_next(db)) != NULL) {
595b88
+		if (0 == strcmp(range->owner, owner)) {
595b88
+			if (!append_range(&ranges, range, size++)) {
595b88
+				free_subordinate_ranges(ranges);
595b88
+				return NULL;
595b88
+			}
595b88
+		}
595b88
+	}
595b88
+
595b88
+	return ranges;
595b88
+}
595b88
+
595b88
+static bool all_digits(const char *str)
595b88
+{
595b88
+	int i;
595b88
+
595b88
+	for (i = 0; str[i] != '\0'; i++)
595b88
+		if (!isdigit(str[i]))
595b88
+			return false;
595b88
+	return true;
595b88
+}
595b88
+
595b88
+static int append_uids(uid_t **uids, const char *owner, int n)
595b88
+{
595b88
+	uid_t owner_uid;
595b88
+	uid_t *ret;
595b88
+	int i;
595b88
+
595b88
+	if (all_digits(owner)) {
595b88
+		i = sscanf(owner, "%d", &owner_uid);
595b88
+		if (i != 1) {
595b88
+			// should not happen
595b88
+			free(*uids);
595b88
+			*uids = NULL;
595b88
+			return -1;
595b88
+		}
595b88
+	} else {
595b88
+		struct passwd *pwd = getpwnam(owner);
595b88
+		if (NULL == pwd) {
595b88
+			/* Username not defined in /etc/passwd, or error occured during lookup */
595b88
+			free(*uids);
595b88
+			*uids = NULL;
595b88
+			return -1;
595b88
+		}
595b88
+		owner_uid = pwd->pw_uid;
595b88
+	}
595b88
+
595b88
+	for (i = 0; i < n; i++) {
595b88
+		if (owner_uid == (*uids)[i])
595b88
+			return n;
595b88
+	}
595b88
+
595b88
+	ret = realloc(*uids, (n + 1) * sizeof(uid_t));
595b88
+	if (!ret) {
595b88
+		free(*uids);
595b88
+		return -1;
595b88
+	}
595b88
+	ret[n] = owner_uid;
595b88
+	*uids = ret;
595b88
+	return n+1;
595b88
+}
595b88
+
595b88
+int find_subid_owners(unsigned long id, uid_t **uids, enum subid_type id_type)
595b88
+{
595b88
+	const struct subordinate_range *range;
595b88
+	struct commonio_db *db;
595b88
+	int n = 0;
595b88
+
595b88
+	*uids = NULL;
595b88
+	if (id_type == ID_TYPE_UID)
595b88
+		db = &subordinate_uid_db;
595b88
+	else
595b88
+		db = &subordinate_gid_db;
595b88
+
595b88
+	commonio_rewind(db);
595b88
+	while ((range = commonio_next(db)) != NULL) {
595b88
+		if (id >= range->start && id < range->start + range-> count) {
595b88
+			n = append_uids(uids, range->owner, n);
595b88
+			if (n < 0)
595b88
+				break;
595b88
+		}
595b88
+	}
595b88
+
595b88
+	return n;
595b88
+}
595b88
+
595b88
+bool new_subid_range(struct subordinate_range *range, enum subid_type id_type, bool reuse)
595b88
+{
595b88
+	struct commonio_db *db;
595b88
+	const struct subordinate_range *r;
595b88
+
595b88
+	if (id_type == ID_TYPE_UID)
595b88
+		db = &subordinate_uid_db;
595b88
+	else
595b88
+		db = &subordinate_gid_db;
595b88
+	commonio_rewind(db);
595b88
+	if (reuse) {
595b88
+		while ((r = commonio_next(db)) != NULL) {
595b88
+			// TODO account for username vs uid_t
595b88
+			if (0 != strcmp(r->owner, range->owner))
595b88
+				continue;
595b88
+			if (r->count >= range->count) {
595b88
+				range->count = r->count;
595b88
+				range->start = r->start;
595b88
+				return true;
595b88
+			}
595b88
+		}
595b88
+	}
595b88
+
595b88
+	range->start = find_free_range(db, range->start, ULONG_MAX, range->count);
595b88
+	if (range->start == ULONG_MAX)
595b88
+		return false;
595b88
+
595b88
+	return add_range(db, range->owner, range->start, range->count) == 1;
595b88
+}
595b88
+
595b88
+bool release_subid_range(struct subordinate_range *range, enum subid_type id_type)
595b88
+{
595b88
+	struct commonio_db *db;
595b88
+	if (id_type == ID_TYPE_UID)
595b88
+		db = &subordinate_uid_db;
595b88
+	else
595b88
+		db = &subordinate_gid_db;
595b88
+	return remove_range(db, range->owner, range->start, range->count) == 1;
595b88
+}
595b88
+
595b88
 #else				/* !ENABLE_SUBIDS */
595b88
 extern int errno;		/* warning: ANSI C forbids an empty source file */
595b88
 #endif				/* !ENABLE_SUBIDS */
595b88
diff -up shadow-4.6/lib/subordinateio.h.libsubid_creation shadow-4.6/lib/subordinateio.h
595b88
--- shadow-4.6/lib/subordinateio.h.libsubid_creation	2018-04-29 18:42:37.000000000 +0200
595b88
+++ shadow-4.6/lib/subordinateio.h	2021-10-19 16:12:02.661748243 +0200
595b88
@@ -11,6 +11,8 @@
595b88
 
595b88
 #include <sys/types.h>
595b88
 
595b88
+#include "../libsubid/subid.h"
595b88
+
595b88
 extern int sub_uid_close(void);
595b88
 extern bool have_sub_uids(const char *owner, uid_t start, unsigned long count);
595b88
 extern bool sub_uid_file_present (void);
595b88
@@ -23,6 +25,11 @@ extern int sub_uid_unlock (void);
595b88
 extern int sub_uid_add (const char *owner, uid_t start, unsigned long count);
595b88
 extern int sub_uid_remove (const char *owner, uid_t start, unsigned long count);
595b88
 extern uid_t sub_uid_find_free_range(uid_t min, uid_t max, unsigned long count);
595b88
+extern struct subordinate_range **list_owner_ranges(const char *owner, enum subid_type id_type);
595b88
+extern bool new_subid_range(struct subordinate_range *range, enum subid_type id_type, bool reuse);
595b88
+extern bool release_subid_range(struct subordinate_range *range, enum subid_type id_type);
595b88
+extern int find_subid_owners(unsigned long id, uid_t **uids, enum subid_type id_type);
595b88
+extern void free_subordinate_ranges(struct subordinate_range **ranges);
595b88
 
595b88
 extern int sub_gid_close(void);
595b88
 extern bool have_sub_gids(const char *owner, gid_t start, unsigned long count);
595b88
diff -up shadow-4.6/Makefile.am.libsubid_creation shadow-4.6/Makefile.am
595b88
--- shadow-4.6/Makefile.am.libsubid_creation	2018-04-29 18:42:37.000000000 +0200
595b88
+++ shadow-4.6/Makefile.am	2021-10-19 16:12:02.660748228 +0200
595b88
@@ -2,5 +2,14 @@
595b88
 
595b88
 EXTRA_DIST = NEWS README TODO shadow.spec.in
595b88
 
595b88
-SUBDIRS = po man libmisc lib src \
595b88
-	contrib doc etc
595b88
+SUBDIRS = libmisc lib 
595b88
+
595b88
+if ENABLE_SUBIDS
595b88
+SUBDIRS += libsubid
595b88
+endif
595b88
+
595b88
+SUBDIRS += src po contrib doc etc
595b88
+
595b88
+if ENABLE_REGENERATE_MAN
595b88
+SUBDIRS += man
595b88
+endif
595b88
diff -up shadow-4.6/src/free_subid_range.c.libsubid_creation shadow-4.6/src/free_subid_range.c
595b88
--- shadow-4.6/src/free_subid_range.c.libsubid_creation	2021-10-19 16:12:02.661748243 +0200
595b88
+++ shadow-4.6/src/free_subid_range.c	2021-10-19 16:12:02.661748243 +0200
595b88
@@ -0,0 +1,50 @@
595b88
+#include <stdio.h>
595b88
+#include <unistd.h>
595b88
+#include "api.h"
595b88
+#include "stdlib.h"
595b88
+#include "prototypes.h"
595b88
+
595b88
+/* Test program for the subid freeing routine */
595b88
+
595b88
+const char *Prog;
595b88
+
595b88
+void usage(void)
595b88
+{
595b88
+	fprintf(stderr, "Usage: %s [-g] user start count\n", Prog);
595b88
+	fprintf(stderr, "    Release a user's subuid (or with -g, subgid) range\n");
595b88
+	exit(EXIT_FAILURE);
595b88
+}
595b88
+
595b88
+int main(int argc, char *argv[])
595b88
+{
595b88
+	int c;
595b88
+	bool ok;
595b88
+	struct subordinate_range range;
595b88
+	bool group = false;   // get subuids by default
595b88
+
595b88
+	Prog = Basename (argv[0]);
595b88
+	while ((c = getopt(argc, argv, "g")) != EOF) {
595b88
+		switch(c) {
595b88
+		case 'g': group = true; break;
595b88
+		default: usage();
595b88
+		}
595b88
+	}
595b88
+	argv = &argv[optind];
595b88
+	argc = argc - optind;
595b88
+	if (argc < 3)
595b88
+		usage();
595b88
+	range.owner = argv[0];
595b88
+	range.start = atoi(argv[1]);
595b88
+	range.count = atoi(argv[2]);
595b88
+	if (group)
595b88
+		ok = free_subgid_range(&range);
595b88
+	else
595b88
+		ok = free_subuid_range(&range);
595b88
+
595b88
+	if (!ok) {
595b88
+		fprintf(stderr, "Failed freeing id range\n");
595b88
+		exit(EXIT_FAILURE);
595b88
+	}
595b88
+
595b88
+	return 0;
595b88
+}
595b88
diff -up shadow-4.6/src/get_subid_owners.c.libsubid_creation shadow-4.6/src/get_subid_owners.c
595b88
--- shadow-4.6/src/get_subid_owners.c.libsubid_creation	2021-10-19 16:12:02.661748243 +0200
595b88
+++ shadow-4.6/src/get_subid_owners.c	2021-10-19 16:12:02.661748243 +0200
595b88
@@ -0,0 +1,40 @@
595b88
+#include <stdio.h>
595b88
+#include "api.h"
595b88
+#include "stdlib.h"
595b88
+#include "prototypes.h"
595b88
+
595b88
+const char *Prog;
595b88
+
595b88
+void usage(void)
595b88
+{
595b88
+	fprintf(stderr, "Usage: [-g] %s subuid\n", Prog);
595b88
+	fprintf(stderr, "    list uids who own the given subuid\n");
595b88
+	fprintf(stderr, "    pass -g to query a subgid\n");
595b88
+	exit(EXIT_FAILURE);
595b88
+}
595b88
+
595b88
+int main(int argc, char *argv[])
595b88
+{
595b88
+	int i, n;
595b88
+	uid_t *uids;
595b88
+
595b88
+	Prog = Basename (argv[0]);
595b88
+	if (argc < 2) {
595b88
+		usage();
595b88
+	}
595b88
+	if (argc == 3 && strcmp(argv[1], "-g") == 0)
595b88
+		n = get_subgid_owners(atoi(argv[2]), &uids);
595b88
+	else if (argc == 2 && strcmp(argv[1], "-h") == 0)
595b88
+		usage();
595b88
+	else
595b88
+		n = get_subuid_owners(atoi(argv[1]), &uids);
595b88
+	if (n < 0) {
595b88
+		fprintf(stderr, "No owners found\n");
595b88
+		exit(1);
595b88
+	}
595b88
+	for (i = 0; i < n; i++) {
595b88
+		printf("%d\n", uids[i]);
595b88
+	}
595b88
+	free(uids);
595b88
+	return 0;
595b88
+}
595b88
diff -up shadow-4.6/src/list_subid_ranges.c.libsubid_creation shadow-4.6/src/list_subid_ranges.c
595b88
--- shadow-4.6/src/list_subid_ranges.c.libsubid_creation	2021-10-19 16:12:02.661748243 +0200
595b88
+++ shadow-4.6/src/list_subid_ranges.c	2021-10-19 16:12:02.661748243 +0200
595b88
@@ -0,0 +1,41 @@
595b88
+#include <stdio.h>
595b88
+#include "api.h"
595b88
+#include "stdlib.h"
595b88
+#include "prototypes.h"
595b88
+
595b88
+const char *Prog;
595b88
+
595b88
+void usage(void)
595b88
+{
595b88
+	fprintf(stderr, "Usage: %s [-g] user\n", Prog);
595b88
+	fprintf(stderr, "    list subuid ranges for user\n");
595b88
+	fprintf(stderr, "    pass -g to list subgid ranges\n");
595b88
+	exit(EXIT_FAILURE);
595b88
+}
595b88
+
595b88
+int main(int argc, char *argv[])
595b88
+{
595b88
+	int i;
595b88
+	struct subordinate_range **ranges;
595b88
+
595b88
+	Prog = Basename (argv[0]);
595b88
+	if (argc < 2) {
595b88
+		usage();
595b88
+	}
595b88
+	if (argc == 3 && strcmp(argv[1], "-g") == 0)
595b88
+		ranges = get_subgid_ranges(argv[2]);
595b88
+	else if (argc == 2 && strcmp(argv[1], "-h") == 0)
595b88
+		usage();
595b88
+	else
595b88
+		ranges = get_subuid_ranges(argv[1]);
595b88
+	if (!ranges) {
595b88
+		fprintf(stderr, "Error fetching ranges\n");
595b88
+		exit(1);
595b88
+	}
595b88
+	for (i = 0; ranges[i]; i++) {
595b88
+		printf("%d: %s %lu %lu\n", i, ranges[i]->owner,
595b88
+			ranges[i]->start, ranges[i]->count);
595b88
+	}
595b88
+	subid_free_ranges(ranges);
595b88
+	return 0;
595b88
+}
595b88
diff -up shadow-4.6/src/new_subid_range.c.libsubid_creation shadow-4.6/src/new_subid_range.c
595b88
--- shadow-4.6/src/new_subid_range.c.libsubid_creation	2021-10-19 16:12:02.661748243 +0200
595b88
+++ shadow-4.6/src/new_subid_range.c	2021-10-19 16:12:02.661748243 +0200
595b88
@@ -0,0 +1,57 @@
595b88
+#include <stdio.h>
595b88
+#include <unistd.h>
595b88
+#include "api.h"
595b88
+#include "stdlib.h"
595b88
+#include "prototypes.h"
595b88
+
595b88
+/* Test program for the subid creation routine */
595b88
+
595b88
+const char *Prog;
595b88
+
595b88
+void usage(void)
595b88
+{
595b88
+	fprintf(stderr, "Usage: %s [-g] [-n] user count\n", Prog);
595b88
+	fprintf(stderr, "    Find a subuid (or with -g, subgid) range for user\n");
595b88
+	fprintf(stderr, "    If -n is given, a new range will be created even if one exists\n");
595b88
+	fprintf(stderr, "    count defaults to 65536\n");
595b88
+	exit(EXIT_FAILURE);
595b88
+}
595b88
+
595b88
+int main(int argc, char *argv[])
595b88
+{
595b88
+	int c;
595b88
+	struct subordinate_range range;
595b88
+	bool makenew = false; // reuse existing by default
595b88
+	bool group = false;   // get subuids by default
595b88
+	bool ok;
595b88
+
595b88
+	Prog = Basename (argv[0]);
595b88
+	while ((c = getopt(argc, argv, "gn")) != EOF) {
595b88
+		switch(c) {
595b88
+		case 'n': makenew = true; break;
595b88
+		case 'g': group = true; break;
595b88
+		default: usage();
595b88
+		}
595b88
+	}
595b88
+	argv = &argv[optind];
595b88
+	argc = argc - optind;
595b88
+	if (argc == 0)
595b88
+		usage();
595b88
+	range.owner = argv[0];
595b88
+	range.start = 0;
595b88
+	range.count = 65536;
595b88
+	if (argc > 1)
595b88
+		range.count = atoi(argv[1]);
595b88
+	if (group)
595b88
+		ok = grant_subgid_range(&range, !makenew);
595b88
+	else
595b88
+		ok = grant_subuid_range(&range, !makenew);
595b88
+
595b88
+	if (!ok) {
595b88
+		fprintf(stderr, "Failed creating new id range\n");
595b88
+		exit(EXIT_FAILURE);
595b88
+	}
595b88
+	printf("Subuid range %lu:%lu\n", range.start, range.count);
595b88
+
595b88
+	return 0;
595b88
+}
595b88
diff -up shadow-4.6/tests/libsubid/01_list_ranges/config/etc/subgid.libsubid_creation shadow-4.6/tests/libsubid/01_list_ranges/config/etc/subgid
595b88
--- shadow-4.6/tests/libsubid/01_list_ranges/config/etc/subgid.libsubid_creation	2021-10-19 16:12:02.662748257 +0200
595b88
+++ shadow-4.6/tests/libsubid/01_list_ranges/config/etc/subgid	2021-10-19 16:12:02.662748257 +0200
595b88
@@ -0,0 +1,2 @@
595b88
+foo:200000:10000
595b88
+root:500000:1000
595b88
diff -up shadow-4.6/tests/libsubid/01_list_ranges/config/etc/subuid.libsubid_creation shadow-4.6/tests/libsubid/01_list_ranges/config/etc/subuid
595b88
--- shadow-4.6/tests/libsubid/01_list_ranges/config/etc/subuid.libsubid_creation	2021-10-19 16:12:02.662748257 +0200
595b88
+++ shadow-4.6/tests/libsubid/01_list_ranges/config/etc/subuid	2021-10-19 16:12:02.662748257 +0200
595b88
@@ -0,0 +1,3 @@
595b88
+foo:300000:10000
595b88
+foo:400000:10000
595b88
+root:500000:1000
595b88
diff -up shadow-4.6/tests/libsubid/01_list_ranges/config.txt.libsubid_creation shadow-4.6/tests/libsubid/01_list_ranges/config.txt
595b88
diff -up shadow-4.6/tests/libsubid/01_list_ranges/list_ranges.test.libsubid_creation shadow-4.6/tests/libsubid/01_list_ranges/list_ranges.test
595b88
--- shadow-4.6/tests/libsubid/01_list_ranges/list_ranges.test.libsubid_creation	2021-10-19 16:12:02.662748257 +0200
595b88
+++ shadow-4.6/tests/libsubid/01_list_ranges/list_ranges.test	2021-10-19 16:12:02.662748257 +0200
595b88
@@ -0,0 +1,38 @@
595b88
+#!/bin/sh
595b88
+
595b88
+set -e
595b88
+
595b88
+cd $(dirname $0)
595b88
+
595b88
+. ../../common/config.sh
595b88
+. ../../common/log.sh
595b88
+
595b88
+log_start "$0" "list_ranges shows subid ranges"
595b88
+
595b88
+save_config
595b88
+
595b88
+# restore the files on exit
595b88
+trap 'log_status "$0" "FAILURE"; restore_config' 0
595b88
+
595b88
+change_config
595b88
+
595b88
+echo -n "list foo's ranges..."
595b88
+${build_path}/src/list_subid_ranges foo > /tmp/subuidlistout
595b88
+${build_path}/src/list_subid_ranges -g foo > /tmp/subgidlistout
595b88
+echo "OK"
595b88
+
595b88
+echo -n "Check the subuid ranges..."
595b88
+[ $(wc -l /tmp/subuidlistout | awk '{ print $1 }') -eq 2 ]
595b88
+grep "0: foo 300000 10000" /tmp/subuidlistout
595b88
+grep "1: foo 400000 10000" /tmp/subuidlistout
595b88
+echo "OK"
595b88
+
595b88
+echo -n "Check the subgid ranges..."
595b88
+[ $(wc -l /tmp/subgidlistout | awk '{ print $1 }') -eq 1 ]
595b88
+grep "0: foo 200000 10000" /tmp/subgidlistout
595b88
+echo "OK"
595b88
+
595b88
+log_status "$0" "SUCCESS"
595b88
+restore_config
595b88
+trap '' 0
595b88
+
595b88
diff -up shadow-4.6/tests/libsubid/02_get_subid_owners/config/etc/passwd.libsubid_creation shadow-4.6/tests/libsubid/02_get_subid_owners/config/etc/passwd
595b88
--- shadow-4.6/tests/libsubid/02_get_subid_owners/config/etc/passwd.libsubid_creation	2021-10-19 16:12:02.662748257 +0200
595b88
+++ shadow-4.6/tests/libsubid/02_get_subid_owners/config/etc/passwd	2021-10-19 16:12:02.662748257 +0200
595b88
@@ -0,0 +1,20 @@
595b88
+root:x:0:0:root:/root:/bin/bash
595b88
+daemon:x:1:1:daemon:/usr/sbin:/bin/sh
595b88
+bin:x:2:2:bin:/bin:/bin/sh
595b88
+sys:x:3:3:sys:/dev:/bin/sh
595b88
+sync:x:4:65534:sync:/bin:/bin/sync
595b88
+games:x:5:60:games:/usr/games:/bin/sh
595b88
+man:x:6:12:man:/var/cache/man:/bin/sh
595b88
+lp:x:7:7:lp:/var/spool/lpd:/bin/sh
595b88
+mail:x:8:8:mail:/var/mail:/bin/sh
595b88
+news:x:9:9:news:/var/spool/news:/bin/sh
595b88
+uucp:x:10:10:uucp:/var/spool/uucp:/bin/sh
595b88
+proxy:x:13:13:proxy:/bin:/bin/sh
595b88
+www-data:x:33:33:www-data:/var/www:/bin/sh
595b88
+backup:x:34:34:backup:/var/backups:/bin/sh
595b88
+list:x:38:38:Mailing List Manager:/var/list:/bin/sh
595b88
+irc:x:39:39:ircd:/var/run/ircd:/bin/sh
595b88
+gnats:x:41:41:Gnats Bug-Reporting System (admin):/var/lib/gnats:/bin/sh
595b88
+nobody:x:65534:65534:nobody:/nonexistent:/bin/sh
595b88
+Debian-exim:x:102:102::/var/spool/exim4:/bin/false
595b88
+foo:x:1000:1000::/home/foo:/bin/false
595b88
diff -up shadow-4.6/tests/libsubid/02_get_subid_owners/config/etc/subgid.libsubid_creation shadow-4.6/tests/libsubid/02_get_subid_owners/config/etc/subgid
595b88
--- shadow-4.6/tests/libsubid/02_get_subid_owners/config/etc/subgid.libsubid_creation	2021-10-19 16:12:02.662748257 +0200
595b88
+++ shadow-4.6/tests/libsubid/02_get_subid_owners/config/etc/subgid	2021-10-19 16:12:02.662748257 +0200
595b88
@@ -0,0 +1,2 @@
595b88
+foo:200000:10000
595b88
+root:500000:1000
595b88
diff -up shadow-4.6/tests/libsubid/02_get_subid_owners/config/etc/subuid.libsubid_creation shadow-4.6/tests/libsubid/02_get_subid_owners/config/etc/subuid
595b88
--- shadow-4.6/tests/libsubid/02_get_subid_owners/config/etc/subuid.libsubid_creation	2021-10-19 16:12:02.662748257 +0200
595b88
+++ shadow-4.6/tests/libsubid/02_get_subid_owners/config/etc/subuid	2021-10-19 16:12:02.662748257 +0200
595b88
@@ -0,0 +1,4 @@
595b88
+foo:300000:10000
595b88
+foo:400000:10000
595b88
+foo:500000:10000
595b88
+root:500000:1000
595b88
diff -up shadow-4.6/tests/libsubid/02_get_subid_owners/config.txt.libsubid_creation shadow-4.6/tests/libsubid/02_get_subid_owners/config.txt
595b88
diff -up shadow-4.6/tests/libsubid/02_get_subid_owners/get_subid_owners.test.libsubid_creation shadow-4.6/tests/libsubid/02_get_subid_owners/get_subid_owners.test
595b88
--- shadow-4.6/tests/libsubid/02_get_subid_owners/get_subid_owners.test.libsubid_creation	2021-10-19 16:12:02.662748257 +0200
595b88
+++ shadow-4.6/tests/libsubid/02_get_subid_owners/get_subid_owners.test	2021-10-19 16:12:02.662748257 +0200
595b88
@@ -0,0 +1,52 @@
595b88
+#!/bin/sh
595b88
+
595b88
+set -e
595b88
+
595b88
+cd $(dirname $0)
595b88
+
595b88
+. ../../common/config.sh
595b88
+. ../../common/log.sh
595b88
+
595b88
+log_start "$0" "get subid owners"
595b88
+
595b88
+save_config
595b88
+
595b88
+# restore the files on exit
595b88
+trap 'log_status "$0" "FAILURE"; restore_config' 0
595b88
+
595b88
+change_config
595b88
+
595b88
+echo -n "Noone owns 0 as a subid..."
595b88
+[ -z "$(${build_path}/src/get_subid_owners 0)" ]
595b88
+echo "OK"
595b88
+
595b88
+echo -n "foo owns subuid 300000..."
595b88
+[ "$(${build_path}/src/get_subid_owners 300000)" = "1000" ]
595b88
+echo "OK"
595b88
+
595b88
+echo -n "foo owns subgid 200000..."
595b88
+[ "$(${build_path}/src/get_subid_owners -g 200000)" = "1000" ]
595b88
+echo "OK"
595b88
+
595b88
+echo -n "Noone owns subuid 200000..."
595b88
+[ -z "$(${build_path}/src/get_subid_owners -g 300000)" ]
595b88
+echo "OK"
595b88
+
595b88
+echo -n "Noone owns subgid 300000..."
595b88
+[ -z "$(${build_path}/src/get_subid_owners -g 300000)" ]
595b88
+echo "OK"
595b88
+
595b88
+echo -n "Both foo and root own subuid 500000..."
595b88
+cat > /tmp/expected << EOF
595b88
+1000
595b88
+0
595b88
+EOF
595b88
+${build_path}/src/get_subid_owners 500000 > /tmp/actual
595b88
+diff /tmp/expected /tmp/actual
595b88
+
595b88
+echo "OK"
595b88
+
595b88
+log_status "$0" "SUCCESS"
595b88
+restore_config
595b88
+trap '' 0
595b88
+
595b88
diff -up shadow-4.6/tests/libsubid/03_add_remove/add_remove_subids.test.libsubid_creation shadow-4.6/tests/libsubid/03_add_remove/add_remove_subids.test
595b88
--- shadow-4.6/tests/libsubid/03_add_remove/add_remove_subids.test.libsubid_creation	2021-10-19 16:12:02.662748257 +0200
595b88
+++ shadow-4.6/tests/libsubid/03_add_remove/add_remove_subids.test	2021-10-19 16:12:02.662748257 +0200
595b88
@@ -0,0 +1,59 @@
595b88
+#!/bin/sh
595b88
+
595b88
+set -e
595b88
+
595b88
+cd $(dirname $0)
595b88
+
595b88
+. ../../common/config.sh
595b88
+. ../../common/log.sh
595b88
+
595b88
+log_start "$0" "add and remove subid ranges"
595b88
+
595b88
+save_config
595b88
+
595b88
+# restore the files on exit
595b88
+trap 'log_status "$0" "FAILURE"; restore_config' 0
595b88
+
595b88
+change_config
595b88
+
595b88
+echo -n "Existing ranges returned when possible..."
595b88
+res=$(${build_path}/src/new_subid_range foo 500)
595b88
+echo "debug"
595b88
+echo "res is $res"
595b88
+echo "wanted Subuid range 300000:10000"
595b88
+echo "end debug"
595b88
+[ "$res" = "Subuid range 300000:10000" ]
595b88
+[ $(grep -c foo /etc/subuid) -eq 1 ]
595b88
+echo "OK"
595b88
+
595b88
+echo -n "New range returned if requested..."
595b88
+res=$(${build_path}/src/new_subid_range foo 500 -n)
595b88
+[ "$res" = "Subuid range 310000:500" ]
595b88
+[ $(grep -c foo /etc/subuid) -eq 2 ]
595b88
+echo "OK"
595b88
+
595b88
+echo -n "Free works..."
595b88
+res=$(${build_path}/src/free_subid_range foo 310000 500)
595b88
+[ $(grep -c foo /etc/subuid) -eq 1 ]
595b88
+echo "OK"
595b88
+
595b88
+echo -n "Subgids work too..."
595b88
+res=$(${build_path}/src/new_subid_range -g foo 100000)
595b88
+echo "DEBUG: res is ${res}"
595b88
+[ "$res" = "Subuid range 501000:100000" ]
595b88
+echo "DEBUG: subgid is:"
595b88
+cat /etc/subgid
595b88
+[ $(grep -c foo /etc/subgid) -eq 2 ]
595b88
+
595b88
+echo -n "Subgid free works..."
595b88
+res=$(${build_path}/src/free_subid_range -g foo 501000 100000)
595b88
+echo "DEBUG: res is ${res}"
595b88
+echo "DEBUG: subgid is:"
595b88
+cat /etc/subgid
595b88
+[ $(grep -c foo /etc/subgid) -eq 1 ]
595b88
+echo "OK"
595b88
+
595b88
+log_status "$0" "SUCCESS"
595b88
+restore_config
595b88
+trap '' 0
595b88
+
595b88
diff -up shadow-4.6/tests/libsubid/03_add_remove/config/etc/passwd.libsubid_creation shadow-4.6/tests/libsubid/03_add_remove/config/etc/passwd
595b88
--- shadow-4.6/tests/libsubid/03_add_remove/config/etc/passwd.libsubid_creation	2021-10-19 16:12:02.662748257 +0200
595b88
+++ shadow-4.6/tests/libsubid/03_add_remove/config/etc/passwd	2021-10-19 16:12:02.662748257 +0200
595b88
@@ -0,0 +1,20 @@
595b88
+root:x:0:0:root:/root:/bin/bash
595b88
+daemon:x:1:1:daemon:/usr/sbin:/bin/sh
595b88
+bin:x:2:2:bin:/bin:/bin/sh
595b88
+sys:x:3:3:sys:/dev:/bin/sh
595b88
+sync:x:4:65534:sync:/bin:/bin/sync
595b88
+games:x:5:60:games:/usr/games:/bin/sh
595b88
+man:x:6:12:man:/var/cache/man:/bin/sh
595b88
+lp:x:7:7:lp:/var/spool/lpd:/bin/sh
595b88
+mail:x:8:8:mail:/var/mail:/bin/sh
595b88
+news:x:9:9:news:/var/spool/news:/bin/sh
595b88
+uucp:x:10:10:uucp:/var/spool/uucp:/bin/sh
595b88
+proxy:x:13:13:proxy:/bin:/bin/sh
595b88
+www-data:x:33:33:www-data:/var/www:/bin/sh
595b88
+backup:x:34:34:backup:/var/backups:/bin/sh
595b88
+list:x:38:38:Mailing List Manager:/var/list:/bin/sh
595b88
+irc:x:39:39:ircd:/var/run/ircd:/bin/sh
595b88
+gnats:x:41:41:Gnats Bug-Reporting System (admin):/var/lib/gnats:/bin/sh
595b88
+nobody:x:65534:65534:nobody:/nonexistent:/bin/sh
595b88
+Debian-exim:x:102:102::/var/spool/exim4:/bin/false
595b88
+foo:x:1000:1000::/home/foo:/bin/false
595b88
diff -up shadow-4.6/tests/libsubid/03_add_remove/config/etc/subgid.libsubid_creation shadow-4.6/tests/libsubid/03_add_remove/config/etc/subgid
595b88
--- shadow-4.6/tests/libsubid/03_add_remove/config/etc/subgid.libsubid_creation	2021-10-19 16:12:02.662748257 +0200
595b88
+++ shadow-4.6/tests/libsubid/03_add_remove/config/etc/subgid	2021-10-19 16:12:02.662748257 +0200
595b88
@@ -0,0 +1,2 @@
595b88
+foo:200000:10000
595b88
+root:500000:1000
595b88
diff -up shadow-4.6/tests/libsubid/03_add_remove/config/etc/subuid.libsubid_creation shadow-4.6/tests/libsubid/03_add_remove/config/etc/subuid
595b88
--- shadow-4.6/tests/libsubid/03_add_remove/config/etc/subuid.libsubid_creation	2021-10-19 16:12:02.662748257 +0200
595b88
+++ shadow-4.6/tests/libsubid/03_add_remove/config/etc/subuid	2021-10-19 16:12:02.662748257 +0200
595b88
@@ -0,0 +1 @@
595b88
+foo:300000:10000
595b88
diff -up shadow-4.6/tests/libsubid/03_add_remove/config.txt.libsubid_creation shadow-4.6/tests/libsubid/03_add_remove/config.txt
595b88
diff -up shadow-4.6/tests/run_some.libsubid_creation shadow-4.6/tests/run_some
595b88
--- shadow-4.6/tests/run_some.libsubid_creation	2021-10-19 16:12:02.662748257 +0200
595b88
+++ shadow-4.6/tests/run_some	2021-10-19 16:12:02.662748257 +0200
595b88
@@ -0,0 +1,136 @@
595b88
+#!/bin/sh
595b88
+
595b88
+set -e
595b88
+
595b88
+export LC_ALL=C
595b88
+unset LANG
595b88
+unset LANGUAGE
595b88
+. common/config.sh
595b88
+
595b88
+USE_PAM="yes"
595b88
+FAILURE_TESTS="yes"
595b88
+
595b88
+succeeded=0
595b88
+failed=0
595b88
+failed_tests=""
595b88
+
595b88
+run_test()
595b88
+{
595b88
+	[ -f RUN_TEST.STOP ] && exit 1
595b88
+
595b88
+	if $1 > $1.log
595b88
+	then
595b88
+		succeeded=$((succeeded+1))
595b88
+		echo -n "+"
595b88
+	else
595b88
+		failed=$((failed+1))
595b88
+		failed_tests="$failed_tests $1"
595b88
+		echo -n "-"
595b88
+	fi
595b88
+	cat $1.log >> testsuite.log
595b88
+	[ -f /etc/passwd.lock ] && echo $1 /etc/passwd.lock || true
595b88
+	[ -f /etc/group.lock ] && echo $1 /etc/group.lock || true
595b88
+	[ -f /etc/shadow.lock ] && echo $1 /etc/shadow.lock || true
595b88
+	[ -f /etc/gshadow.lock ] && echo $1 /etc/gshadow.lock || true
595b88
+	if [ "$(stat -c"%G" /etc/shadow)" != "shadow" ]
595b88
+	then
595b88
+		echo $1
595b88
+		ls -l /etc/shadow
595b88
+		chgrp shadow /etc/shadow
595b88
+	fi
595b88
+	if [ -d /nonexistent ]
595b88
+	then
595b88
+		echo $1 /nonexistent
595b88
+		rmdir /nonexistent
595b88
+	fi
595b88
+}
595b88
+
595b88
+echo "+: test passed"
595b88
+echo "-: test failed"
595b88
+
595b88
+# Empty the complete log.
595b88
+> testsuite.log
595b88
+
595b88
+find ${build_path} -name "*.gcda" -delete
595b88
+run_test ./su/01/su_root.test
595b88
+run_test ./su/01/su_user.test
595b88
+find ${build_path} -name "*.gcda" -exec chmod a+rw {} \;
595b88
+run_test ./su/02/env_FOO-options_--login
595b88
+run_test ./su/02/env_FOO-options_--login_bash
595b88
+run_test ./su/02/env_FOO-options_--preserve-environment
595b88
+run_test ./su/02/env_FOO-options_--preserve-environment_bash
595b88
+run_test ./su/02/env_FOO-options_-
595b88
+run_test ./su/02/env_FOO-options_-_bash
595b88
+run_test ./su/02/env_FOO-options_-l-m
595b88
+run_test ./su/02/env_FOO-options_-l-m_bash
595b88
+run_test ./su/02/env_FOO-options_-l
595b88
+run_test ./su/02/env_FOO-options_-l_bash
595b88
+run_test ./su/02/env_FOO-options_-m_bash
595b88
+run_test ./su/02/env_FOO-options_-m
595b88
+run_test ./su/02/env_FOO-options_-p
595b88
+run_test ./su/02/env_FOO-options_-p_bash
595b88
+run_test ./su/02/env_FOO-options__bash
595b88
+run_test ./su/02/env_FOO-options_
595b88
+run_test ./su/02/env_FOO-options_-p-
595b88
+run_test ./su/02/env_FOO-options_-p-_bash
595b88
+run_test ./su/02/env_special-options_-l-p
595b88
+run_test ./su/02/env_special-options_-l
595b88
+run_test ./su/02/env_special-options_-l-p_bash
595b88
+run_test ./su/02/env_special-options_-l_bash
595b88
+run_test ./su/02/env_special-options_-p
595b88
+run_test ./su/02/env_special-options_-p_bash
595b88
+run_test ./su/02/env_special-options_
595b88
+run_test ./su/02/env_special-options__bash
595b88
+run_test ./su/02/env_special_root-options_-l-p
595b88
+run_test ./su/02/env_special_root-options_-l-p_bash
595b88
+run_test ./su/02/env_special_root-options_-l
595b88
+run_test ./su/02/env_special_root-options_-l_bash
595b88
+run_test ./su/02/env_special_root-options_-p
595b88
+run_test ./su/02/env_special_root-options_-p_bash
595b88
+run_test ./su/02/env_special_root-options_
595b88
+run_test ./su/02/env_special_root-options__bash
595b88
+run_test ./su/03/su_run_command01.test
595b88
+run_test ./su/03/su_run_command02.test
595b88
+run_test ./su/03/su_run_command03.test
595b88
+run_test ./su/03/su_run_command04.test
595b88
+run_test ./su/03/su_run_command05.test
595b88
+run_test ./su/03/su_run_command06.test
595b88
+run_test ./su/03/su_run_command07.test
595b88
+run_test ./su/03/su_run_command08.test
595b88
+run_test ./su/03/su_run_command09.test
595b88
+run_test ./su/03/su_run_command10.test
595b88
+run_test ./su/03/su_run_command11.test
595b88
+run_test ./su/03/su_run_command12.test
595b88
+run_test ./su/03/su_run_command13.test
595b88
+run_test ./su/03/su_run_command14.test
595b88
+run_test ./su/03/su_run_command15.test
595b88
+run_test ./su/03/su_run_command16.test
595b88
+run_test ./su/03/su_run_command17.test
595b88
+run_test ./su/04/su_wrong_user.test
595b88
+run_test ./su/04/su_user_wrong_passwd.test
595b88
+run_test ./su/04/su_user_wrong_passwd_syslog.test
595b88
+run_test ./su/05/su_user_wrong_passwd_syslog.test
595b88
+run_test ./su/06/su_user_syslog.test
595b88
+run_test ./su/07/su_user_syslog.test
595b88
+run_test ./su/08/env_special-options_
595b88
+run_test ./su/08/env_special_root-options_
595b88
+run_test ./su/09/env_special-options_
595b88
+run_test ./su/09/env_special_root-options_
595b88
+run_test ./su/10_su_sulog_success/su.test
595b88
+run_test ./su/11_su_sulog_failure/su.test
595b88
+run_test ./su/12_su_child_failure/su.test
595b88
+run_test ./su/13_su_child_success/su.test
595b88
+run_test ./libsubid/01_list_ranges/list_ranges.test
595b88
+run_test ./libsubid/02_get_subid_owners/get_subid_owners.test
595b88
+run_test ./libsubid/03_add_remove/add_remove_subids.test
595b88
+
595b88
+echo
595b88
+echo "$succeeded test(s) passed"
595b88
+echo "$failed test(s) failed"
595b88
+echo "log written in 'testsuite.log'"
595b88
+if [ "$failed" != "0" ]
595b88
+then
595b88
+	echo "the following tests failed:"
595b88
+	echo $failed_tests
595b88
+fi
595b88
+
595b88
diff -up shadow-4.6/src/Makefile.am.libsubid_creation shadow-4.6/src/Makefile.am
595b88
--- shadow-4.6/src/Makefile.am.bp	2021-10-19 13:13:14.132503541 +0200
595b88
+++ shadow-4.6/src/Makefile.am	2021-10-19 13:14:40.055871030 +0200
595b88
@@ -138,3 +138,64 @@
595b88
 		chmod $(sgidperms) $(DESTDIR)$(ubindir)/$$i; \
595b88
 	done
595b88
 endif
595b88
+
595b88
+if ENABLE_SUBIDS
595b88
+noinst_PROGRAMS += list_subid_ranges  \
595b88
+					get_subid_owners \
595b88
+					new_subid_range \
595b88
+					free_subid_range
595b88
+
595b88
+MISCLIBS = \
595b88
+	$(LIBAUDIT) \
595b88
+	$(LIBSELINUX) \
595b88
+	$(LIBSEMANAGE) \
595b88
+	$(LIBCRYPT_NOPAM) \
595b88
+	$(LIBSKEY) \
595b88
+	$(LIBMD) \
595b88
+	$(LIBCRYPT) \
595b88
+	$(LIBTCB)
595b88
+
595b88
+list_subid_ranges_LDADD = \
595b88
+	$(top_builddir)/lib/libshadow.la \
595b88
+	$(top_builddir)/libmisc/libmisc.a \
595b88
+	$(top_builddir)/libsubid/libsubid.la \
595b88
+	$(MISCLIBS)
595b88
+
595b88
+list_subid_ranges_CPPFLAGS = \
595b88
+	-I$(top_srcdir)/lib \
595b88
+	-I$(top_srcdir)/libmisc \
595b88
+	-I$(top_srcdir)/libsubid
595b88
+
595b88
+get_subid_owners_LDADD = \
595b88
+	$(top_builddir)/lib/libshadow.la \
595b88
+	$(top_builddir)/libmisc/libmisc.a \
595b88
+	$(top_builddir)/libsubid/libsubid.la \
595b88
+	$(MISCLIBS)
595b88
+
595b88
+get_subid_owners_CPPFLAGS = \
595b88
+	-I$(top_srcdir)/lib \
595b88
+	-I$(top_srcdir)/libmisc \
595b88
+	-I$(top_srcdir)/libsubid
595b88
+
595b88
+new_subid_range_CPPFLAGS = \
595b88
+	-I$(top_srcdir)/lib \
595b88
+	-I$(top_srcdir)/libmisc \
595b88
+	-I$(top_srcdir)/libsubid
595b88
+
595b88
+new_subid_range_LDADD = \
595b88
+	$(top_builddir)/lib/libshadow.la \
595b88
+	$(top_builddir)/libmisc/libmisc.a \
595b88
+	$(top_builddir)/libsubid/libsubid.la \
595b88
+	$(MISCLIBS)
595b88
+
595b88
+free_subid_range_CPPFLAGS = \
595b88
+	-I$(top_srcdir)/lib \
595b88
+	-I$(top_srcdir)/libmisc \
595b88
+	-I$(top_srcdir)/libsubid
595b88
+
595b88
+free_subid_range_LDADD = \
595b88
+	$(top_builddir)/lib/libshadow.la \
595b88
+	$(top_builddir)/libmisc/libmisc.a \
595b88
+	$(top_builddir)/libsubid/libsubid.la \
595b88
+	$(MISCLIBS)
595b88
+endif