Blame SOURCES/shadow-4.1.5.1-goodname.patch

9f90df
diff -up shadow-4.1.5.1/libmisc/chkname.c.goodname shadow-4.1.5.1/libmisc/chkname.c
9f90df
--- shadow-4.1.5.1/libmisc/chkname.c.goodname	2009-07-13 00:24:45.000000000 +0200
9f90df
+++ shadow-4.1.5.1/libmisc/chkname.c	2012-09-19 18:43:53.492160653 +0200
9f90df
@@ -49,20 +49,28 @@
9f90df
 static bool is_valid_name (const char *name)
9f90df
 {
9f90df
 	/*
9f90df
-	 * User/group names must match [a-z_][a-z0-9_-]*[$]
9f90df
-	 */
9f90df
-	if (('\0' == *name) ||
9f90df
-	    !((('a' <= *name) && ('z' >= *name)) || ('_' == *name))) {
9f90df
+         * User/group names must match gnu e-regex:
9f90df
+         *    [a-zA-Z0-9_.][a-zA-Z0-9_.-]{0,30}[a-zA-Z0-9_.$-]?
9f90df
+         *
9f90df
+         * as a non-POSIX, extension, allow "$" as the last char for
9f90df
+         * sake of Samba 3.x "add machine script"
9f90df
+         */
9f90df
+	if ( ('\0' == *name) ||
9f90df
+             !((*name >= 'a' && *name <= 'z') ||
9f90df
+               (*name >= 'A' && *name <= 'Z') ||
9f90df
+               (*name >= '0' && *name <= '9') ||
9f90df
+               (*name == '_') || (*name == '.') 
9f90df
+	      )) {
9f90df
 		return false;
9f90df
 	}
9f90df
 
9f90df
 	while ('\0' != *++name) {
9f90df
-		if (!(( ('a' <= *name) && ('z' >= *name) ) ||
9f90df
-		      ( ('0' <= *name) && ('9' >= *name) ) ||
9f90df
-		      ('_' == *name) ||
9f90df
-		      ('-' == *name) ||
9f90df
-		      ( ('$' == *name) && ('\0' == *(name + 1)) )
9f90df
-		     )) {
9f90df
+                if (!(  (*name >= 'a' && *name <= 'z') ||
9f90df
+                        (*name >= 'A' && *name <= 'Z') ||
9f90df
+                        (*name >= '0' && *name <= '9') ||
9f90df
+                        (*name == '_') || (*name == '.') || (*name == '-') ||
9f90df
+                        (*name == '$' && *(name + 1) == '\0') 
9f90df
+                     )) {
9f90df
 			return false;
9f90df
 		}
9f90df
 	}
9f90df
diff -up shadow-4.1.5.1/man/groupadd.8.xml.goodname shadow-4.1.5.1/man/groupadd.8.xml
9f90df
--- shadow-4.1.5.1/man/groupadd.8.xml.goodname	2012-05-25 13:45:27.000000000 +0200
9f90df
+++ shadow-4.1.5.1/man/groupadd.8.xml	2012-09-19 18:43:53.492160653 +0200
9f90df
@@ -259,12 +259,6 @@
9f90df
    <refsect1 id='caveats'>
9f90df
      <title>CAVEATS</title>
9f90df
      <para>
9f90df
-       Groupnames must start with a lower case letter or an underscore,
9f90df
-       followed by lower case letters, digits, underscores, or dashes.
9f90df
-       They can end with a dollar sign.
9f90df
-       In regular expression terms: [a-z_][a-z0-9_-]*[$]?
9f90df
-     </para>
9f90df
-     <para>
9f90df
        Groupnames may only be up to &GROUP_NAME_MAX_LENGTH; characters long.
9f90df
      </para>
9f90df
      <para>
9f90df
diff -up shadow-4.1.5.1/man/useradd.8.xml.goodname shadow-4.1.5.1/man/useradd.8.xml
9f90df
--- shadow-4.1.5.1/man/useradd.8.xml.goodname	2012-05-25 13:45:29.000000000 +0200
9f90df
+++ shadow-4.1.5.1/man/useradd.8.xml	2012-09-19 18:43:53.493160675 +0200
9f90df
@@ -366,7 +366,7 @@
9f90df
 	</term>
9f90df
 	<listitem>
9f90df
 	  <para>
9f90df
-	    Do no create the user's home directory, even if the system
9f90df
+	    Do not create the user's home directory, even if the system
9f90df
 	    wide setting from <filename>/etc/login.defs</filename>
9f90df
 	    (<option>CREATE_HOME</option>) is set to
9f90df
 	    <replaceable>yes</replaceable>.
9f90df
@@ -654,12 +654,6 @@
9f90df
     </para>
9f90df
 
9f90df
     <para>
9f90df
-      Usernames must start with a lower case letter or an underscore,
9f90df
-      followed by lower case letters, digits, underscores, or dashes.
9f90df
-      They can end with a dollar sign.
9f90df
-      In regular expression terms: [a-z_][a-z0-9_-]*[$]?
9f90df
-    </para>
9f90df
-    <para>
9f90df
       Usernames may only be up to 32 characters long.
9f90df
     </para>
9f90df
   </refsect1>