|
 |
dbaca1 |
From e13297f45b4c5868800b1d3fc359bfd0723fcc5f Mon Sep 17 00:00:00 2001
|
|
|
dbaca1 |
From: Klaus Wenninger <klaus.wenninger@aon.at>
|
|
|
dbaca1 |
Date: Mon, 17 Sep 2018 23:13:37 +0200
|
|
|
dbaca1 |
Subject: [PATCH] Refactor: sbd-common: separate assignment and comparison
|
|
|
dbaca1 |
|
|
|
dbaca1 |
---
|
|
|
dbaca1 |
src/sbd-common.c | 7 ++++---
|
|
|
dbaca1 |
1 file changed, 4 insertions(+), 3 deletions(-)
|
|
|
dbaca1 |
|
|
|
dbaca1 |
diff --git a/src/sbd-common.c b/src/sbd-common.c
|
|
|
dbaca1 |
index fcb7a31..679f946 100644
|
|
|
dbaca1 |
--- a/src/sbd-common.c
|
|
|
dbaca1 |
+++ b/src/sbd-common.c
|
|
|
dbaca1 |
@@ -376,12 +376,13 @@ watchdog_populate_list(void)
|
|
|
dbaca1 |
snprintf(entry_name, sizeof(entry_name),
|
|
|
dbaca1 |
SYS_CHAR_DEV_DIR "/%d:%d/device/driver",
|
|
|
dbaca1 |
major(watchdogs[i]), minor(watchdogs[i]));
|
|
|
dbaca1 |
- if ((len = readlink(entry_name, buf, sizeof(buf) - 1)) > 0) {
|
|
|
dbaca1 |
+ len = readlink(entry_name, buf, sizeof(buf) - 1);
|
|
|
dbaca1 |
+ if (len > 0) {
|
|
|
dbaca1 |
buf[len] = '\0';
|
|
|
dbaca1 |
wdg->dev_driver = strdup(basename(buf));
|
|
|
dbaca1 |
} else if ((wdg->dev_ident) &&
|
|
|
dbaca1 |
- (strcmp(wdg->dev_ident,
|
|
|
dbaca1 |
- "Software Watchdog") == 0)) {
|
|
|
dbaca1 |
+ (strcmp(wdg->dev_ident,
|
|
|
dbaca1 |
+ "Software Watchdog") == 0)) {
|
|
|
dbaca1 |
wdg->dev_driver = strdup("softdog");
|
|
|
dbaca1 |
}
|
|
|
dbaca1 |
break;
|
|
|
dbaca1 |
--
|
|
|
dbaca1 |
1.8.3.1
|
|
|
dbaca1 |
|