|
 |
1cae83 |
From 2edaf32b4204b9fe363c441c25b6989fe76911a4 Mon Sep 17 00:00:00 2001
|
|
|
1cae83 |
From: Stefan Metzmacher <metze@samba.org>
|
|
|
1cae83 |
Date: Tue, 9 Nov 2021 20:50:20 +0100
|
|
|
1cae83 |
Subject: [PATCH] s3:winbindd: fix "allow trusted domains = no" regression
|
|
|
1cae83 |
|
|
|
1cae83 |
add_trusted_domain() should only reject domains
|
|
|
1cae83 |
based on is_allowed_domain(), which now also
|
|
|
1cae83 |
checks "allow trusted domains = no", if we don't
|
|
|
1cae83 |
have an explicit trust to the domain (SEC_CHAN_NULL).
|
|
|
1cae83 |
|
|
|
1cae83 |
We use at least SEC_CHAN_LOCAL for local domains like
|
|
|
1cae83 |
BUILTIN.
|
|
|
1cae83 |
|
|
|
1cae83 |
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14899
|
|
|
1cae83 |
|
|
|
1cae83 |
Signed-off-by: Stefan Metzmacher <metze@samba.org>
|
|
|
1cae83 |
|
|
|
1cae83 |
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
|
|
|
1cae83 |
Autobuild-Date(master): Wed Nov 10 11:21:31 UTC 2021 on sn-devel-184
|
|
|
1cae83 |
|
|
|
1cae83 |
(cherry picked from commit a7f6c60cb037b4bc9eee276236539b8282213935)
|
|
|
1cae83 |
---
|
|
|
1cae83 |
source3/winbindd/winbindd_util.c | 2 +-
|
|
|
1cae83 |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
1cae83 |
|
|
|
1cae83 |
diff --git a/source3/winbindd/winbindd_util.c b/source3/winbindd/winbindd_util.c
|
|
|
1cae83 |
index 42ddbfd2f44..9d54e462c42 100644
|
|
|
1cae83 |
--- a/source3/winbindd/winbindd_util.c
|
|
|
1cae83 |
+++ b/source3/winbindd/winbindd_util.c
|
|
|
1cae83 |
@@ -134,7 +134,7 @@ static NTSTATUS add_trusted_domain(const char *domain_name,
|
|
|
1cae83 |
return NT_STATUS_INVALID_PARAMETER;
|
|
|
1cae83 |
}
|
|
|
1cae83 |
|
|
|
1cae83 |
- if (!is_allowed_domain(domain_name)) {
|
|
|
1cae83 |
+ if (secure_channel_type == SEC_CHAN_NULL && !is_allowed_domain(domain_name)) {
|
|
|
1cae83 |
return NT_STATUS_NO_SUCH_DOMAIN;
|
|
|
1cae83 |
}
|
|
|
1cae83 |
|
|
|
1cae83 |
--
|
|
|
1cae83 |
2.33.1
|
|
|
1cae83 |
|