1524bc
From c8b68454839618abf0e0c467ceaa08ef88717b22 Mon Sep 17 00:00:00 2001
1524bc
From: Andreas Schneider <asn@samba.org>
1524bc
Date: Wed, 11 Dec 2019 17:45:39 +0100
1524bc
Subject: [PATCH 195/208] gensec: Add a check if a gensec module implements
1524bc
 weak crypto
1524bc
1524bc
Signed-off-by: Andreas Schneider <asn@samba.org>
1524bc
---
1524bc
 auth/gensec/gensec_internal.h |  1 +
1524bc
 auth/gensec/gensec_start.c    | 12 +++++++++++-
1524bc
 2 files changed, 12 insertions(+), 1 deletion(-)
1524bc
1524bc
diff --git a/auth/gensec/gensec_internal.h b/auth/gensec/gensec_internal.h
1524bc
index 911b48b52d6..8efb1bdff0f 100644
1524bc
--- a/auth/gensec/gensec_internal.h
1524bc
+++ b/auth/gensec/gensec_internal.h
1524bc
@@ -28,6 +28,7 @@ struct gensec_security;
1524bc
 struct gensec_security_ops {
1524bc
 	const char *name;
1524bc
 	const char *sasl_name;
1524bc
+	bool weak_crypto;
1524bc
 	uint8_t auth_type;  /* 0 if not offered on DCE-RPC */
1524bc
 	const char **oid;  /* NULL if not offered by SPNEGO */
1524bc
 	NTSTATUS (*client_start)(struct gensec_security *gensec_security);
1524bc
diff --git a/auth/gensec/gensec_start.c b/auth/gensec/gensec_start.c
1524bc
index 50f4de73110..860c974f056 100644
1524bc
--- a/auth/gensec/gensec_start.c
1524bc
+++ b/auth/gensec/gensec_start.c
1524bc
@@ -49,7 +49,17 @@ _PUBLIC_ const struct gensec_security_ops * const *gensec_security_all(void)
1524bc
 
1524bc
 bool gensec_security_ops_enabled(const struct gensec_security_ops *ops, struct gensec_security *security)
1524bc
 {
1524bc
-	return lpcfg_parm_bool(security->settings->lp_ctx, NULL, "gensec", ops->name, ops->enabled);
1524bc
+	bool ok = lpcfg_parm_bool(security->settings->lp_ctx,
1524bc
+				  NULL,
1524bc
+				  "gensec",
1524bc
+				  ops->name,
1524bc
+				  ops->enabled);
1524bc
+
1524bc
+	if (!samba_gnutls_weak_crypto_allowed() && ops->weak_crypto) {
1524bc
+		ok = false;
1524bc
+	}
1524bc
+
1524bc
+	return ok;
1524bc
 }
1524bc
 
1524bc
 /* Sometimes we want to force only kerberos, sometimes we want to
1524bc
-- 
1524bc
2.23.0
1524bc