From c08b8c1b2ccbd3c180c730940d7efce8fcef8b5b Mon Sep 17 00:00:00 2001

From: Andreas Schneider <asn@samba.org>

Date: Mon, 12 Aug 2019 18:49:37 +0200

Subject: [PATCH 077/187] Revert "s4:rpc_server: Use generate_secret_buffer()

 for netlogon challange"

This reverts commit a21770cfdffd2a21045a1bc87e489af0f4c6f130.

Reviewed-by: Alexander Bokovoy <ab@samba.org>

(cherry picked from commit 1c68085404cd467c217640e3eabfc4b7f8b1ce9f)

---

 source4/rpc_server/netlogon/dcerpc_netlogon.c | 3 +--

 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/source4/rpc_server/netlogon/dcerpc_netlogon.c b/source4/rpc_server/netlogon/dcerpc_netlogon.c

index f4e24b7fd7f..ac745e32b02 100644

--- a/source4/rpc_server/netlogon/dcerpc_netlogon.c

+++ b/source4/rpc_server/netlogon/dcerpc_netlogon.c

@@ -90,8 +90,7 @@ static NTSTATUS dcesrv_netr_ServerReqChallenge(struct dcesrv_call_state *dce_cal

 	pipe_state->client_challenge = *r->in.credentials;

-	/* We need to use a CSPRNG which reseeds for generating session keys. */

-	generate_secret_buffer(pipe_state->server_challenge.data,

+	generate_random_buffer(pipe_state->server_challenge.data,

 			       sizeof(pipe_state->server_challenge.data));

 	*r->out.return_credentials = pipe_state->server_challenge;

-- 

2.23.0