|
 |
b6b438 |
From 299dd35d7816770560a17a0e30886c08d9687589 Mon Sep 17 00:00:00 2001
|
|
|
b6b438 |
From: Andreas Schneider <asn@samba.org>
|
|
|
b6b438 |
Date: Wed, 31 Jul 2019 15:40:12 +0200
|
|
|
b6b438 |
Subject: [PATCH 071/187] s4:rpc_server: Use generate_secret_buffer() to create
|
|
|
b6b438 |
a session key
|
|
|
b6b438 |
|
|
|
b6b438 |
Signed-off-by: Andreas Schneider <asn@samba.org>
|
|
|
b6b438 |
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
|
|
|
b6b438 |
(cherry picked from commit 4b2480518bd3887be3a6cfb713523ac084e09fd5)
|
|
|
b6b438 |
---
|
|
|
b6b438 |
source4/rpc_server/samr/samr_password.c | 5 +++--
|
|
|
b6b438 |
1 file changed, 3 insertions(+), 2 deletions(-)
|
|
|
b6b438 |
|
|
|
b6b438 |
diff --git a/source4/rpc_server/samr/samr_password.c b/source4/rpc_server/samr/samr_password.c
|
|
|
b6b438 |
index b04e37f06f3..6bf907181c8 100644
|
|
|
b6b438 |
--- a/source4/rpc_server/samr/samr_password.c
|
|
|
b6b438 |
+++ b/source4/rpc_server/samr/samr_password.c
|
|
|
b6b438 |
@@ -733,9 +733,10 @@ NTSTATUS samr_set_password_buffers(struct dcesrv_call_state *dce_call,
|
|
|
b6b438 |
nt_errstr(nt_status)));
|
|
|
b6b438 |
|
|
|
b6b438 |
/*
|
|
|
b6b438 |
- * Windows just uses a random key
|
|
|
b6b438 |
+ * Windows just uses a random key. We need to use a CSPRNG
|
|
|
b6b438 |
+ * which reseeds for generating session keys.
|
|
|
b6b438 |
*/
|
|
|
b6b438 |
- generate_random_buffer(random_session_key,
|
|
|
b6b438 |
+ generate_secret_buffer(random_session_key,
|
|
|
b6b438 |
sizeof(random_session_key));
|
|
|
b6b438 |
session_key = data_blob_const(random_session_key,
|
|
|
b6b438 |
sizeof(random_session_key));
|
|
|
b6b438 |
--
|
|
|
b6b438 |
2.23.0
|
|
|
b6b438 |
|