b6b438
From b26c0a881c5a71ee310a942ffd65960974eabea8 Mon Sep 17 00:00:00 2001
b6b438
From: David Disseldorp <ddiss@samba.org>
b6b438
Date: Fri, 12 Jul 2019 17:29:23 +0200
b6b438
Subject: [PATCH 063/187] netlogon: Fix potential use of uninitialized variable
b6b438
b6b438
The _netr_NetrEnumerateTrustedDomains()->dcerpc_lsa_open_policy2() error
b6b438
path checks the policy handle and closes it if non-empty. The policy
b6b438
handle may be uninitialized in this code-path - fix this.
b6b438
b6b438
Signed-off-by: David Disseldorp <ddiss@samba.org>
b6b438
Reviewed-by: Andreas Schneider <asn@samba.org>
b6b438
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
b6b438
(cherry picked from commit 93d424528f1c3d0d50ebd8a784f4624b2721d416)
b6b438
---
b6b438
 source3/rpc_server/netlogon/srv_netlog_nt.c | 1 +
b6b438
 1 file changed, 1 insertion(+)
b6b438
b6b438
diff --git a/source3/rpc_server/netlogon/srv_netlog_nt.c b/source3/rpc_server/netlogon/srv_netlog_nt.c
b6b438
index 791aa7acaff..08bce367bf0 100644
b6b438
--- a/source3/rpc_server/netlogon/srv_netlog_nt.c
b6b438
+++ b/source3/rpc_server/netlogon/srv_netlog_nt.c
b6b438
@@ -419,6 +419,7 @@ NTSTATUS _netr_NetrEnumerateTrustedDomains(struct pipes_struct *p,
b6b438
 	int i;
b6b438
 	uint32_t max_size = (uint32_t)-1;
b6b438
 
b6b438
+	ZERO_STRUCT(pol);
b6b438
 	DEBUG(6,("_netr_NetrEnumerateTrustedDomains: %d\n", __LINE__));
b6b438
 
b6b438
 	status = rpcint_binding_handle(p->mem_ctx,
b6b438
-- 
b6b438
2.23.0
b6b438