|
 |
efbbe3 |
From dfb3496c174377b860b62872ce6af951364cc3ac Mon Sep 17 00:00:00 2001
|
|
|
efbbe3 |
From: Lokesh Mandvekar <lsm5@fedoraproject.org>
|
|
|
efbbe3 |
Date: Tue, 12 Dec 2017 13:22:42 +0530
|
|
|
efbbe3 |
Subject: [PATCH] Revert "Apply cgroups earlier"
|
|
|
efbbe3 |
|
|
|
efbbe3 |
This reverts commit 7062c7556b71188abc18d7516441ff4b03fbc1fc.
|
|
|
efbbe3 |
---
|
|
|
efbbe3 |
libcontainer/process_linux.go | 31 ++++++++++++++-----------------
|
|
|
efbbe3 |
1 file changed, 14 insertions(+), 17 deletions(-)
|
|
|
efbbe3 |
|
|
|
efbbe3 |
diff --git a/libcontainer/process_linux.go b/libcontainer/process_linux.go
|
|
|
efbbe3 |
index 149b1126..b8a395af 100644
|
|
|
efbbe3 |
--- a/libcontainer/process_linux.go
|
|
|
efbbe3 |
+++ b/libcontainer/process_linux.go
|
|
|
efbbe3 |
@@ -272,6 +272,20 @@ func (p *initProcess) start() error {
|
|
|
efbbe3 |
p.process.ops = nil
|
|
|
efbbe3 |
return newSystemErrorWithCause(err, "starting init process command")
|
|
|
efbbe3 |
}
|
|
|
efbbe3 |
+ if _, err := io.Copy(p.parentPipe, p.bootstrapData); err != nil {
|
|
|
efbbe3 |
+ return newSystemErrorWithCause(err, "copying bootstrap data to pipe")
|
|
|
efbbe3 |
+ }
|
|
|
efbbe3 |
+ if err := p.execSetns(); err != nil {
|
|
|
efbbe3 |
+ return newSystemErrorWithCause(err, "running exec setns process for init")
|
|
|
efbbe3 |
+ }
|
|
|
efbbe3 |
+ // Save the standard descriptor names before the container process
|
|
|
efbbe3 |
+ // can potentially move them (e.g., via dup2()). If we don't do this now,
|
|
|
efbbe3 |
+ // we won't know at checkpoint time which file descriptor to look up.
|
|
|
efbbe3 |
+ fds, err := getPipeFds(p.pid())
|
|
|
efbbe3 |
+ if err != nil {
|
|
|
efbbe3 |
+ return newSystemErrorWithCausef(err, "getting pipe fds for pid %d", p.pid())
|
|
|
efbbe3 |
+ }
|
|
|
efbbe3 |
+ p.setExternalDescriptors(fds)
|
|
|
efbbe3 |
// Do this before syncing with child so that no children can escape the
|
|
|
efbbe3 |
// cgroup. We don't need to worry about not doing this and not being root
|
|
|
efbbe3 |
// because we'd be using the rootless cgroup manager in that case.
|
|
|
efbbe3 |
@@ -292,23 +306,6 @@ func (p *initProcess) start() error {
|
|
|
efbbe3 |
}
|
|
|
efbbe3 |
}
|
|
|
efbbe3 |
}()
|
|
|
efbbe3 |
-
|
|
|
efbbe3 |
- if _, err := io.Copy(p.parentPipe, p.bootstrapData); err != nil {
|
|
|
efbbe3 |
- return newSystemErrorWithCause(err, "copying bootstrap data to pipe")
|
|
|
efbbe3 |
- }
|
|
|
efbbe3 |
-
|
|
|
efbbe3 |
- if err := p.execSetns(); err != nil {
|
|
|
efbbe3 |
- return newSystemErrorWithCause(err, "running exec setns process for init")
|
|
|
efbbe3 |
- }
|
|
|
efbbe3 |
-
|
|
|
efbbe3 |
- // Save the standard descriptor names before the container process
|
|
|
efbbe3 |
- // can potentially move them (e.g., via dup2()). If we don't do this now,
|
|
|
efbbe3 |
- // we won't know at checkpoint time which file descriptor to look up.
|
|
|
efbbe3 |
- fds, err := getPipeFds(p.pid())
|
|
|
efbbe3 |
- if err != nil {
|
|
|
efbbe3 |
- return newSystemErrorWithCausef(err, "getting pipe fds for pid %d", p.pid())
|
|
|
efbbe3 |
- }
|
|
|
efbbe3 |
- p.setExternalDescriptors(fds)
|
|
|
efbbe3 |
if err := p.createNetworkInterfaces(); err != nil {
|
|
|
efbbe3 |
return newSystemErrorWithCause(err, "creating network interfaces")
|
|
|
efbbe3 |
}
|
|
|
efbbe3 |
--
|
|
|
efbbe3 |
2.14.3
|
|
|
efbbe3 |
|