6a79cc
From e2c0652dff671dc6e16a80887e781edc0abc8454 Mon Sep 17 00:00:00 2001
6a79cc
From: usa <usa@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>
6a79cc
Date: Wed, 24 Nov 2021 11:41:55 +0000
6a79cc
Subject: [PATCH 2/2] When parsing cookies, only decode the values
6a79cc
6a79cc
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67953 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
6a79cc
---
6a79cc
 lib/cgi/cookie.rb           | 1 -
6a79cc
 test/cgi/test_cgi_cookie.rb | 5 +++++
6a79cc
 2 files changed, 5 insertions(+), 1 deletion(-)
6a79cc
6a79cc
diff --git a/lib/cgi/cookie.rb b/lib/cgi/cookie.rb
6a79cc
index a2155edb77..009566bb92 100644
6a79cc
--- a/lib/cgi/cookie.rb
6a79cc
+++ b/lib/cgi/cookie.rb
6a79cc
@@ -165,7 +165,6 @@ def self.parse(raw_cookie)
6a79cc
       raw_cookie.split(/;\s?/).each do |pairs|
6a79cc
         name, values = pairs.split('=',2)
6a79cc
         next unless name and values
6a79cc
-        name = CGI.unescape(name)
6a79cc
         values ||= ""
6a79cc
         values = values.split('&').collect{|v| CGI.unescape(v,@@accept_charset) }
6a79cc
         if cookies.has_key?(name)
6a79cc
diff --git a/test/cgi/test_cgi_cookie.rb b/test/cgi/test_cgi_cookie.rb
6a79cc
index 115a57e4a1..985cc0d7a1 100644
6a79cc
--- a/test/cgi/test_cgi_cookie.rb
6a79cc
+++ b/test/cgi/test_cgi_cookie.rb
6a79cc
@@ -101,6 +101,11 @@ def test_cgi_cookie_parse
6a79cc
     end
6a79cc
   end
6a79cc
 
6a79cc
+  def test_cgi_cookie_parse_not_decode_name
6a79cc
+    cookie_str = "%66oo=baz;foo=bar"
6a79cc
+    cookies = CGI::Cookie.parse(cookie_str)
6a79cc
+    assert_equal({"%66oo" => ["baz"], "foo" => ["bar"]}, cookies)
6a79cc
+  end
6a79cc
 
6a79cc
   def test_cgi_cookie_arrayinterface
6a79cc
     cookie = CGI::Cookie.new('name1', 'a', 'b', 'c')
6a79cc
-- 
6a79cc
2.36.1
6a79cc