|
 |
ecbd30 |
From ab22e3a00f04b458039c21111cfa448051e5777d Mon Sep 17 00:00:00 2001
|
|
|
ecbd30 |
From: Daniel Stenberg <daniel@haxx.se>
|
|
|
ecbd30 |
Date: Thu, 3 Jan 2019 12:59:28 +0100
|
|
|
ecbd30 |
Subject: [PATCH] ntlm: fix *_type3_message size check to avoid buffer overflow
|
|
|
ecbd30 |
|
|
|
ecbd30 |
Bug: https://curl.haxx.se/docs/CVE-2019-3822.html
|
|
|
ecbd30 |
Reported-by: Wenxiang Qian
|
|
|
ecbd30 |
CVE-2019-3822
|
|
|
ecbd30 |
|
|
|
ecbd30 |
Upstream-commit: 50c9484278c63b958655a717844f0721263939cc
|
|
|
ecbd30 |
Signed-off-by: Kamil Dudka <kdudka@redhat.com>
|
|
|
ecbd30 |
---
|
|
|
ecbd30 |
lib/vauth/ntlm.c | 11 +++++++----
|
|
|
ecbd30 |
1 file changed, 7 insertions(+), 4 deletions(-)
|
|
|
ecbd30 |
|
|
|
ecbd30 |
diff --git a/lib/vauth/ntlm.c b/lib/vauth/ntlm.c
|
|
|
ecbd30 |
index b614cda..a3a55d9 100644
|
|
|
ecbd30 |
--- a/lib/vauth/ntlm.c
|
|
|
ecbd30 |
+++ b/lib/vauth/ntlm.c
|
|
|
ecbd30 |
@@ -777,11 +777,14 @@ CURLcode Curl_auth_create_ntlm_type3_message(struct Curl_easy *data,
|
|
|
ecbd30 |
});
|
|
|
ecbd30 |
|
|
|
ecbd30 |
#ifdef USE_NTRESPONSES
|
|
|
ecbd30 |
- if(size < (NTLM_BUFSIZE - ntresplen)) {
|
|
|
ecbd30 |
- DEBUGASSERT(size == (size_t)ntrespoff);
|
|
|
ecbd30 |
- memcpy(&ntlmbuf[size], ptr_ntresp, ntresplen);
|
|
|
ecbd30 |
- size += ntresplen;
|
|
|
ecbd30 |
+ /* ntresplen + size should not be risking an integer overflow here */
|
|
|
ecbd30 |
+ if(ntresplen + size > sizeof(ntlmbuf)) {
|
|
|
ecbd30 |
+ failf(data, "incoming NTLM message too big");
|
|
|
ecbd30 |
+ return CURLE_OUT_OF_MEMORY;
|
|
|
ecbd30 |
}
|
|
|
ecbd30 |
+ DEBUGASSERT(size == (size_t)ntrespoff);
|
|
|
ecbd30 |
+ memcpy(&ntlmbuf[size], ptr_ntresp, ntresplen);
|
|
|
ecbd30 |
+ size += ntresplen;
|
|
|
ecbd30 |
|
|
|
ecbd30 |
DEBUG_OUT({
|
|
|
ecbd30 |
fprintf(stderr, "\n ntresp=");
|
|
|
ecbd30 |
--
|
|
|
ecbd30 |
2.17.2
|
|
|
ecbd30 |
|