Blame SOURCES/bz2083081-bz2083086-bz2083090-bz2083092-update-openstack-agents.patch

d5211c
diff --color -uNr a/heartbeat/Makefile.am b/heartbeat/Makefile.am
d5211c
--- a/heartbeat/Makefile.am	2022-03-15 16:14:29.355209012 +0100
d5211c
+++ b/heartbeat/Makefile.am	2022-03-15 16:18:35.917048467 +0100
d5211c
@@ -217,6 +217,7 @@
d5211c
 			  lvm-clvm.sh		\
d5211c
 			  lvm-plain.sh		\
d5211c
 			  lvm-tag.sh		\
d5211c
+			  openstack-common.sh	\
d5211c
 			  ora-common.sh		\
d5211c
 			  mysql-common.sh	\
d5211c
 			  nfsserver-redhat.sh	\
d5211c
diff --color -uNr a/heartbeat/openstack-cinder-volume b/heartbeat/openstack-cinder-volume
d5211c
--- a/heartbeat/openstack-cinder-volume	2022-03-15 16:14:29.370209063 +0100
d5211c
+++ b/heartbeat/openstack-cinder-volume	2022-03-15 16:17:36.231840008 +0100
d5211c
@@ -34,11 +34,11 @@
d5211c
 : ${OCF_FUNCTIONS_DIR=${OCF_ROOT}/lib/heartbeat}
d5211c
 . ${OCF_FUNCTIONS_DIR}/ocf-shellfuncs
d5211c
 
d5211c
+. ${OCF_FUNCTIONS_DIR}/openstack-common.sh
d5211c
+
d5211c
 # Defaults
d5211c
-OCF_RESKEY_openstackcli_default="/usr/bin/openstack"
d5211c
 OCF_RESKEY_volume_local_check_default="true"
d5211c
 
d5211c
-: ${OCF_RESKEY_openstackcli=${OCF_RESKEY_openstackcli_default}}
d5211c
 : ${OCF_RESKEY_volume_local_check=${OCF_RESKEY_volume_local_check_default}}
d5211c
 
d5211c
 #######################################################################
d5211c
@@ -68,14 +68,11 @@
d5211c
 <shortdesc lang="en">Attach a cinder volume</shortdesc>
d5211c
 
d5211c
 <parameters>
d5211c
-<parameter name="openstackcli">
d5211c
-<longdesc lang="en">
d5211c
-Path to command line tools for openstack.
d5211c
-</longdesc>
d5211c
-<shortdesc lang="en">Path to Openstack CLI tool</shortdesc>
d5211c
-<content type="string" default="${OCF_RESKEY_openstackcli_default}" />
d5211c
-</parameter>
d5211c
+END
d5211c
 
d5211c
+common_meta_data
d5211c
+
d5211c
+cat <
d5211c
 <parameter name="volume_local_check">
d5211c
 <longdesc lang="en">
d5211c
 This option allows the cluster to monitor the cinder volume presence without 
d5211c
@@ -85,28 +82,19 @@
d5211c
 <content type="boolean" default="${OCF_RESKEY_volume_local_check_default}" />
d5211c
 </parameter>
d5211c
 
d5211c
-<parameter name="openrc" required="1">
d5211c
-<longdesc lang="en">
d5211c
-Valid Openstack credentials as openrc file from api_access/openrc.
d5211c
-</longdesc>
d5211c
-<shortdesc lang="en">openrc file</shortdesc>
d5211c
-<content type="string" />
d5211c
-</parameter>
d5211c
-
d5211c
 <parameter name="volume_id" required="1">
d5211c
 <longdesc lang="en">
d5211c
-Cinder volume identifier to use to attach the bloc storage.
d5211c
+Cinder volume identifier to use to attach the block storage.
d5211c
 </longdesc>
d5211c
 <shortdesc lang="en">Volume ID</shortdesc>
d5211c
 <content type="string" />
d5211c
 </parameter>
d5211c
-
d5211c
 </parameters>
d5211c
 
d5211c
 <actions>
d5211c
 <action name="start" timeout="180s" />
d5211c
 <action name="stop" timeout="180s" />
d5211c
-<action name="monitor" depth="0" timeout="30s" interval="60s" />
d5211c
+<action name="monitor" depth="0" timeout="180s" interval="60s" />
d5211c
 <action name="validate-all" timeout="5s" />
d5211c
 <action name="meta-data" timeout="5s" />
d5211c
 </actions>
d5211c
@@ -127,17 +115,7 @@
d5211c
 osvol_validate() {
d5211c
 	check_binary "$OCF_RESKEY_openstackcli"
d5211c
 	
d5211c
-	if [ -z "$OCF_RESKEY_openrc" ]; then
d5211c
-		ocf_exit_reason "openrc parameter not set"
d5211c
-		return $OCF_ERR_CONFIGURED
d5211c
-	fi
d5211c
-
d5211c
-	if [ ! -f "$OCF_RESKEY_openrc" ] ; then
d5211c
-		ocf_exit_reason "openrc file not found"
d5211c
-		return $OCF_ERR_CONFIGURED
d5211c
-	fi
d5211c
-
d5211c
-	. $OCF_RESKEY_openrc
d5211c
+	get_config
d5211c
 
d5211c
 	if ! $OCF_RESKEY_openstackcli volume list|grep -q $OCF_RESKEY_volume_id ; then
d5211c
 		ocf_exit_reason "volume-id $OCF_RESKEY_volume_id not found"
d5211c
diff --color -uNr a/heartbeat/openstack-common.sh b/heartbeat/openstack-common.sh
d5211c
--- a/heartbeat/openstack-common.sh	1970-01-01 01:00:00.000000000 +0100
d5211c
+++ b/heartbeat/openstack-common.sh	2022-03-15 16:17:36.232840011 +0100
d5211c
@@ -0,0 +1,147 @@
d5211c
+OCF_RESKEY_openstackcli_default="/usr/bin/openstack"
d5211c
+OCF_RESKEY_insecure_default="false"
d5211c
+
d5211c
+: ${OCF_RESKEY_openstackcli=${OCF_RESKEY_openstackcli_default}}
d5211c
+: ${OCF_RESKEY_insecure=${OCF_RESKEY_insecure_default}}
d5211c
+
d5211c
+if ocf_is_true "${OCF_RESKEY_insecure}"; then
d5211c
+	OCF_RESKEY_openstackcli="${OCF_RESKEY_openstackcli} --insecure"
d5211c
+fi
d5211c
+
d5211c
+common_meta_data() {
d5211c
+	cat <
d5211c
+
d5211c
+<parameter name="cloud" required="0">
d5211c
+<longdesc lang="en">
d5211c
+Openstack cloud (from ~/.config/openstack/clouds.yaml or /etc/openstack/clouds.yaml).
d5211c
+</longdesc>
d5211c
+<shortdesc lang="en">Cloud from clouds.yaml</shortdesc>
d5211c
+<content type="string" />
d5211c
+</parameter>
d5211c
+
d5211c
+<parameter name="openrc" required="0">
d5211c
+<longdesc lang="en">
d5211c
+Openstack credentials as openrc file from api_access/openrc.
d5211c
+</longdesc>
d5211c
+<shortdesc lang="en">openrc file</shortdesc>
d5211c
+<content type="string" />
d5211c
+</parameter>
d5211c
+
d5211c
+<parameter name="auth_url" required="0">
d5211c
+<longdesc lang="en">
d5211c
+Keystone Auth URL
d5211c
+</longdesc>
d5211c
+<shortdesc lang="en">Keystone Auth URL</shortdesc>
d5211c
+<content type="string" />
d5211c
+</parameter>
d5211c
+
d5211c
+<parameter name="username" required="0">
d5211c
+<longdesc lang="en">
d5211c
+Username.
d5211c
+</longdesc>
d5211c
+<shortdesc lang="en">Username</shortdesc>
d5211c
+<content type="string" />
d5211c
+</parameter>
d5211c
+
d5211c
+<parameter name="password" required="0">
d5211c
+<longdesc lang="en">
d5211c
+Password.
d5211c
+</longdesc>
d5211c
+<shortdesc lang="en">Password</shortdesc>
d5211c
+<content type="string" />
d5211c
+</parameter>
d5211c
+
d5211c
+<parameter name="project_name" required="0">
d5211c
+<longdesc lang="en">
d5211c
+Keystone Project.
d5211c
+</longdesc>
d5211c
+<shortdesc lang="en">Keystone Project</shortdesc>
d5211c
+<content type="string" />
d5211c
+</parameter>
d5211c
+
d5211c
+<parameter name="user_domain_name" required="0">
d5211c
+<longdesc lang="en">
d5211c
+Keystone User Domain Name.
d5211c
+</longdesc>
d5211c
+<shortdesc lang="en">Keystone User Domain Name</shortdesc>
d5211c
+<content type="string" />
d5211c
+</parameter>
d5211c
+
d5211c
+<parameter name="project_domain_name" required="0">
d5211c
+<longdesc lang="en">
d5211c
+Keystone Project Domain Name.
d5211c
+</longdesc>
d5211c
+<shortdesc lang="en">Keystone Project Domain Name</shortdesc>
d5211c
+<content type="string" />
d5211c
+</parameter>
d5211c
+
d5211c
+<parameter name="openstackcli">
d5211c
+<longdesc lang="en">
d5211c
+Path to command line tools for openstack.
d5211c
+</longdesc>
d5211c
+<shortdesc lang="en">Path to Openstack CLI tool</shortdesc>
d5211c
+<content type="string" default="${OCF_RESKEY_openstackcli_default}" />
d5211c
+</parameter>
d5211c
+
d5211c
+<parameter name="insecure">
d5211c
+<longdesc lang="en">
d5211c
+Allow insecure connections
d5211c
+</longdesc>
d5211c
+<shortdesc lang="en">Allow insecure connections</shortdesc>
d5211c
+<content type="boolean" default="${OCF_RESKEY_insecure_default}" />
d5211c
+</parameter>
d5211c
+END
d5211c
+}
d5211c
+
d5211c
+get_config() {
d5211c
+	if [ -n "$OCF_RESKEY_cloud" ]; then
d5211c
+		TILDE=$(echo ~)
d5211c
+		clouds_yaml="$TILDE/.config/openstack/clouds.yaml"
d5211c
+		if [ ! -f "$clouds_yaml" ]; then
d5211c
+			clouds_yaml="/etc/openstack/clouds.yaml"
d5211c
+		fi
d5211c
+		if [ ! -f "$clouds_yaml" ]; then
d5211c
+			ocf_exit_reason "~/.config/openstack/clouds.yaml and /etc/openstack/clouds.yaml does not exist"
d5211c
+			exit $OCF_ERR_CONFIGURED
d5211c
+		fi
d5211c
+		OCF_RESKEY_openstackcli="${OCF_RESKEY_openstackcli} --os-cloud $OCF_RESKEY_cloud"
d5211c
+	elif [ -n "$OCF_RESKEY_openrc" ]; then
d5211c
+		if [ ! -f "$OCF_RESKEY_openrc" ]; then
d5211c
+			ocf_exit_reason "$OCF_RESKEY_openrc does not exist"
d5211c
+			exit $OCF_ERR_CONFIGURED
d5211c
+		fi
d5211c
+		. $OCF_RESKEY_openrc
d5211c
+	else
d5211c
+		if [ -z "$OCF_RESKEY_auth_url" ]; then
d5211c
+			ocf_exit_reason "auth_url not set"
d5211c
+			exit $OCF_ERR_CONFIGURED
d5211c
+		fi
d5211c
+		if [ -z "$OCF_RESKEY_username" ]; then
d5211c
+			ocf_exit_reason "username not set"
d5211c
+			exit $OCF_ERR_CONFIGURED
d5211c
+		fi
d5211c
+		if [ -z "$OCF_RESKEY_password" ]; then
d5211c
+			ocf_exit_reason "password not set"
d5211c
+			exit $OCF_ERR_CONFIGURED
d5211c
+		fi
d5211c
+		if [ -z "$OCF_RESKEY_project_name" ]; then
d5211c
+			ocf_exit_reason "project_name not set"
d5211c
+			exit $OCF_ERR_CONFIGURED
d5211c
+		fi
d5211c
+		if [ -z "$OCF_RESKEY_user_domain_name" ]; then
d5211c
+			ocf_exit_reason "user_domain_name not set"
d5211c
+			exit $OCF_ERR_CONFIGURED
d5211c
+		fi
d5211c
+		if [ -z "$OCF_RESKEY_project_domain_name" ]; then
d5211c
+			ocf_exit_reason " not set"
d5211c
+			exit $OCF_ERR_CONFIGURED
d5211c
+		fi
d5211c
+
d5211c
+		OCF_RESKEY_openstackcli="${OCF_RESKEY_openstackcli} --os-auth-url $OCF_RESKEY_auth_url"
d5211c
+		OCF_RESKEY_openstackcli="${OCF_RESKEY_openstackcli} --os-username $OCF_RESKEY_username"
d5211c
+		OCF_RESKEY_openstackcli="${OCF_RESKEY_openstackcli} --os-password $OCF_RESKEY_password"
d5211c
+		OCF_RESKEY_openstackcli="${OCF_RESKEY_openstackcli} --os-project-name $OCF_RESKEY_project_name"
d5211c
+		OCF_RESKEY_openstackcli="${OCF_RESKEY_openstackcli} --os-user-domain-name $OCF_RESKEY_user_domain_name"
d5211c
+		OCF_RESKEY_openstackcli="${OCF_RESKEY_openstackcli} --os-project-domain-name $OCF_RESKEY_project_domain_name"
d5211c
+	fi
d5211c
+}
d5211c
diff --color -uNr a/heartbeat/openstack-floating-ip b/heartbeat/openstack-floating-ip
d5211c
--- a/heartbeat/openstack-floating-ip	2022-03-15 16:14:29.370209063 +0100
d5211c
+++ b/heartbeat/openstack-floating-ip	2022-03-15 16:17:36.233840014 +0100
d5211c
@@ -34,10 +34,9 @@
d5211c
 : ${OCF_FUNCTIONS_DIR=${OCF_ROOT}/lib/heartbeat}
d5211c
 . ${OCF_FUNCTIONS_DIR}/ocf-shellfuncs
d5211c
 
d5211c
-# Defaults
d5211c
-OCF_RESKEY_openstackcli_default="/usr/bin/openstack"
d5211c
+. ${OCF_FUNCTIONS_DIR}/openstack-common.sh
d5211c
 
d5211c
-: ${OCF_RESKEY_openstackcli=${OCF_RESKEY_openstackcli_default}}
d5211c
+# Defaults
d5211c
 
d5211c
 #######################################################################
d5211c
 
d5211c
@@ -67,22 +66,11 @@
d5211c
 <shortdesc lang="en">Move a floating IP</shortdesc>
d5211c
 
d5211c
 <parameters>
d5211c
-<parameter name="openstackcli">
d5211c
-<longdesc lang="en">
d5211c
-Path to command line tools for openstack.
d5211c
-</longdesc>
d5211c
-<shortdesc lang="en">Path to Openstack CLI tool</shortdesc>
d5211c
-<content type="string" default="${OCF_RESKEY_openstackcli_default}" />
d5211c
-</parameter>
d5211c
+END
d5211c
 
d5211c
-<parameter name="openrc" required="1">
d5211c
-<longdesc lang="en">
d5211c
-Valid Openstack credentials as openrc file from api_access/openrc.
d5211c
-</longdesc>
d5211c
-<shortdesc lang="en">openrc file</shortdesc>
d5211c
-<content type="string" />
d5211c
-</parameter>
d5211c
+common_meta_data
d5211c
 
d5211c
+cat <
d5211c
 <parameter name="ip_id" required="1">
d5211c
 <longdesc lang="en">
d5211c
 Floating IP Identifier.
d5211c
@@ -104,7 +92,7 @@
d5211c
 <actions>
d5211c
 <action name="start" timeout="180s" />
d5211c
 <action name="stop" timeout="180s" />
d5211c
-<action name="monitor" depth="0" timeout="30s" interval="60s" />
d5211c
+<action name="monitor" depth="0" timeout="180s" interval="60s" />
d5211c
 <action name="validate-all" timeout="5s" />
d5211c
 <action name="meta-data" timeout="5s" />
d5211c
 </actions>
d5211c
@@ -115,17 +103,7 @@
d5211c
 osflip_validate() {
d5211c
 	check_binary "$OCF_RESKEY_openstackcli"
d5211c
 
d5211c
-	if [ -z "$OCF_RESKEY_openrc" ]; then
d5211c
-		ocf_exit_reason "openrc parameter not set"
d5211c
-		return $OCF_ERR_CONFIGURED
d5211c
-	fi
d5211c
-
d5211c
-	if [ ! -f "$OCF_RESKEY_openrc" ] ; then
d5211c
-		ocf_exit_reason "openrc file not found"
d5211c
-		return $OCF_ERR_CONFIGURED
d5211c
-	fi
d5211c
-
d5211c
-	. $OCF_RESKEY_openrc
d5211c
+	get_config
d5211c
 
d5211c
 	if ! $OCF_RESKEY_openstackcli floating ip list|grep -q $OCF_RESKEY_ip_id ; then
d5211c
 		ocf_exit_reason "ip-id $OCF_RESKEY_ip_id not found"
d5211c
diff --color -uNr a/heartbeat/openstack-info b/heartbeat/openstack-info
d5211c
--- a/heartbeat/openstack-info	1970-01-01 01:00:00.000000000 +0100
d5211c
+++ b/heartbeat/openstack-info	2022-03-15 16:17:36.234840018 +0100
d5211c
@@ -0,0 +1,270 @@
d5211c
+#!/bin/sh
d5211c
+#
d5211c
+#
d5211c
+# OCF resource agent to set attributes from Openstack instance details.
d5211c
+# It records (in the CIB) various attributes of a node
d5211c
+#
d5211c
+# Copyright (c) 2018 Mathieu Grzybek
d5211c
+#          All Rights Reserved.
d5211c
+#
d5211c
+# This program is free software; you can redistribute it and/or modify
d5211c
+# it under the terms of version 2 of the GNU General Public License as
d5211c
+# published by the Free Software Foundation.
d5211c
+#
d5211c
+# This program is distributed in the hope that it would be useful, but
d5211c
+# WITHOUT ANY WARRANTY; without even the implied warranty of
d5211c
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
d5211c
+#
d5211c
+# Further, this software is distributed without any warranty that it is
d5211c
+# free of the rightful claim of any third person regarding infringement
d5211c
+# or the like. Any license provided herein, whether implied or
d5211c
+# otherwise, applies only to this software file. Patent licenses, if
d5211c
+# any, provided herein do not apply to combinations of this program with
d5211c
+# other software, or any other product whatsoever.
d5211c
+#
d5211c
+# You should have received a copy of the GNU General Public License
d5211c
+# along with this program; if not, write the Free Software Foundation,
d5211c
+# Inc., 59 Temple Place - Suite 330, Boston MA 02111-1307, USA.
d5211c
+#
d5211c
+#######################################################################
d5211c
+# Initialization:
d5211c
+
d5211c
+: ${OCF_FUNCTIONS_DIR=${OCF_ROOT}/lib/heartbeat}
d5211c
+. ${OCF_FUNCTIONS_DIR}/ocf-shellfuncs
d5211c
+
d5211c
+. ${OCF_FUNCTIONS_DIR}/openstack-common.sh
d5211c
+
d5211c
+# Defaults
d5211c
+OCF_RESKEY_pidfile_default="$HA_RSCTMP/OSInfo-${OCF_RESOURCE_HOSTNAME}"
d5211c
+OCF_RESKEY_delay_default="0"
d5211c
+OCF_RESKEY_clone_default="0"
d5211c
+OCF_RESKEY_curlcli_default="/usr/bin/curl"
d5211c
+OCF_RESKEY_pythoncli_default="/usr/bin/python"
d5211c
+
d5211c
+: ${OCF_RESKEY_curlcli=${OCF_RESKEY_curlcli_default}}
d5211c
+: ${OCF_RESKEY_pythoncli=${OCF_RESKEY_pythoncli_default}}
d5211c
+: ${OCF_RESKEY_pidfile=${OCF_RESKEY_pidfile_default}}
d5211c
+: ${OCF_RESKEY_delay=${OCF_RESKEY_delay_default}}
d5211c
+: ${OCF_RESKEY_clone=${OCF_RESKEY_clone_default}}
d5211c
+
d5211c
+#######################################################################
d5211c
+
d5211c
+meta_data() {
d5211c
+	cat <
d5211c
+
d5211c
+
d5211c
+<resource-agent name="openstack-info" version="1.0">
d5211c
+<version>1.0</version>
d5211c
+
d5211c
+<longdesc lang="en">
d5211c
+OCF resource agent to set attributes from Openstack instance details.
d5211c
+It records (in the CIB) various attributes of a node.
d5211c
+Sample output:
d5211c
+	openstack_az      : nova
d5211c
+	openstack_flavor  : c1.small
d5211c
+	openstack_id      : 60ac4343-5828-49b1-8aac-7c69b1417f31
d5211c
+	openstack_ports   : 7960d889-9750-4160-bf41-c69a41ad72d9:96530d18-57a3-4718-af32-30f2a74c22a2,b0e55a06-bd75-468d-8baa-22cfeb65799f:a55ae917-8016-4b1e-8ffa-04311b9dc7d6
d5211c
+
d5211c
+The layout of openstack_ports is a comma-separated list of tuples "subnet_id:port_id".
d5211c
+</longdesc>
d5211c
+<shortdesc lang="en">Records various node attributes in the CIB</shortdesc>
d5211c
+
d5211c
+<parameters>
d5211c
+END
d5211c
+
d5211c
+common_meta_data
d5211c
+
d5211c
+	cat <
d5211c
+<parameter name="pidfile" unique="0">
d5211c
+<longdesc lang="en">PID file</longdesc>
d5211c
+<shortdesc lang="en">PID file</shortdesc>
d5211c
+<content type="string" default="${OCF_RESKEY_pidfile_default}" />
d5211c
+</parameter>
d5211c
+
d5211c
+<parameter name="delay" unique="0">
d5211c
+<longdesc lang="en">Interval to allow values to stabilize</longdesc>
d5211c
+<shortdesc lang="en">Dampening Delay</shortdesc>
d5211c
+<content type="string" default="${OCF_RESKEY_delay_default}" />
d5211c
+</parameter>
d5211c
+
d5211c
+<parameter name="curlcli">
d5211c
+<longdesc lang="en">
d5211c
+Path to command line cURL binary.
d5211c
+</longdesc>
d5211c
+<shortdesc lang="en">Path to cURL binary</shortdesc>
d5211c
+<content type="string" default="${OCF_RESKEY_curlcli_default}" />
d5211c
+</parameter>
d5211c
+
d5211c
+<parameter name="pythoncli">
d5211c
+<longdesc lang="en">
d5211c
+Path to command line Python interpreter.
d5211c
+</longdesc>
d5211c
+<shortdesc lang="en">Path to Python interpreter</shortdesc>
d5211c
+<content type="string" default="${OCF_RESKEY_pythoncli_default}" />
d5211c
+</parameter>
d5211c
+
d5211c
+</parameters>
d5211c
+
d5211c
+<actions>
d5211c
+<action name="start"  timeout="180s" />
d5211c
+<action name="stop" timeout="180s" />
d5211c
+<action name="monitor" timeout="30s" interval="60s"/>
d5211c
+<action name="meta-data" timeout="5s" />
d5211c
+<action name="validate-all" timeout="20s" />
d5211c
+</actions>
d5211c
+</resource-agent>
d5211c
+END
d5211c
+}
d5211c
+
d5211c
+#######################################################################
d5211c
+
d5211c
+OSInfoStats() {
d5211c
+	local result
d5211c
+	local value
d5211c
+	local node
d5211c
+	local node_id
d5211c
+
d5211c
+	get_config
d5211c
+
d5211c
+	# Nova data: server ID
d5211c
+	node_id=$($OCF_RESKEY_curlcli \
d5211c
+		-s http://169.254.169.254/openstack/latest/meta_data.json |
d5211c
+		$OCF_RESKEY_pythoncli -m json.tool |
d5211c
+		grep -P '\"uuid\": \".*\",$' |
d5211c
+		grep -P -o '[0-9a-f]{8}-([0-9a-f]{4}-){3}[0-9a-f]{12}')
d5211c
+
d5211c
+	if [ $? -ne 0 ] ; then
d5211c
+		ocf_exit_reason "Cannot find server ID"
d5211c
+		exit $OCF_ERR_GENERIC
d5211c
+	fi
d5211c
+
d5211c
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -n openstack_id -v "$node_id"
d5211c
+
d5211c
+	# Nova data: flavor
d5211c
+	value=$($OCF_RESKEY_openstackcli server show \
d5211c
+		--format value \
d5211c
+		--column flavor \
d5211c
+		$node_id)
d5211c
+
d5211c
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -n openstack_flavor -v "$value"
d5211c
+
d5211c
+	# Nova data: availability zone
d5211c
+	value=$($OCF_RESKEY_openstackcli server show \
d5211c
+		--format value \
d5211c
+		--column OS-EXT-AZ:availability_zone \
d5211c
+		$node_id)
d5211c
+
d5211c
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -n openstack_az -v "$value"
d5211c
+
d5211c
+	# Network data: ports
d5211c
+	value=""
d5211c
+	for port_id in $($OCF_RESKEY_openstackcli port list \
d5211c
+		--format value \
d5211c
+		--column id \
d5211c
+		--server $node_id); do
d5211c
+		subnet_id=$($OCF_RESKEY_openstackcli port show \
d5211c
+			--format json \
d5211c
+			--column fixed_ips \
d5211c
+			${port_id} | grep -P '\"subnet_id\": \".*\",$' |
d5211c
+			grep -P -o '[0-9a-f]{8}-([0-9a-f]{4}-){3}[0-9a-f]{12}')
d5211c
+		value+="${subnet_id}:${port_id},"
d5211c
+	done
d5211c
+	value=$(echo ${value} | sed -e 's/,$//g')
d5211c
+
d5211c
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -n openstack_ports -v "$value"
d5211c
+
d5211c
+	if [ ! -z "$OS_REGION_NAME" ] ; then
d5211c
+		${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -n openstack_region -v "$OS_REGION_NAME"
d5211c
+	fi
d5211c
+
d5211c
+	if [ ! -z "$OS_TENANT_ID" ] ; then
d5211c
+		${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -n openstack_tenant_id -v "$OS_TENANT_ID"
d5211c
+
d5211c
+		if [ ! -z "$OS_TENANT_NAME" ] ; then
d5211c
+			${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -n openstack_tenant_name -v "$OS_TENANT_NAME"
d5211c
+		fi
d5211c
+	else
d5211c
+		${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -n openstack_project_id -v "$OS_PROJECT_ID"
d5211c
+
d5211c
+		if [ ! -z "$OS_PROJECT_NAME" ] ; then
d5211c
+			${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -n openstack_project_name -v "$OS_PROJECT_NAME"
d5211c
+		fi
d5211c
+	fi
d5211c
+
d5211c
+}
d5211c
+
d5211c
+OSInfo_usage() {
d5211c
+	cat <
d5211c
+usage: $0 {start|stop|monitor|validate-all|meta-data}
d5211c
+
d5211c
+Expects to have a fully populated OCF RA-compliant environment set.
d5211c
+END
d5211c
+}
d5211c
+
d5211c
+OSInfo_start() {
d5211c
+	echo $OCF_RESKEY_clone > $OCF_RESKEY_pidfile
d5211c
+	OSInfoStats
d5211c
+	exit $OCF_SUCCESS
d5211c
+}
d5211c
+
d5211c
+OSInfo_stop() {
d5211c
+	rm -f $OCF_RESKEY_pidfile
d5211c
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -D -n openstack_id
d5211c
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -D -n openstack_flavor
d5211c
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -D -n openstack_az
d5211c
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -D -n openstack_ports
d5211c
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -D -n openstack_region
d5211c
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -D -n openstack_tenant_id
d5211c
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -D -n openstack_tenant_name
d5211c
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -D -n openstack_project_id
d5211c
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -D -n openstack_project_name
d5211c
+	exit $OCF_SUCCESS
d5211c
+}
d5211c
+
d5211c
+OSInfo_monitor() {
d5211c
+	if [ -f "$OCF_RESKEY_pidfile" ] ; then
d5211c
+		OSInfoStats
d5211c
+		exit $OCF_RUNNING
d5211c
+	fi
d5211c
+	exit $OCF_NOT_RUNNING
d5211c
+}
d5211c
+
d5211c
+OSInfo_validate() {
d5211c
+	check_binary "$OCF_RESKEY_curlcli"
d5211c
+	check_binary "$OCF_RESKEY_openstackcli"
d5211c
+	check_binary "$OCF_RESKEY_pythoncli"
d5211c
+
d5211c
+	return $OCF_SUCCESS
d5211c
+}
d5211c
+
d5211c
+if [ $# -ne 1 ]; then
d5211c
+	OSInfo_usage
d5211c
+	exit $OCF_ERR_ARGS
d5211c
+fi
d5211c
+
d5211c
+if [ x != x${OCF_RESKEY_delay} ]; then
d5211c
+	OCF_RESKEY_delay="-d ${OCF_RESKEY_delay}"
d5211c
+fi
d5211c
+
d5211c
+case $__OCF_ACTION in
d5211c
+meta-data)	meta_data
d5211c
+		exit $OCF_SUCCESS
d5211c
+		;;
d5211c
+start)		OSInfo_validate || exit $?
d5211c
+		OSInfo_start
d5211c
+		;;
d5211c
+stop)		OSInfo_stop
d5211c
+		;;
d5211c
+monitor)	OSInfo_monitor
d5211c
+		;;
d5211c
+validate-all)	OSInfo_validate
d5211c
+		;;
d5211c
+usage|help)	OSInfo_usage
d5211c
+		exit $OCF_SUCCESS
d5211c
+		;;
d5211c
+*)		OSInfo_usage
d5211c
+		exit $OCF_ERR_UNIMPLEMENTED
d5211c
+		;;
d5211c
+esac
d5211c
+
d5211c
+exit $?
d5211c
diff --color -uNr a/heartbeat/openstack-info.in b/heartbeat/openstack-info.in
d5211c
--- a/heartbeat/openstack-info.in	2022-03-15 16:14:29.370209063 +0100
d5211c
+++ b/heartbeat/openstack-info.in	2022-03-15 16:17:36.234840018 +0100
d5211c
@@ -32,16 +32,16 @@
d5211c
 : ${OCF_FUNCTIONS_DIR=${OCF_ROOT}/lib/heartbeat}
d5211c
 . ${OCF_FUNCTIONS_DIR}/ocf-shellfuncs
d5211c
 
d5211c
+. ${OCF_FUNCTIONS_DIR}/openstack-common.sh
d5211c
+
d5211c
 # Defaults
d5211c
 OCF_RESKEY_pidfile_default="$HA_RSCTMP/OSInfo-${OCF_RESOURCE_HOSTNAME}"
d5211c
 OCF_RESKEY_delay_default="0"
d5211c
 OCF_RESKEY_clone_default="0"
d5211c
 OCF_RESKEY_curlcli_default="/usr/bin/curl"
d5211c
-OCF_RESKEY_openstackcli_default="/usr/bin/openstack"
d5211c
 OCF_RESKEY_pythoncli_default="@PYTHON@"
d5211c
 
d5211c
 : ${OCF_RESKEY_curlcli=${OCF_RESKEY_curlcli_default}}
d5211c
-: ${OCF_RESKEY_openstackcli=${OCF_RESKEY_openstackcli_default}}
d5211c
 : ${OCF_RESKEY_pythoncli=${OCF_RESKEY_pythoncli_default}}
d5211c
 : ${OCF_RESKEY_pidfile=${OCF_RESKEY_pidfile_default}}
d5211c
 : ${OCF_RESKEY_delay=${OCF_RESKEY_delay_default}}
d5211c
@@ -70,25 +70,23 @@
d5211c
 <shortdesc lang="en">Records various node attributes in the CIB</shortdesc>
d5211c
 
d5211c
 <parameters>
d5211c
+END
d5211c
+
d5211c
+common_meta_data
d5211c
+
d5211c
+	cat <
d5211c
 <parameter name="pidfile" unique="0">
d5211c
 <longdesc lang="en">PID file</longdesc>
d5211c
 <shortdesc lang="en">PID file</shortdesc>
d5211c
 <content type="string" default="${OCF_RESKEY_pidfile_default}" />
d5211c
 </parameter>
d5211c
+
d5211c
 <parameter name="delay" unique="0">
d5211c
 <longdesc lang="en">Interval to allow values to stabilize</longdesc>
d5211c
 <shortdesc lang="en">Dampening Delay</shortdesc>
d5211c
 <content type="string" default="${OCF_RESKEY_delay_default}" />
d5211c
 </parameter>
d5211c
 
d5211c
-<parameter name="openrc" required="1">
d5211c
-<longdesc lang="en">
d5211c
-Valid Openstack credentials as openrc file from api_access/openrc.
d5211c
-</longdesc>
d5211c
-<shortdesc lang="en">openrc file</shortdesc>
d5211c
-<content type="string" />
d5211c
-</parameter>
d5211c
-
d5211c
 <parameter name="curlcli">
d5211c
 <longdesc lang="en">
d5211c
 Path to command line cURL binary.
d5211c
@@ -97,14 +95,6 @@
d5211c
 <content type="string" default="${OCF_RESKEY_curlcli_default}" />
d5211c
 </parameter>
d5211c
 
d5211c
-<parameter name="openstackcli">
d5211c
-<longdesc lang="en">
d5211c
-Path to command line tools for openstack.
d5211c
-</longdesc>
d5211c
-<shortdesc lang="en">Path to Openstack CLI tool</shortdesc>
d5211c
-<content type="string" default="${OCF_RESKEY_openstackcli_default}" />
d5211c
-</parameter>
d5211c
-
d5211c
 <parameter name="pythoncli">
d5211c
 <longdesc lang="en">
d5211c
 Path to command line Python interpreter.
d5211c
@@ -116,9 +106,9 @@
d5211c
 </parameters>
d5211c
 
d5211c
 <actions>
d5211c
-<action name="start"  timeout="20s" />
d5211c
-<action name="stop" timeout="20s" />
d5211c
-<action name="monitor" timeout="20s" interval="60s"/>
d5211c
+<action name="start"  timeout="180s" />
d5211c
+<action name="stop" timeout="180s" />
d5211c
+<action name="monitor" timeout="180s" interval="60s"/>
d5211c
 <action name="meta-data" timeout="5s" />
d5211c
 <action name="validate-all" timeout="20s" />
d5211c
 </actions>
d5211c
@@ -134,7 +124,7 @@
d5211c
 	local node
d5211c
 	local node_id
d5211c
 
d5211c
-	. $OCF_RESKEY_openrc
d5211c
+	get_config
d5211c
 
d5211c
 	# Nova data: server ID
d5211c
 	node_id=$($OCF_RESKEY_curlcli \
d5211c
@@ -244,16 +234,6 @@
d5211c
 	check_binary "$OCF_RESKEY_openstackcli"
d5211c
 	check_binary "$OCF_RESKEY_pythoncli"
d5211c
 
d5211c
-	if [ -z "$OCF_RESKEY_openrc" ]; then
d5211c
-		ocf_exit_reason "openrc parameter not set"
d5211c
-		return $OCF_ERR_CONFIGURED
d5211c
-	fi
d5211c
-
d5211c
-	if [ ! -f "$OCF_RESKEY_openrc" ] ; then
d5211c
-		ocf_exit_reason "openrc file not found"
d5211c
-		return $OCF_ERR_CONFIGURED
d5211c
-	fi
d5211c
-
d5211c
 	return $OCF_SUCCESS
d5211c
 }
d5211c
 
d5211c
diff --color -uNr a/heartbeat/openstack-virtual-ip b/heartbeat/openstack-virtual-ip
d5211c
--- a/heartbeat/openstack-virtual-ip	2022-03-15 16:14:29.370209063 +0100
d5211c
+++ b/heartbeat/openstack-virtual-ip	2022-03-15 16:17:36.235840021 +0100
d5211c
@@ -34,10 +34,9 @@
d5211c
 : ${OCF_FUNCTIONS_DIR=${OCF_ROOT}/lib/heartbeat}
d5211c
 . ${OCF_FUNCTIONS_DIR}/ocf-shellfuncs
d5211c
 
d5211c
-# Defaults
d5211c
-OCF_RESKEY_openstackcli_default="/usr/bin/openstack"
d5211c
+. ${OCF_FUNCTIONS_DIR}/openstack-common.sh
d5211c
 
d5211c
-: ${OCF_RESKEY_openstackcli=${OCF_RESKEY_openstackcli_default}}
d5211c
+# Defaults
d5211c
 
d5211c
 #######################################################################
d5211c
 
d5211c
@@ -68,22 +67,11 @@
d5211c
 <shortdesc lang="en">Move a virtual IP</shortdesc>
d5211c
 
d5211c
 <parameters>
d5211c
-<parameter name="openstackcli">
d5211c
-<longdesc lang="en">
d5211c
-Path to command line tools for openstack.
d5211c
-</longdesc>
d5211c
-<shortdesc lang="en">Path to Openstack CLI tool</shortdesc>
d5211c
-<content type="string" default="${OCF_RESKEY_openstackcli_default}" />
d5211c
-</parameter>
d5211c
+END
d5211c
 
d5211c
-<parameter name="openrc" required="1">
d5211c
-<longdesc lang="en">
d5211c
-Valid Openstack credentials as openrc file from api_access/openrc.
d5211c
-</longdesc>
d5211c
-<shortdesc lang="en">openrc file</shortdesc>
d5211c
-<content type="string" />
d5211c
-</parameter>
d5211c
+common_meta_data
d5211c
 
d5211c
+cat <
d5211c
 <parameter name="ip" required="1">
d5211c
 <longdesc lang="en">
d5211c
 Virtual IP Address.
d5211c
@@ -105,7 +93,7 @@
d5211c
 <actions>
d5211c
 <action name="start" timeout="180s" />
d5211c
 <action name="stop" timeout="180s" />
d5211c
-<action name="monitor" depth="0" timeout="30s" interval="60s" />
d5211c
+<action name="monitor" depth="0" timeout="180s" interval="60s" />
d5211c
 <action name="validate-all" timeout="5s" />
d5211c
 <action name="meta-data" timeout="5s" />
d5211c
 </actions>
d5211c
@@ -128,17 +116,7 @@
d5211c
 osvip_validate() {
d5211c
 	check_binary "$OCF_RESKEY_openstackcli"
d5211c
 
d5211c
-	if [ -z "$OCF_RESKEY_openrc" ]; then
d5211c
-		ocf_exit_reason "openrc parameter not set"
d5211c
-		return $OCF_ERR_CONFIGURED
d5211c
-	fi
d5211c
-
d5211c
-	if [ ! -f "$OCF_RESKEY_openrc" ] ; then
d5211c
-		ocf_exit_reason "openrc file not found"
d5211c
-		return $OCF_ERR_CONFIGURED
d5211c
-	fi
d5211c
-
d5211c
-	. $OCF_RESKEY_openrc
d5211c
+	get_config
d5211c
 
d5211c
 	${HA_SBIN_DIR}/attrd_updater --query -n openstack_ports -N $(crm_node -n) > /dev/null 2>&1
d5211c
 	if [ $? -ne 0 ] ; then