|
 |
6d0d52 |
From d9b46474fc19d9c57e2cfb752d60319017da8410 Mon Sep 17 00:00:00 2001
|
|
|
6d0d52 |
From: Oyvind Albrigtsen <oalbrigt@redhat.com>
|
|
|
6d0d52 |
Date: Wed, 6 Apr 2022 14:14:19 +0200
|
|
|
6d0d52 |
Subject: [PATCH] Filesystem: improve logic for UUID/label and add note that
|
|
|
6d0d52 |
/dev/disk/by-{uuid,label}/ are preferred on Linux
|
|
|
6d0d52 |
|
|
|
6d0d52 |
---
|
|
|
6d0d52 |
heartbeat/Filesystem | 8 +++++---
|
|
|
6d0d52 |
1 file changed, 5 insertions(+), 3 deletions(-)
|
|
|
6d0d52 |
|
|
|
6d0d52 |
diff --git a/heartbeat/Filesystem b/heartbeat/Filesystem
|
|
|
6d0d52 |
index 72a1b8623..44270ad98 100755
|
|
|
6d0d52 |
--- a/heartbeat/Filesystem
|
|
|
6d0d52 |
+++ b/heartbeat/Filesystem
|
|
|
6d0d52 |
@@ -163,6 +163,8 @@ directory where the status file is to be placed.
|
|
|
6d0d52 |
<parameter name="device" required="1">
|
|
|
6d0d52 |
<longdesc lang="en">
|
|
|
6d0d52 |
The name of block device for the filesystem, or -U, -L options for mount, or NFS mount specification.
|
|
|
6d0d52 |
+
|
|
|
6d0d52 |
+NOTE: On Linux /dev/disk/by-{uuid,label}/ are preferred to -U/-L.
|
|
|
6d0d52 |
</longdesc>
|
|
|
6d0d52 |
<shortdesc lang="en">block device</shortdesc>
|
|
|
6d0d52 |
<content type="string" default="${OCF_RESKEY_device_default}" />
|
|
|
6d0d52 |
@@ -902,11 +904,11 @@ set_blockdevice_var() {
|
|
|
6d0d52 |
fi
|
|
|
6d0d52 |
|
|
|
6d0d52 |
case "$DEVICE" in
|
|
|
6d0d52 |
- --*) # Typically --uuid or --label
|
|
|
6d0d52 |
- device_opt=$(echo $DEVICE | sed -E "s/([[:blank:]]|=).*//")
|
|
|
6d0d52 |
+ --uuid=*|--uuid\ *|--label=*|--label\ *)
|
|
|
6d0d52 |
+ device_opt=$(echo $DEVICE | sed "s/\([[:blank:]]\|=\).*//")
|
|
|
6d0d52 |
DEVICE=$(echo $DEVICE | sed -E "s/$device_opt([[:blank:]]*|=)//")
|
|
|
6d0d52 |
;;
|
|
|
6d0d52 |
- -*) # Oh... An option to mount instead... Typically -U or -L
|
|
|
6d0d52 |
+ -U*|-L*) # short versions of --uuid/--label
|
|
|
6d0d52 |
device_opt=$(echo $DEVICE | cut -c1-2)
|
|
|
6d0d52 |
DEVICE=$(echo $DEVICE | sed "s/$device_opt[[:blank:]]*//")
|
|
|
6d0d52 |
;;
|