|
 |
811adb |
From 14576f7ca02fb0abff188238ac019e88ab06e878 Mon Sep 17 00:00:00 2001
|
|
|
811adb |
From: Oyvind Albrigtsen <oalbrigt@redhat.com>
|
|
|
811adb |
Date: Tue, 9 Nov 2021 11:49:36 +0100
|
|
|
811adb |
Subject: [PATCH] gcp-ilb: only check if log_cmd binary is available if
|
|
|
811adb |
log_enable is true
|
|
|
811adb |
|
|
|
811adb |
---
|
|
|
811adb |
heartbeat/gcp-ilb | 9 +++++----
|
|
|
811adb |
1 file changed, 5 insertions(+), 4 deletions(-)
|
|
|
811adb |
|
|
|
811adb |
diff --git a/heartbeat/gcp-ilb b/heartbeat/gcp-ilb
|
|
|
811adb |
index 48dc3ac4e..f84f373b7 100755
|
|
|
811adb |
--- a/heartbeat/gcp-ilb
|
|
|
811adb |
+++ b/heartbeat/gcp-ilb
|
|
|
811adb |
@@ -37,7 +37,7 @@ if type "socat" > /dev/null 2>&1; then
|
|
|
811adb |
OCF_RESKEY_cat_default="socat"
|
|
|
811adb |
else
|
|
|
811adb |
OCF_RESKEY_cat_default="nc"
|
|
|
811adb |
-fi;
|
|
|
811adb |
+fi
|
|
|
811adb |
|
|
|
811adb |
|
|
|
811adb |
: ${OCF_RESKEY_cat=${OCF_RESKEY_cat_default}}
|
|
|
811adb |
@@ -53,7 +53,7 @@ pidfile="/var/run/$OCF_RESOURCE_INSTANCE.pid"
|
|
|
811adb |
|
|
|
811adb |
|
|
|
811adb |
#Validate command for logging
|
|
|
811adb |
-if [ $OCF_RESKEY_log_enable = "true" ]; then
|
|
|
811adb |
+if ocf_is_true "$OCF_RESKEY_log_enable"; then
|
|
|
811adb |
if type $OCF_RESKEY_log_cmd > /dev/null 2>&1; then
|
|
|
811adb |
logging_cmd="$OCF_RESKEY_log_cmd $OCF_RESKEY_log_params"
|
|
|
811adb |
ocf_log debug "Logging command is: \'$logging_cmd\' "
|
|
|
811adb |
@@ -61,7 +61,7 @@ if [ $OCF_RESKEY_log_enable = "true" ]; then
|
|
|
811adb |
OCF_RESKEY_log_enable="false"
|
|
|
811adb |
ocf_log err "\'$logging_cmd\' is invalid. External logging disabled."
|
|
|
811adb |
|
|
|
811adb |
- fi;
|
|
|
811adb |
+ fi
|
|
|
811adb |
fi
|
|
|
811adb |
|
|
|
811adb |
|
|
|
811adb |
@@ -285,7 +285,8 @@ ilb_stop() {
|
|
|
811adb |
|
|
|
811adb |
ilb_validate() {
|
|
|
811adb |
check_binary "$OCF_RESKEY_cat"
|
|
|
811adb |
- check_binary "$OCF_RESKEY_log_cmd"
|
|
|
811adb |
+
|
|
|
811adb |
+ ocf_is_true "$OCF_RESKEY_log_enable" && check_binary "$OCF_RESKEY_log_cmd"
|
|
|
811adb |
|
|
|
811adb |
if ! ocf_is_decimal "$OCF_RESKEY_port"; then
|
|
|
811adb |
ocf_exit_reason "$OCF_RESKEY_port is not a valid port"
|