Blame SOURCES/bz1908146-bz1908147-bz1908148-bz1949114-update-openstack-agents.patch

f065e8
diff --color -uNr a/heartbeat/Makefile.am b/heartbeat/Makefile.am
f065e8
--- a/heartbeat/Makefile.am	2022-03-15 16:14:29.355209012 +0100
f065e8
+++ b/heartbeat/Makefile.am	2022-03-15 16:18:35.917048467 +0100
f065e8
@@ -217,6 +217,7 @@
f065e8
 			  lvm-clvm.sh		\
f065e8
 			  lvm-plain.sh		\
f065e8
 			  lvm-tag.sh		\
f065e8
+			  openstack-common.sh	\
f065e8
 			  ora-common.sh		\
f065e8
 			  mysql-common.sh	\
f065e8
 			  nfsserver-redhat.sh	\
f065e8
diff --color -uNr a/heartbeat/openstack-cinder-volume b/heartbeat/openstack-cinder-volume
f065e8
--- a/heartbeat/openstack-cinder-volume	2022-03-15 16:14:29.370209063 +0100
f065e8
+++ b/heartbeat/openstack-cinder-volume	2022-03-15 16:17:36.231840008 +0100
f065e8
@@ -34,11 +34,11 @@
f065e8
 : ${OCF_FUNCTIONS_DIR=${OCF_ROOT}/lib/heartbeat}
f065e8
 . ${OCF_FUNCTIONS_DIR}/ocf-shellfuncs
f065e8
 
f065e8
+. ${OCF_FUNCTIONS_DIR}/openstack-common.sh
f065e8
+
f065e8
 # Defaults
f065e8
-OCF_RESKEY_openstackcli_default="/usr/bin/openstack"
f065e8
 OCF_RESKEY_volume_local_check_default="true"
f065e8
 
f065e8
-: ${OCF_RESKEY_openstackcli=${OCF_RESKEY_openstackcli_default}}
f065e8
 : ${OCF_RESKEY_volume_local_check=${OCF_RESKEY_volume_local_check_default}}
f065e8
 
f065e8
 #######################################################################
f065e8
@@ -68,14 +68,11 @@
f065e8
 <shortdesc lang="en">Attach a cinder volume</shortdesc>
f065e8
 
f065e8
 <parameters>
f065e8
-<parameter name="openstackcli">
f065e8
-<longdesc lang="en">
f065e8
-Path to command line tools for openstack.
f065e8
-</longdesc>
f065e8
-<shortdesc lang="en">Path to Openstack CLI tool</shortdesc>
f065e8
-<content type="string" default="${OCF_RESKEY_openstackcli_default}" />
f065e8
-</parameter>
f065e8
+END
f065e8
 
f065e8
+common_meta_data
f065e8
+
f065e8
+cat <
f065e8
 <parameter name="volume_local_check">
f065e8
 <longdesc lang="en">
f065e8
 This option allows the cluster to monitor the cinder volume presence without 
f065e8
@@ -85,28 +82,19 @@
f065e8
 <content type="boolean" default="${OCF_RESKEY_volume_local_check_default}" />
f065e8
 </parameter>
f065e8
 
f065e8
-<parameter name="openrc" required="1">
f065e8
-<longdesc lang="en">
f065e8
-Valid Openstack credentials as openrc file from api_access/openrc.
f065e8
-</longdesc>
f065e8
-<shortdesc lang="en">openrc file</shortdesc>
f065e8
-<content type="string" />
f065e8
-</parameter>
f065e8
-
f065e8
 <parameter name="volume_id" required="1">
f065e8
 <longdesc lang="en">
f065e8
-Cinder volume identifier to use to attach the bloc storage.
f065e8
+Cinder volume identifier to use to attach the block storage.
f065e8
 </longdesc>
f065e8
 <shortdesc lang="en">Volume ID</shortdesc>
f065e8
 <content type="string" />
f065e8
 </parameter>
f065e8
-
f065e8
 </parameters>
f065e8
 
f065e8
 <actions>
f065e8
 <action name="start" timeout="180s" />
f065e8
 <action name="stop" timeout="180s" />
f065e8
-<action name="monitor" depth="0" timeout="30s" interval="60s" />
f065e8
+<action name="monitor" depth="0" timeout="180s" interval="60s" />
f065e8
 <action name="validate-all" timeout="5s" />
f065e8
 <action name="meta-data" timeout="5s" />
f065e8
 </actions>
f065e8
@@ -127,17 +115,7 @@
f065e8
 osvol_validate() {
f065e8
 	check_binary "$OCF_RESKEY_openstackcli"
f065e8
 	
f065e8
-	if [ -z "$OCF_RESKEY_openrc" ]; then
f065e8
-		ocf_exit_reason "openrc parameter not set"
f065e8
-		return $OCF_ERR_CONFIGURED
f065e8
-	fi
f065e8
-
f065e8
-	if [ ! -f "$OCF_RESKEY_openrc" ] ; then
f065e8
-		ocf_exit_reason "openrc file not found"
f065e8
-		return $OCF_ERR_CONFIGURED
f065e8
-	fi
f065e8
-
f065e8
-	. $OCF_RESKEY_openrc
f065e8
+	get_config
f065e8
 
f065e8
 	if ! $OCF_RESKEY_openstackcli volume list|grep -q $OCF_RESKEY_volume_id ; then
f065e8
 		ocf_exit_reason "volume-id $OCF_RESKEY_volume_id not found"
f065e8
diff --color -uNr a/heartbeat/openstack-common.sh b/heartbeat/openstack-common.sh
f065e8
--- a/heartbeat/openstack-common.sh	1970-01-01 01:00:00.000000000 +0100
f065e8
+++ b/heartbeat/openstack-common.sh	2022-03-15 16:17:36.232840011 +0100
f065e8
@@ -0,0 +1,147 @@
f065e8
+OCF_RESKEY_openstackcli_default="/usr/bin/openstack"
f065e8
+OCF_RESKEY_insecure_default="false"
f065e8
+
f065e8
+: ${OCF_RESKEY_openstackcli=${OCF_RESKEY_openstackcli_default}}
f065e8
+: ${OCF_RESKEY_insecure=${OCF_RESKEY_insecure_default}}
f065e8
+
f065e8
+if ocf_is_true "${OCF_RESKEY_insecure}"; then
f065e8
+	OCF_RESKEY_openstackcli="${OCF_RESKEY_openstackcli} --insecure"
f065e8
+fi
f065e8
+
f065e8
+common_meta_data() {
f065e8
+	cat <
f065e8
+
f065e8
+<parameter name="cloud" required="0">
f065e8
+<longdesc lang="en">
f065e8
+Openstack cloud (from ~/.config/openstack/clouds.yaml or /etc/openstack/clouds.yaml).
f065e8
+</longdesc>
f065e8
+<shortdesc lang="en">Cloud from clouds.yaml</shortdesc>
f065e8
+<content type="string" />
f065e8
+</parameter>
f065e8
+
f065e8
+<parameter name="openrc" required="0">
f065e8
+<longdesc lang="en">
f065e8
+Openstack credentials as openrc file from api_access/openrc.
f065e8
+</longdesc>
f065e8
+<shortdesc lang="en">openrc file</shortdesc>
f065e8
+<content type="string" />
f065e8
+</parameter>
f065e8
+
f065e8
+<parameter name="auth_url" required="0">
f065e8
+<longdesc lang="en">
f065e8
+Keystone Auth URL
f065e8
+</longdesc>
f065e8
+<shortdesc lang="en">Keystone Auth URL</shortdesc>
f065e8
+<content type="string" />
f065e8
+</parameter>
f065e8
+
f065e8
+<parameter name="username" required="0">
f065e8
+<longdesc lang="en">
f065e8
+Username.
f065e8
+</longdesc>
f065e8
+<shortdesc lang="en">Username</shortdesc>
f065e8
+<content type="string" />
f065e8
+</parameter>
f065e8
+
f065e8
+<parameter name="password" required="0">
f065e8
+<longdesc lang="en">
f065e8
+Password.
f065e8
+</longdesc>
f065e8
+<shortdesc lang="en">Password</shortdesc>
f065e8
+<content type="string" />
f065e8
+</parameter>
f065e8
+
f065e8
+<parameter name="project_name" required="0">
f065e8
+<longdesc lang="en">
f065e8
+Keystone Project.
f065e8
+</longdesc>
f065e8
+<shortdesc lang="en">Keystone Project</shortdesc>
f065e8
+<content type="string" />
f065e8
+</parameter>
f065e8
+
f065e8
+<parameter name="user_domain_name" required="0">
f065e8
+<longdesc lang="en">
f065e8
+Keystone User Domain Name.
f065e8
+</longdesc>
f065e8
+<shortdesc lang="en">Keystone User Domain Name</shortdesc>
f065e8
+<content type="string" />
f065e8
+</parameter>
f065e8
+
f065e8
+<parameter name="project_domain_name" required="0">
f065e8
+<longdesc lang="en">
f065e8
+Keystone Project Domain Name.
f065e8
+</longdesc>
f065e8
+<shortdesc lang="en">Keystone Project Domain Name</shortdesc>
f065e8
+<content type="string" />
f065e8
+</parameter>
f065e8
+
f065e8
+<parameter name="openstackcli">
f065e8
+<longdesc lang="en">
f065e8
+Path to command line tools for openstack.
f065e8
+</longdesc>
f065e8
+<shortdesc lang="en">Path to Openstack CLI tool</shortdesc>
f065e8
+<content type="string" default="${OCF_RESKEY_openstackcli_default}" />
f065e8
+</parameter>
f065e8
+
f065e8
+<parameter name="insecure">
f065e8
+<longdesc lang="en">
f065e8
+Allow insecure connections
f065e8
+</longdesc>
f065e8
+<shortdesc lang="en">Allow insecure connections</shortdesc>
f065e8
+<content type="boolean" default="${OCF_RESKEY_insecure_default}" />
f065e8
+</parameter>
f065e8
+END
f065e8
+}
f065e8
+
f065e8
+get_config() {
f065e8
+	if [ -n "$OCF_RESKEY_cloud" ]; then
f065e8
+		TILDE=$(echo ~)
f065e8
+		clouds_yaml="$TILDE/.config/openstack/clouds.yaml"
f065e8
+		if [ ! -f "$clouds_yaml" ]; then
f065e8
+			clouds_yaml="/etc/openstack/clouds.yaml"
f065e8
+		fi
f065e8
+		if [ ! -f "$clouds_yaml" ]; then
f065e8
+			ocf_exit_reason "~/.config/openstack/clouds.yaml and /etc/openstack/clouds.yaml does not exist"
f065e8
+			exit $OCF_ERR_CONFIGURED
f065e8
+		fi
f065e8
+		OCF_RESKEY_openstackcli="${OCF_RESKEY_openstackcli} --os-cloud $OCF_RESKEY_cloud"
f065e8
+	elif [ -n "$OCF_RESKEY_openrc" ]; then
f065e8
+		if [ ! -f "$OCF_RESKEY_openrc" ]; then
f065e8
+			ocf_exit_reason "$OCF_RESKEY_openrc does not exist"
f065e8
+			exit $OCF_ERR_CONFIGURED
f065e8
+		fi
f065e8
+		. $OCF_RESKEY_openrc
f065e8
+	else
f065e8
+		if [ -z "$OCF_RESKEY_auth_url" ]; then
f065e8
+			ocf_exit_reason "auth_url not set"
f065e8
+			exit $OCF_ERR_CONFIGURED
f065e8
+		fi
f065e8
+		if [ -z "$OCF_RESKEY_username" ]; then
f065e8
+			ocf_exit_reason "username not set"
f065e8
+			exit $OCF_ERR_CONFIGURED
f065e8
+		fi
f065e8
+		if [ -z "$OCF_RESKEY_password" ]; then
f065e8
+			ocf_exit_reason "password not set"
f065e8
+			exit $OCF_ERR_CONFIGURED
f065e8
+		fi
f065e8
+		if [ -z "$OCF_RESKEY_project_name" ]; then
f065e8
+			ocf_exit_reason "project_name not set"
f065e8
+			exit $OCF_ERR_CONFIGURED
f065e8
+		fi
f065e8
+		if [ -z "$OCF_RESKEY_user_domain_name" ]; then
f065e8
+			ocf_exit_reason "user_domain_name not set"
f065e8
+			exit $OCF_ERR_CONFIGURED
f065e8
+		fi
f065e8
+		if [ -z "$OCF_RESKEY_project_domain_name" ]; then
f065e8
+			ocf_exit_reason " not set"
f065e8
+			exit $OCF_ERR_CONFIGURED
f065e8
+		fi
f065e8
+
f065e8
+		OCF_RESKEY_openstackcli="${OCF_RESKEY_openstackcli} --os-auth-url $OCF_RESKEY_auth_url"
f065e8
+		OCF_RESKEY_openstackcli="${OCF_RESKEY_openstackcli} --os-username $OCF_RESKEY_username"
f065e8
+		OCF_RESKEY_openstackcli="${OCF_RESKEY_openstackcli} --os-password $OCF_RESKEY_password"
f065e8
+		OCF_RESKEY_openstackcli="${OCF_RESKEY_openstackcli} --os-project-name $OCF_RESKEY_project_name"
f065e8
+		OCF_RESKEY_openstackcli="${OCF_RESKEY_openstackcli} --os-user-domain-name $OCF_RESKEY_user_domain_name"
f065e8
+		OCF_RESKEY_openstackcli="${OCF_RESKEY_openstackcli} --os-project-domain-name $OCF_RESKEY_project_domain_name"
f065e8
+	fi
f065e8
+}
f065e8
diff --color -uNr a/heartbeat/openstack-floating-ip b/heartbeat/openstack-floating-ip
f065e8
--- a/heartbeat/openstack-floating-ip	2022-03-15 16:14:29.370209063 +0100
f065e8
+++ b/heartbeat/openstack-floating-ip	2022-03-15 16:17:36.233840014 +0100
f065e8
@@ -34,10 +34,9 @@
f065e8
 : ${OCF_FUNCTIONS_DIR=${OCF_ROOT}/lib/heartbeat}
f065e8
 . ${OCF_FUNCTIONS_DIR}/ocf-shellfuncs
f065e8
 
f065e8
-# Defaults
f065e8
-OCF_RESKEY_openstackcli_default="/usr/bin/openstack"
f065e8
+. ${OCF_FUNCTIONS_DIR}/openstack-common.sh
f065e8
 
f065e8
-: ${OCF_RESKEY_openstackcli=${OCF_RESKEY_openstackcli_default}}
f065e8
+# Defaults
f065e8
 
f065e8
 #######################################################################
f065e8
 
f065e8
@@ -67,22 +66,11 @@
f065e8
 <shortdesc lang="en">Move a floating IP</shortdesc>
f065e8
 
f065e8
 <parameters>
f065e8
-<parameter name="openstackcli">
f065e8
-<longdesc lang="en">
f065e8
-Path to command line tools for openstack.
f065e8
-</longdesc>
f065e8
-<shortdesc lang="en">Path to Openstack CLI tool</shortdesc>
f065e8
-<content type="string" default="${OCF_RESKEY_openstackcli_default}" />
f065e8
-</parameter>
f065e8
+END
f065e8
 
f065e8
-<parameter name="openrc" required="1">
f065e8
-<longdesc lang="en">
f065e8
-Valid Openstack credentials as openrc file from api_access/openrc.
f065e8
-</longdesc>
f065e8
-<shortdesc lang="en">openrc file</shortdesc>
f065e8
-<content type="string" />
f065e8
-</parameter>
f065e8
+common_meta_data
f065e8
 
f065e8
+cat <
f065e8
 <parameter name="ip_id" required="1">
f065e8
 <longdesc lang="en">
f065e8
 Floating IP Identifier.
f065e8
@@ -104,7 +92,7 @@
f065e8
 <actions>
f065e8
 <action name="start" timeout="180s" />
f065e8
 <action name="stop" timeout="180s" />
f065e8
-<action name="monitor" depth="0" timeout="30s" interval="60s" />
f065e8
+<action name="monitor" depth="0" timeout="180s" interval="60s" />
f065e8
 <action name="validate-all" timeout="5s" />
f065e8
 <action name="meta-data" timeout="5s" />
f065e8
 </actions>
f065e8
@@ -115,17 +103,7 @@
f065e8
 osflip_validate() {
f065e8
 	check_binary "$OCF_RESKEY_openstackcli"
f065e8
 
f065e8
-	if [ -z "$OCF_RESKEY_openrc" ]; then
f065e8
-		ocf_exit_reason "openrc parameter not set"
f065e8
-		return $OCF_ERR_CONFIGURED
f065e8
-	fi
f065e8
-
f065e8
-	if [ ! -f "$OCF_RESKEY_openrc" ] ; then
f065e8
-		ocf_exit_reason "openrc file not found"
f065e8
-		return $OCF_ERR_CONFIGURED
f065e8
-	fi
f065e8
-
f065e8
-	. $OCF_RESKEY_openrc
f065e8
+	get_config
f065e8
 
f065e8
 	if ! $OCF_RESKEY_openstackcli floating ip list|grep -q $OCF_RESKEY_ip_id ; then
f065e8
 		ocf_exit_reason "ip-id $OCF_RESKEY_ip_id not found"
f065e8
diff --color -uNr a/heartbeat/openstack-info b/heartbeat/openstack-info
f065e8
--- a/heartbeat/openstack-info	1970-01-01 01:00:00.000000000 +0100
f065e8
+++ b/heartbeat/openstack-info	2022-03-15 16:17:36.234840018 +0100
f065e8
@@ -0,0 +1,270 @@
f065e8
+#!/bin/sh
f065e8
+#
f065e8
+#
f065e8
+# OCF resource agent to set attributes from Openstack instance details.
f065e8
+# It records (in the CIB) various attributes of a node
f065e8
+#
f065e8
+# Copyright (c) 2018 Mathieu Grzybek
f065e8
+#          All Rights Reserved.
f065e8
+#
f065e8
+# This program is free software; you can redistribute it and/or modify
f065e8
+# it under the terms of version 2 of the GNU General Public License as
f065e8
+# published by the Free Software Foundation.
f065e8
+#
f065e8
+# This program is distributed in the hope that it would be useful, but
f065e8
+# WITHOUT ANY WARRANTY; without even the implied warranty of
f065e8
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
f065e8
+#
f065e8
+# Further, this software is distributed without any warranty that it is
f065e8
+# free of the rightful claim of any third person regarding infringement
f065e8
+# or the like. Any license provided herein, whether implied or
f065e8
+# otherwise, applies only to this software file. Patent licenses, if
f065e8
+# any, provided herein do not apply to combinations of this program with
f065e8
+# other software, or any other product whatsoever.
f065e8
+#
f065e8
+# You should have received a copy of the GNU General Public License
f065e8
+# along with this program; if not, write the Free Software Foundation,
f065e8
+# Inc., 59 Temple Place - Suite 330, Boston MA 02111-1307, USA.
f065e8
+#
f065e8
+#######################################################################
f065e8
+# Initialization:
f065e8
+
f065e8
+: ${OCF_FUNCTIONS_DIR=${OCF_ROOT}/lib/heartbeat}
f065e8
+. ${OCF_FUNCTIONS_DIR}/ocf-shellfuncs
f065e8
+
f065e8
+. ${OCF_FUNCTIONS_DIR}/openstack-common.sh
f065e8
+
f065e8
+# Defaults
f065e8
+OCF_RESKEY_pidfile_default="$HA_RSCTMP/OSInfo-${OCF_RESOURCE_HOSTNAME}"
f065e8
+OCF_RESKEY_delay_default="0"
f065e8
+OCF_RESKEY_clone_default="0"
f065e8
+OCF_RESKEY_curlcli_default="/usr/bin/curl"
f065e8
+OCF_RESKEY_pythoncli_default="/usr/bin/python"
f065e8
+
f065e8
+: ${OCF_RESKEY_curlcli=${OCF_RESKEY_curlcli_default}}
f065e8
+: ${OCF_RESKEY_pythoncli=${OCF_RESKEY_pythoncli_default}}
f065e8
+: ${OCF_RESKEY_pidfile=${OCF_RESKEY_pidfile_default}}
f065e8
+: ${OCF_RESKEY_delay=${OCF_RESKEY_delay_default}}
f065e8
+: ${OCF_RESKEY_clone=${OCF_RESKEY_clone_default}}
f065e8
+
f065e8
+#######################################################################
f065e8
+
f065e8
+meta_data() {
f065e8
+	cat <
f065e8
+
f065e8
+
f065e8
+<resource-agent name="openstack-info" version="1.0">
f065e8
+<version>1.0</version>
f065e8
+
f065e8
+<longdesc lang="en">
f065e8
+OCF resource agent to set attributes from Openstack instance details.
f065e8
+It records (in the CIB) various attributes of a node.
f065e8
+Sample output:
f065e8
+	openstack_az      : nova
f065e8
+	openstack_flavor  : c1.small
f065e8
+	openstack_id      : 60ac4343-5828-49b1-8aac-7c69b1417f31
f065e8
+	openstack_ports   : 7960d889-9750-4160-bf41-c69a41ad72d9:96530d18-57a3-4718-af32-30f2a74c22a2,b0e55a06-bd75-468d-8baa-22cfeb65799f:a55ae917-8016-4b1e-8ffa-04311b9dc7d6
f065e8
+
f065e8
+The layout of openstack_ports is a comma-separated list of tuples "subnet_id:port_id".
f065e8
+</longdesc>
f065e8
+<shortdesc lang="en">Records various node attributes in the CIB</shortdesc>
f065e8
+
f065e8
+<parameters>
f065e8
+END
f065e8
+
f065e8
+common_meta_data
f065e8
+
f065e8
+	cat <
f065e8
+<parameter name="pidfile" unique="0">
f065e8
+<longdesc lang="en">PID file</longdesc>
f065e8
+<shortdesc lang="en">PID file</shortdesc>
f065e8
+<content type="string" default="${OCF_RESKEY_pidfile_default}" />
f065e8
+</parameter>
f065e8
+
f065e8
+<parameter name="delay" unique="0">
f065e8
+<longdesc lang="en">Interval to allow values to stabilize</longdesc>
f065e8
+<shortdesc lang="en">Dampening Delay</shortdesc>
f065e8
+<content type="string" default="${OCF_RESKEY_delay_default}" />
f065e8
+</parameter>
f065e8
+
f065e8
+<parameter name="curlcli">
f065e8
+<longdesc lang="en">
f065e8
+Path to command line cURL binary.
f065e8
+</longdesc>
f065e8
+<shortdesc lang="en">Path to cURL binary</shortdesc>
f065e8
+<content type="string" default="${OCF_RESKEY_curlcli_default}" />
f065e8
+</parameter>
f065e8
+
f065e8
+<parameter name="pythoncli">
f065e8
+<longdesc lang="en">
f065e8
+Path to command line Python interpreter.
f065e8
+</longdesc>
f065e8
+<shortdesc lang="en">Path to Python interpreter</shortdesc>
f065e8
+<content type="string" default="${OCF_RESKEY_pythoncli_default}" />
f065e8
+</parameter>
f065e8
+
f065e8
+</parameters>
f065e8
+
f065e8
+<actions>
f065e8
+<action name="start"  timeout="180s" />
f065e8
+<action name="stop" timeout="180s" />
f065e8
+<action name="monitor" timeout="30s" interval="60s"/>
f065e8
+<action name="meta-data" timeout="5s" />
f065e8
+<action name="validate-all" timeout="20s" />
f065e8
+</actions>
f065e8
+</resource-agent>
f065e8
+END
f065e8
+}
f065e8
+
f065e8
+#######################################################################
f065e8
+
f065e8
+OSInfoStats() {
f065e8
+	local result
f065e8
+	local value
f065e8
+	local node
f065e8
+	local node_id
f065e8
+
f065e8
+	get_config
f065e8
+
f065e8
+	# Nova data: server ID
f065e8
+	node_id=$($OCF_RESKEY_curlcli \
f065e8
+		-s http://169.254.169.254/openstack/latest/meta_data.json |
f065e8
+		$OCF_RESKEY_pythoncli -m json.tool |
f065e8
+		grep -P '\"uuid\": \".*\",$' |
f065e8
+		grep -P -o '[0-9a-f]{8}-([0-9a-f]{4}-){3}[0-9a-f]{12}')
f065e8
+
f065e8
+	if [ $? -ne 0 ] ; then
f065e8
+		ocf_exit_reason "Cannot find server ID"
f065e8
+		exit $OCF_ERR_GENERIC
f065e8
+	fi
f065e8
+
f065e8
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -n openstack_id -v "$node_id"
f065e8
+
f065e8
+	# Nova data: flavor
f065e8
+	value=$($OCF_RESKEY_openstackcli server show \
f065e8
+		--format value \
f065e8
+		--column flavor \
f065e8
+		$node_id)
f065e8
+
f065e8
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -n openstack_flavor -v "$value"
f065e8
+
f065e8
+	# Nova data: availability zone
f065e8
+	value=$($OCF_RESKEY_openstackcli server show \
f065e8
+		--format value \
f065e8
+		--column OS-EXT-AZ:availability_zone \
f065e8
+		$node_id)
f065e8
+
f065e8
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -n openstack_az -v "$value"
f065e8
+
f065e8
+	# Network data: ports
f065e8
+	value=""
f065e8
+	for port_id in $($OCF_RESKEY_openstackcli port list \
f065e8
+		--format value \
f065e8
+		--column id \
f065e8
+		--server $node_id); do
f065e8
+		subnet_id=$($OCF_RESKEY_openstackcli port show \
f065e8
+			--format json \
f065e8
+			--column fixed_ips \
f065e8
+			${port_id} | grep -P '\"subnet_id\": \".*\",$' |
f065e8
+			grep -P -o '[0-9a-f]{8}-([0-9a-f]{4}-){3}[0-9a-f]{12}')
f065e8
+		value+="${subnet_id}:${port_id},"
f065e8
+	done
f065e8
+	value=$(echo ${value} | sed -e 's/,$//g')
f065e8
+
f065e8
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -n openstack_ports -v "$value"
f065e8
+
f065e8
+	if [ ! -z "$OS_REGION_NAME" ] ; then
f065e8
+		${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -n openstack_region -v "$OS_REGION_NAME"
f065e8
+	fi
f065e8
+
f065e8
+	if [ ! -z "$OS_TENANT_ID" ] ; then
f065e8
+		${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -n openstack_tenant_id -v "$OS_TENANT_ID"
f065e8
+
f065e8
+		if [ ! -z "$OS_TENANT_NAME" ] ; then
f065e8
+			${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -n openstack_tenant_name -v "$OS_TENANT_NAME"
f065e8
+		fi
f065e8
+	else
f065e8
+		${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -n openstack_project_id -v "$OS_PROJECT_ID"
f065e8
+
f065e8
+		if [ ! -z "$OS_PROJECT_NAME" ] ; then
f065e8
+			${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -n openstack_project_name -v "$OS_PROJECT_NAME"
f065e8
+		fi
f065e8
+	fi
f065e8
+
f065e8
+}
f065e8
+
f065e8
+OSInfo_usage() {
f065e8
+	cat <
f065e8
+usage: $0 {start|stop|monitor|validate-all|meta-data}
f065e8
+
f065e8
+Expects to have a fully populated OCF RA-compliant environment set.
f065e8
+END
f065e8
+}
f065e8
+
f065e8
+OSInfo_start() {
f065e8
+	echo $OCF_RESKEY_clone > $OCF_RESKEY_pidfile
f065e8
+	OSInfoStats
f065e8
+	exit $OCF_SUCCESS
f065e8
+}
f065e8
+
f065e8
+OSInfo_stop() {
f065e8
+	rm -f $OCF_RESKEY_pidfile
f065e8
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -D -n openstack_id
f065e8
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -D -n openstack_flavor
f065e8
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -D -n openstack_az
f065e8
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -D -n openstack_ports
f065e8
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -D -n openstack_region
f065e8
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -D -n openstack_tenant_id
f065e8
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -D -n openstack_tenant_name
f065e8
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -D -n openstack_project_id
f065e8
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -D -n openstack_project_name
f065e8
+	exit $OCF_SUCCESS
f065e8
+}
f065e8
+
f065e8
+OSInfo_monitor() {
f065e8
+	if [ -f "$OCF_RESKEY_pidfile" ] ; then
f065e8
+		OSInfoStats
f065e8
+		exit $OCF_RUNNING
f065e8
+	fi
f065e8
+	exit $OCF_NOT_RUNNING
f065e8
+}
f065e8
+
f065e8
+OSInfo_validate() {
f065e8
+	check_binary "$OCF_RESKEY_curlcli"
f065e8
+	check_binary "$OCF_RESKEY_openstackcli"
f065e8
+	check_binary "$OCF_RESKEY_pythoncli"
f065e8
+
f065e8
+	return $OCF_SUCCESS
f065e8
+}
f065e8
+
f065e8
+if [ $# -ne 1 ]; then
f065e8
+	OSInfo_usage
f065e8
+	exit $OCF_ERR_ARGS
f065e8
+fi
f065e8
+
f065e8
+if [ x != x${OCF_RESKEY_delay} ]; then
f065e8
+	OCF_RESKEY_delay="-d ${OCF_RESKEY_delay}"
f065e8
+fi
f065e8
+
f065e8
+case $__OCF_ACTION in
f065e8
+meta-data)	meta_data
f065e8
+		exit $OCF_SUCCESS
f065e8
+		;;
f065e8
+start)		OSInfo_validate || exit $?
f065e8
+		OSInfo_start
f065e8
+		;;
f065e8
+stop)		OSInfo_stop
f065e8
+		;;
f065e8
+monitor)	OSInfo_monitor
f065e8
+		;;
f065e8
+validate-all)	OSInfo_validate
f065e8
+		;;
f065e8
+usage|help)	OSInfo_usage
f065e8
+		exit $OCF_SUCCESS
f065e8
+		;;
f065e8
+*)		OSInfo_usage
f065e8
+		exit $OCF_ERR_UNIMPLEMENTED
f065e8
+		;;
f065e8
+esac
f065e8
+
f065e8
+exit $?
f065e8
diff --color -uNr a/heartbeat/openstack-info.in b/heartbeat/openstack-info.in
f065e8
--- a/heartbeat/openstack-info.in	2022-03-15 16:14:29.370209063 +0100
f065e8
+++ b/heartbeat/openstack-info.in	2022-03-15 16:17:36.234840018 +0100
f065e8
@@ -32,16 +32,16 @@
f065e8
 : ${OCF_FUNCTIONS_DIR=${OCF_ROOT}/lib/heartbeat}
f065e8
 . ${OCF_FUNCTIONS_DIR}/ocf-shellfuncs
f065e8
 
f065e8
+. ${OCF_FUNCTIONS_DIR}/openstack-common.sh
f065e8
+
f065e8
 # Defaults
f065e8
 OCF_RESKEY_pidfile_default="$HA_RSCTMP/OSInfo-${OCF_RESOURCE_HOSTNAME}"
f065e8
 OCF_RESKEY_delay_default="0"
f065e8
 OCF_RESKEY_clone_default="0"
f065e8
 OCF_RESKEY_curlcli_default="/usr/bin/curl"
f065e8
-OCF_RESKEY_openstackcli_default="/usr/bin/openstack"
f065e8
 OCF_RESKEY_pythoncli_default="@PYTHON@"
f065e8
 
f065e8
 : ${OCF_RESKEY_curlcli=${OCF_RESKEY_curlcli_default}}
f065e8
-: ${OCF_RESKEY_openstackcli=${OCF_RESKEY_openstackcli_default}}
f065e8
 : ${OCF_RESKEY_pythoncli=${OCF_RESKEY_pythoncli_default}}
f065e8
 : ${OCF_RESKEY_pidfile=${OCF_RESKEY_pidfile_default}}
f065e8
 : ${OCF_RESKEY_delay=${OCF_RESKEY_delay_default}}
f065e8
@@ -70,25 +70,23 @@
f065e8
 <shortdesc lang="en">Records various node attributes in the CIB</shortdesc>
f065e8
 
f065e8
 <parameters>
f065e8
+END
f065e8
+
f065e8
+common_meta_data
f065e8
+
f065e8
+	cat <
f065e8
 <parameter name="pidfile" unique="0">
f065e8
 <longdesc lang="en">PID file</longdesc>
f065e8
 <shortdesc lang="en">PID file</shortdesc>
f065e8
 <content type="string" default="${OCF_RESKEY_pidfile_default}" />
f065e8
 </parameter>
f065e8
+
f065e8
 <parameter name="delay" unique="0">
f065e8
 <longdesc lang="en">Interval to allow values to stabilize</longdesc>
f065e8
 <shortdesc lang="en">Dampening Delay</shortdesc>
f065e8
 <content type="string" default="${OCF_RESKEY_delay_default}" />
f065e8
 </parameter>
f065e8
 
f065e8
-<parameter name="openrc" required="1">
f065e8
-<longdesc lang="en">
f065e8
-Valid Openstack credentials as openrc file from api_access/openrc.
f065e8
-</longdesc>
f065e8
-<shortdesc lang="en">openrc file</shortdesc>
f065e8
-<content type="string" />
f065e8
-</parameter>
f065e8
-
f065e8
 <parameter name="curlcli">
f065e8
 <longdesc lang="en">
f065e8
 Path to command line cURL binary.
f065e8
@@ -97,14 +95,6 @@
f065e8
 <content type="string" default="${OCF_RESKEY_curlcli_default}" />
f065e8
 </parameter>
f065e8
 
f065e8
-<parameter name="openstackcli">
f065e8
-<longdesc lang="en">
f065e8
-Path to command line tools for openstack.
f065e8
-</longdesc>
f065e8
-<shortdesc lang="en">Path to Openstack CLI tool</shortdesc>
f065e8
-<content type="string" default="${OCF_RESKEY_openstackcli_default}" />
f065e8
-</parameter>
f065e8
-
f065e8
 <parameter name="pythoncli">
f065e8
 <longdesc lang="en">
f065e8
 Path to command line Python interpreter.
f065e8
@@ -116,9 +106,9 @@
f065e8
 </parameters>
f065e8
 
f065e8
 <actions>
f065e8
-<action name="start"  timeout="20s" />
f065e8
-<action name="stop" timeout="20s" />
f065e8
-<action name="monitor" timeout="20s" interval="60s"/>
f065e8
+<action name="start"  timeout="180s" />
f065e8
+<action name="stop" timeout="180s" />
f065e8
+<action name="monitor" timeout="180s" interval="60s"/>
f065e8
 <action name="meta-data" timeout="5s" />
f065e8
 <action name="validate-all" timeout="20s" />
f065e8
 </actions>
f065e8
@@ -134,7 +124,7 @@
f065e8
 	local node
f065e8
 	local node_id
f065e8
 
f065e8
-	. $OCF_RESKEY_openrc
f065e8
+	get_config
f065e8
 
f065e8
 	# Nova data: server ID
f065e8
 	node_id=$($OCF_RESKEY_curlcli \
f065e8
@@ -244,16 +234,6 @@
f065e8
 	check_binary "$OCF_RESKEY_openstackcli"
f065e8
 	check_binary "$OCF_RESKEY_pythoncli"
f065e8
 
f065e8
-	if [ -z "$OCF_RESKEY_openrc" ]; then
f065e8
-		ocf_exit_reason "openrc parameter not set"
f065e8
-		return $OCF_ERR_CONFIGURED
f065e8
-	fi
f065e8
-
f065e8
-	if [ ! -f "$OCF_RESKEY_openrc" ] ; then
f065e8
-		ocf_exit_reason "openrc file not found"
f065e8
-		return $OCF_ERR_CONFIGURED
f065e8
-	fi
f065e8
-
f065e8
 	return $OCF_SUCCESS
f065e8
 }
f065e8
 
f065e8
diff --color -uNr a/heartbeat/openstack-virtual-ip b/heartbeat/openstack-virtual-ip
f065e8
--- a/heartbeat/openstack-virtual-ip	2022-03-15 16:14:29.370209063 +0100
f065e8
+++ b/heartbeat/openstack-virtual-ip	2022-03-15 16:17:36.235840021 +0100
f065e8
@@ -34,10 +34,9 @@
f065e8
 : ${OCF_FUNCTIONS_DIR=${OCF_ROOT}/lib/heartbeat}
f065e8
 . ${OCF_FUNCTIONS_DIR}/ocf-shellfuncs
f065e8
 
f065e8
-# Defaults
f065e8
-OCF_RESKEY_openstackcli_default="/usr/bin/openstack"
f065e8
+. ${OCF_FUNCTIONS_DIR}/openstack-common.sh
f065e8
 
f065e8
-: ${OCF_RESKEY_openstackcli=${OCF_RESKEY_openstackcli_default}}
f065e8
+# Defaults
f065e8
 
f065e8
 #######################################################################
f065e8
 
f065e8
@@ -68,22 +67,11 @@
f065e8
 <shortdesc lang="en">Move a virtual IP</shortdesc>
f065e8
 
f065e8
 <parameters>
f065e8
-<parameter name="openstackcli">
f065e8
-<longdesc lang="en">
f065e8
-Path to command line tools for openstack.
f065e8
-</longdesc>
f065e8
-<shortdesc lang="en">Path to Openstack CLI tool</shortdesc>
f065e8
-<content type="string" default="${OCF_RESKEY_openstackcli_default}" />
f065e8
-</parameter>
f065e8
+END
f065e8
 
f065e8
-<parameter name="openrc" required="1">
f065e8
-<longdesc lang="en">
f065e8
-Valid Openstack credentials as openrc file from api_access/openrc.
f065e8
-</longdesc>
f065e8
-<shortdesc lang="en">openrc file</shortdesc>
f065e8
-<content type="string" />
f065e8
-</parameter>
f065e8
+common_meta_data
f065e8
 
f065e8
+cat <
f065e8
 <parameter name="ip" required="1">
f065e8
 <longdesc lang="en">
f065e8
 Virtual IP Address.
f065e8
@@ -105,7 +93,7 @@
f065e8
 <actions>
f065e8
 <action name="start" timeout="180s" />
f065e8
 <action name="stop" timeout="180s" />
f065e8
-<action name="monitor" depth="0" timeout="30s" interval="60s" />
f065e8
+<action name="monitor" depth="0" timeout="180s" interval="60s" />
f065e8
 <action name="validate-all" timeout="5s" />
f065e8
 <action name="meta-data" timeout="5s" />
f065e8
 </actions>
f065e8
@@ -128,17 +116,7 @@
f065e8
 osvip_validate() {
f065e8
 	check_binary "$OCF_RESKEY_openstackcli"
f065e8
 
f065e8
-	if [ -z "$OCF_RESKEY_openrc" ]; then
f065e8
-		ocf_exit_reason "openrc parameter not set"
f065e8
-		return $OCF_ERR_CONFIGURED
f065e8
-	fi
f065e8
-
f065e8
-	if [ ! -f "$OCF_RESKEY_openrc" ] ; then
f065e8
-		ocf_exit_reason "openrc file not found"
f065e8
-		return $OCF_ERR_CONFIGURED
f065e8
-	fi
f065e8
-
f065e8
-	. $OCF_RESKEY_openrc
f065e8
+	get_config
f065e8
 
f065e8
 	${HA_SBIN_DIR}/attrd_updater --query -n openstack_ports -N $(crm_node -n) > /dev/null 2>&1
f065e8
 	if [ $? -ne 0 ] ; then