Blame SOURCES/bz1908146-bz1908147-bz1908148-bz1949114-update-openstack-agents.patch

4ff291
diff --color -uNr a/heartbeat/Makefile.am b/heartbeat/Makefile.am
4ff291
--- a/heartbeat/Makefile.am	2022-03-15 16:14:29.355209012 +0100
4ff291
+++ b/heartbeat/Makefile.am	2022-03-15 16:18:35.917048467 +0100
4ff291
@@ -217,6 +217,7 @@
4ff291
 			  lvm-clvm.sh		\
4ff291
 			  lvm-plain.sh		\
4ff291
 			  lvm-tag.sh		\
4ff291
+			  openstack-common.sh	\
4ff291
 			  ora-common.sh		\
4ff291
 			  mysql-common.sh	\
4ff291
 			  nfsserver-redhat.sh	\
4ff291
diff --color -uNr a/heartbeat/openstack-cinder-volume b/heartbeat/openstack-cinder-volume
4ff291
--- a/heartbeat/openstack-cinder-volume	2022-03-15 16:14:29.370209063 +0100
4ff291
+++ b/heartbeat/openstack-cinder-volume	2022-03-15 16:17:36.231840008 +0100
4ff291
@@ -34,11 +34,11 @@
4ff291
 : ${OCF_FUNCTIONS_DIR=${OCF_ROOT}/lib/heartbeat}
4ff291
 . ${OCF_FUNCTIONS_DIR}/ocf-shellfuncs
4ff291
 
4ff291
+. ${OCF_FUNCTIONS_DIR}/openstack-common.sh
4ff291
+
4ff291
 # Defaults
4ff291
-OCF_RESKEY_openstackcli_default="/usr/bin/openstack"
4ff291
 OCF_RESKEY_volume_local_check_default="true"
4ff291
 
4ff291
-: ${OCF_RESKEY_openstackcli=${OCF_RESKEY_openstackcli_default}}
4ff291
 : ${OCF_RESKEY_volume_local_check=${OCF_RESKEY_volume_local_check_default}}
4ff291
 
4ff291
 #######################################################################
4ff291
@@ -68,14 +68,11 @@
4ff291
 <shortdesc lang="en">Attach a cinder volume</shortdesc>
4ff291
 
4ff291
 <parameters>
4ff291
-<parameter name="openstackcli">
4ff291
-<longdesc lang="en">
4ff291
-Path to command line tools for openstack.
4ff291
-</longdesc>
4ff291
-<shortdesc lang="en">Path to Openstack CLI tool</shortdesc>
4ff291
-<content type="string" default="${OCF_RESKEY_openstackcli_default}" />
4ff291
-</parameter>
4ff291
+END
4ff291
 
4ff291
+common_meta_data
4ff291
+
4ff291
+cat <
4ff291
 <parameter name="volume_local_check">
4ff291
 <longdesc lang="en">
4ff291
 This option allows the cluster to monitor the cinder volume presence without 
4ff291
@@ -85,28 +82,19 @@
4ff291
 <content type="boolean" default="${OCF_RESKEY_volume_local_check_default}" />
4ff291
 </parameter>
4ff291
 
4ff291
-<parameter name="openrc" required="1">
4ff291
-<longdesc lang="en">
4ff291
-Valid Openstack credentials as openrc file from api_access/openrc.
4ff291
-</longdesc>
4ff291
-<shortdesc lang="en">openrc file</shortdesc>
4ff291
-<content type="string" />
4ff291
-</parameter>
4ff291
-
4ff291
 <parameter name="volume_id" required="1">
4ff291
 <longdesc lang="en">
4ff291
-Cinder volume identifier to use to attach the bloc storage.
4ff291
+Cinder volume identifier to use to attach the block storage.
4ff291
 </longdesc>
4ff291
 <shortdesc lang="en">Volume ID</shortdesc>
4ff291
 <content type="string" />
4ff291
 </parameter>
4ff291
-
4ff291
 </parameters>
4ff291
 
4ff291
 <actions>
4ff291
 <action name="start" timeout="180s" />
4ff291
 <action name="stop" timeout="180s" />
4ff291
-<action name="monitor" depth="0" timeout="30s" interval="60s" />
4ff291
+<action name="monitor" depth="0" timeout="180s" interval="60s" />
4ff291
 <action name="validate-all" timeout="5s" />
4ff291
 <action name="meta-data" timeout="5s" />
4ff291
 </actions>
4ff291
@@ -127,17 +115,7 @@
4ff291
 osvol_validate() {
4ff291
 	check_binary "$OCF_RESKEY_openstackcli"
4ff291
 	
4ff291
-	if [ -z "$OCF_RESKEY_openrc" ]; then
4ff291
-		ocf_exit_reason "openrc parameter not set"
4ff291
-		return $OCF_ERR_CONFIGURED
4ff291
-	fi
4ff291
-
4ff291
-	if [ ! -f "$OCF_RESKEY_openrc" ] ; then
4ff291
-		ocf_exit_reason "openrc file not found"
4ff291
-		return $OCF_ERR_CONFIGURED
4ff291
-	fi
4ff291
-
4ff291
-	. $OCF_RESKEY_openrc
4ff291
+	get_config
4ff291
 
4ff291
 	if ! $OCF_RESKEY_openstackcli volume list|grep -q $OCF_RESKEY_volume_id ; then
4ff291
 		ocf_exit_reason "volume-id $OCF_RESKEY_volume_id not found"
4ff291
diff --color -uNr a/heartbeat/openstack-common.sh b/heartbeat/openstack-common.sh
4ff291
--- a/heartbeat/openstack-common.sh	1970-01-01 01:00:00.000000000 +0100
4ff291
+++ b/heartbeat/openstack-common.sh	2022-03-15 16:17:36.232840011 +0100
4ff291
@@ -0,0 +1,147 @@
4ff291
+OCF_RESKEY_openstackcli_default="/usr/bin/openstack"
4ff291
+OCF_RESKEY_insecure_default="false"
4ff291
+
4ff291
+: ${OCF_RESKEY_openstackcli=${OCF_RESKEY_openstackcli_default}}
4ff291
+: ${OCF_RESKEY_insecure=${OCF_RESKEY_insecure_default}}
4ff291
+
4ff291
+if ocf_is_true "${OCF_RESKEY_insecure}"; then
4ff291
+	OCF_RESKEY_openstackcli="${OCF_RESKEY_openstackcli} --insecure"
4ff291
+fi
4ff291
+
4ff291
+common_meta_data() {
4ff291
+	cat <
4ff291
+
4ff291
+<parameter name="cloud" required="0">
4ff291
+<longdesc lang="en">
4ff291
+Openstack cloud (from ~/.config/openstack/clouds.yaml or /etc/openstack/clouds.yaml).
4ff291
+</longdesc>
4ff291
+<shortdesc lang="en">Cloud from clouds.yaml</shortdesc>
4ff291
+<content type="string" />
4ff291
+</parameter>
4ff291
+
4ff291
+<parameter name="openrc" required="0">
4ff291
+<longdesc lang="en">
4ff291
+Openstack credentials as openrc file from api_access/openrc.
4ff291
+</longdesc>
4ff291
+<shortdesc lang="en">openrc file</shortdesc>
4ff291
+<content type="string" />
4ff291
+</parameter>
4ff291
+
4ff291
+<parameter name="auth_url" required="0">
4ff291
+<longdesc lang="en">
4ff291
+Keystone Auth URL
4ff291
+</longdesc>
4ff291
+<shortdesc lang="en">Keystone Auth URL</shortdesc>
4ff291
+<content type="string" />
4ff291
+</parameter>
4ff291
+
4ff291
+<parameter name="username" required="0">
4ff291
+<longdesc lang="en">
4ff291
+Username.
4ff291
+</longdesc>
4ff291
+<shortdesc lang="en">Username</shortdesc>
4ff291
+<content type="string" />
4ff291
+</parameter>
4ff291
+
4ff291
+<parameter name="password" required="0">
4ff291
+<longdesc lang="en">
4ff291
+Password.
4ff291
+</longdesc>
4ff291
+<shortdesc lang="en">Password</shortdesc>
4ff291
+<content type="string" />
4ff291
+</parameter>
4ff291
+
4ff291
+<parameter name="project_name" required="0">
4ff291
+<longdesc lang="en">
4ff291
+Keystone Project.
4ff291
+</longdesc>
4ff291
+<shortdesc lang="en">Keystone Project</shortdesc>
4ff291
+<content type="string" />
4ff291
+</parameter>
4ff291
+
4ff291
+<parameter name="user_domain_name" required="0">
4ff291
+<longdesc lang="en">
4ff291
+Keystone User Domain Name.
4ff291
+</longdesc>
4ff291
+<shortdesc lang="en">Keystone User Domain Name</shortdesc>
4ff291
+<content type="string" />
4ff291
+</parameter>
4ff291
+
4ff291
+<parameter name="project_domain_name" required="0">
4ff291
+<longdesc lang="en">
4ff291
+Keystone Project Domain Name.
4ff291
+</longdesc>
4ff291
+<shortdesc lang="en">Keystone Project Domain Name</shortdesc>
4ff291
+<content type="string" />
4ff291
+</parameter>
4ff291
+
4ff291
+<parameter name="openstackcli">
4ff291
+<longdesc lang="en">
4ff291
+Path to command line tools for openstack.
4ff291
+</longdesc>
4ff291
+<shortdesc lang="en">Path to Openstack CLI tool</shortdesc>
4ff291
+<content type="string" default="${OCF_RESKEY_openstackcli_default}" />
4ff291
+</parameter>
4ff291
+
4ff291
+<parameter name="insecure">
4ff291
+<longdesc lang="en">
4ff291
+Allow insecure connections
4ff291
+</longdesc>
4ff291
+<shortdesc lang="en">Allow insecure connections</shortdesc>
4ff291
+<content type="boolean" default="${OCF_RESKEY_insecure_default}" />
4ff291
+</parameter>
4ff291
+END
4ff291
+}
4ff291
+
4ff291
+get_config() {
4ff291
+	if [ -n "$OCF_RESKEY_cloud" ]; then
4ff291
+		TILDE=$(echo ~)
4ff291
+		clouds_yaml="$TILDE/.config/openstack/clouds.yaml"
4ff291
+		if [ ! -f "$clouds_yaml" ]; then
4ff291
+			clouds_yaml="/etc/openstack/clouds.yaml"
4ff291
+		fi
4ff291
+		if [ ! -f "$clouds_yaml" ]; then
4ff291
+			ocf_exit_reason "~/.config/openstack/clouds.yaml and /etc/openstack/clouds.yaml does not exist"
4ff291
+			exit $OCF_ERR_CONFIGURED
4ff291
+		fi
4ff291
+		OCF_RESKEY_openstackcli="${OCF_RESKEY_openstackcli} --os-cloud $OCF_RESKEY_cloud"
4ff291
+	elif [ -n "$OCF_RESKEY_openrc" ]; then
4ff291
+		if [ ! -f "$OCF_RESKEY_openrc" ]; then
4ff291
+			ocf_exit_reason "$OCF_RESKEY_openrc does not exist"
4ff291
+			exit $OCF_ERR_CONFIGURED
4ff291
+		fi
4ff291
+		. $OCF_RESKEY_openrc
4ff291
+	else
4ff291
+		if [ -z "$OCF_RESKEY_auth_url" ]; then
4ff291
+			ocf_exit_reason "auth_url not set"
4ff291
+			exit $OCF_ERR_CONFIGURED
4ff291
+		fi
4ff291
+		if [ -z "$OCF_RESKEY_username" ]; then
4ff291
+			ocf_exit_reason "username not set"
4ff291
+			exit $OCF_ERR_CONFIGURED
4ff291
+		fi
4ff291
+		if [ -z "$OCF_RESKEY_password" ]; then
4ff291
+			ocf_exit_reason "password not set"
4ff291
+			exit $OCF_ERR_CONFIGURED
4ff291
+		fi
4ff291
+		if [ -z "$OCF_RESKEY_project_name" ]; then
4ff291
+			ocf_exit_reason "project_name not set"
4ff291
+			exit $OCF_ERR_CONFIGURED
4ff291
+		fi
4ff291
+		if [ -z "$OCF_RESKEY_user_domain_name" ]; then
4ff291
+			ocf_exit_reason "user_domain_name not set"
4ff291
+			exit $OCF_ERR_CONFIGURED
4ff291
+		fi
4ff291
+		if [ -z "$OCF_RESKEY_project_domain_name" ]; then
4ff291
+			ocf_exit_reason " not set"
4ff291
+			exit $OCF_ERR_CONFIGURED
4ff291
+		fi
4ff291
+
4ff291
+		OCF_RESKEY_openstackcli="${OCF_RESKEY_openstackcli} --os-auth-url $OCF_RESKEY_auth_url"
4ff291
+		OCF_RESKEY_openstackcli="${OCF_RESKEY_openstackcli} --os-username $OCF_RESKEY_username"
4ff291
+		OCF_RESKEY_openstackcli="${OCF_RESKEY_openstackcli} --os-password $OCF_RESKEY_password"
4ff291
+		OCF_RESKEY_openstackcli="${OCF_RESKEY_openstackcli} --os-project-name $OCF_RESKEY_project_name"
4ff291
+		OCF_RESKEY_openstackcli="${OCF_RESKEY_openstackcli} --os-user-domain-name $OCF_RESKEY_user_domain_name"
4ff291
+		OCF_RESKEY_openstackcli="${OCF_RESKEY_openstackcli} --os-project-domain-name $OCF_RESKEY_project_domain_name"
4ff291
+	fi
4ff291
+}
4ff291
diff --color -uNr a/heartbeat/openstack-floating-ip b/heartbeat/openstack-floating-ip
4ff291
--- a/heartbeat/openstack-floating-ip	2022-03-15 16:14:29.370209063 +0100
4ff291
+++ b/heartbeat/openstack-floating-ip	2022-03-15 16:17:36.233840014 +0100
4ff291
@@ -34,10 +34,9 @@
4ff291
 : ${OCF_FUNCTIONS_DIR=${OCF_ROOT}/lib/heartbeat}
4ff291
 . ${OCF_FUNCTIONS_DIR}/ocf-shellfuncs
4ff291
 
4ff291
-# Defaults
4ff291
-OCF_RESKEY_openstackcli_default="/usr/bin/openstack"
4ff291
+. ${OCF_FUNCTIONS_DIR}/openstack-common.sh
4ff291
 
4ff291
-: ${OCF_RESKEY_openstackcli=${OCF_RESKEY_openstackcli_default}}
4ff291
+# Defaults
4ff291
 
4ff291
 #######################################################################
4ff291
 
4ff291
@@ -67,22 +66,11 @@
4ff291
 <shortdesc lang="en">Move a floating IP</shortdesc>
4ff291
 
4ff291
 <parameters>
4ff291
-<parameter name="openstackcli">
4ff291
-<longdesc lang="en">
4ff291
-Path to command line tools for openstack.
4ff291
-</longdesc>
4ff291
-<shortdesc lang="en">Path to Openstack CLI tool</shortdesc>
4ff291
-<content type="string" default="${OCF_RESKEY_openstackcli_default}" />
4ff291
-</parameter>
4ff291
+END
4ff291
 
4ff291
-<parameter name="openrc" required="1">
4ff291
-<longdesc lang="en">
4ff291
-Valid Openstack credentials as openrc file from api_access/openrc.
4ff291
-</longdesc>
4ff291
-<shortdesc lang="en">openrc file</shortdesc>
4ff291
-<content type="string" />
4ff291
-</parameter>
4ff291
+common_meta_data
4ff291
 
4ff291
+cat <
4ff291
 <parameter name="ip_id" required="1">
4ff291
 <longdesc lang="en">
4ff291
 Floating IP Identifier.
4ff291
@@ -104,7 +92,7 @@
4ff291
 <actions>
4ff291
 <action name="start" timeout="180s" />
4ff291
 <action name="stop" timeout="180s" />
4ff291
-<action name="monitor" depth="0" timeout="30s" interval="60s" />
4ff291
+<action name="monitor" depth="0" timeout="180s" interval="60s" />
4ff291
 <action name="validate-all" timeout="5s" />
4ff291
 <action name="meta-data" timeout="5s" />
4ff291
 </actions>
4ff291
@@ -115,17 +103,7 @@
4ff291
 osflip_validate() {
4ff291
 	check_binary "$OCF_RESKEY_openstackcli"
4ff291
 
4ff291
-	if [ -z "$OCF_RESKEY_openrc" ]; then
4ff291
-		ocf_exit_reason "openrc parameter not set"
4ff291
-		return $OCF_ERR_CONFIGURED
4ff291
-	fi
4ff291
-
4ff291
-	if [ ! -f "$OCF_RESKEY_openrc" ] ; then
4ff291
-		ocf_exit_reason "openrc file not found"
4ff291
-		return $OCF_ERR_CONFIGURED
4ff291
-	fi
4ff291
-
4ff291
-	. $OCF_RESKEY_openrc
4ff291
+	get_config
4ff291
 
4ff291
 	if ! $OCF_RESKEY_openstackcli floating ip list|grep -q $OCF_RESKEY_ip_id ; then
4ff291
 		ocf_exit_reason "ip-id $OCF_RESKEY_ip_id not found"
4ff291
diff --color -uNr a/heartbeat/openstack-info b/heartbeat/openstack-info
4ff291
--- a/heartbeat/openstack-info	1970-01-01 01:00:00.000000000 +0100
4ff291
+++ b/heartbeat/openstack-info	2022-03-15 16:17:36.234840018 +0100
4ff291
@@ -0,0 +1,270 @@
4ff291
+#!/bin/sh
4ff291
+#
4ff291
+#
4ff291
+# OCF resource agent to set attributes from Openstack instance details.
4ff291
+# It records (in the CIB) various attributes of a node
4ff291
+#
4ff291
+# Copyright (c) 2018 Mathieu Grzybek
4ff291
+#          All Rights Reserved.
4ff291
+#
4ff291
+# This program is free software; you can redistribute it and/or modify
4ff291
+# it under the terms of version 2 of the GNU General Public License as
4ff291
+# published by the Free Software Foundation.
4ff291
+#
4ff291
+# This program is distributed in the hope that it would be useful, but
4ff291
+# WITHOUT ANY WARRANTY; without even the implied warranty of
4ff291
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
4ff291
+#
4ff291
+# Further, this software is distributed without any warranty that it is
4ff291
+# free of the rightful claim of any third person regarding infringement
4ff291
+# or the like. Any license provided herein, whether implied or
4ff291
+# otherwise, applies only to this software file. Patent licenses, if
4ff291
+# any, provided herein do not apply to combinations of this program with
4ff291
+# other software, or any other product whatsoever.
4ff291
+#
4ff291
+# You should have received a copy of the GNU General Public License
4ff291
+# along with this program; if not, write the Free Software Foundation,
4ff291
+# Inc., 59 Temple Place - Suite 330, Boston MA 02111-1307, USA.
4ff291
+#
4ff291
+#######################################################################
4ff291
+# Initialization:
4ff291
+
4ff291
+: ${OCF_FUNCTIONS_DIR=${OCF_ROOT}/lib/heartbeat}
4ff291
+. ${OCF_FUNCTIONS_DIR}/ocf-shellfuncs
4ff291
+
4ff291
+. ${OCF_FUNCTIONS_DIR}/openstack-common.sh
4ff291
+
4ff291
+# Defaults
4ff291
+OCF_RESKEY_pidfile_default="$HA_RSCTMP/OSInfo-${OCF_RESOURCE_HOSTNAME}"
4ff291
+OCF_RESKEY_delay_default="0"
4ff291
+OCF_RESKEY_clone_default="0"
4ff291
+OCF_RESKEY_curlcli_default="/usr/bin/curl"
4ff291
+OCF_RESKEY_pythoncli_default="/usr/bin/python"
4ff291
+
4ff291
+: ${OCF_RESKEY_curlcli=${OCF_RESKEY_curlcli_default}}
4ff291
+: ${OCF_RESKEY_pythoncli=${OCF_RESKEY_pythoncli_default}}
4ff291
+: ${OCF_RESKEY_pidfile=${OCF_RESKEY_pidfile_default}}
4ff291
+: ${OCF_RESKEY_delay=${OCF_RESKEY_delay_default}}
4ff291
+: ${OCF_RESKEY_clone=${OCF_RESKEY_clone_default}}
4ff291
+
4ff291
+#######################################################################
4ff291
+
4ff291
+meta_data() {
4ff291
+	cat <
4ff291
+
4ff291
+
4ff291
+<resource-agent name="openstack-info" version="1.0">
4ff291
+<version>1.0</version>
4ff291
+
4ff291
+<longdesc lang="en">
4ff291
+OCF resource agent to set attributes from Openstack instance details.
4ff291
+It records (in the CIB) various attributes of a node.
4ff291
+Sample output:
4ff291
+	openstack_az      : nova
4ff291
+	openstack_flavor  : c1.small
4ff291
+	openstack_id      : 60ac4343-5828-49b1-8aac-7c69b1417f31
4ff291
+	openstack_ports   : 7960d889-9750-4160-bf41-c69a41ad72d9:96530d18-57a3-4718-af32-30f2a74c22a2,b0e55a06-bd75-468d-8baa-22cfeb65799f:a55ae917-8016-4b1e-8ffa-04311b9dc7d6
4ff291
+
4ff291
+The layout of openstack_ports is a comma-separated list of tuples "subnet_id:port_id".
4ff291
+</longdesc>
4ff291
+<shortdesc lang="en">Records various node attributes in the CIB</shortdesc>
4ff291
+
4ff291
+<parameters>
4ff291
+END
4ff291
+
4ff291
+common_meta_data
4ff291
+
4ff291
+	cat <
4ff291
+<parameter name="pidfile" unique="0">
4ff291
+<longdesc lang="en">PID file</longdesc>
4ff291
+<shortdesc lang="en">PID file</shortdesc>
4ff291
+<content type="string" default="${OCF_RESKEY_pidfile_default}" />
4ff291
+</parameter>
4ff291
+
4ff291
+<parameter name="delay" unique="0">
4ff291
+<longdesc lang="en">Interval to allow values to stabilize</longdesc>
4ff291
+<shortdesc lang="en">Dampening Delay</shortdesc>
4ff291
+<content type="string" default="${OCF_RESKEY_delay_default}" />
4ff291
+</parameter>
4ff291
+
4ff291
+<parameter name="curlcli">
4ff291
+<longdesc lang="en">
4ff291
+Path to command line cURL binary.
4ff291
+</longdesc>
4ff291
+<shortdesc lang="en">Path to cURL binary</shortdesc>
4ff291
+<content type="string" default="${OCF_RESKEY_curlcli_default}" />
4ff291
+</parameter>
4ff291
+
4ff291
+<parameter name="pythoncli">
4ff291
+<longdesc lang="en">
4ff291
+Path to command line Python interpreter.
4ff291
+</longdesc>
4ff291
+<shortdesc lang="en">Path to Python interpreter</shortdesc>
4ff291
+<content type="string" default="${OCF_RESKEY_pythoncli_default}" />
4ff291
+</parameter>
4ff291
+
4ff291
+</parameters>
4ff291
+
4ff291
+<actions>
4ff291
+<action name="start"  timeout="180s" />
4ff291
+<action name="stop" timeout="180s" />
4ff291
+<action name="monitor" timeout="30s" interval="60s"/>
4ff291
+<action name="meta-data" timeout="5s" />
4ff291
+<action name="validate-all" timeout="20s" />
4ff291
+</actions>
4ff291
+</resource-agent>
4ff291
+END
4ff291
+}
4ff291
+
4ff291
+#######################################################################
4ff291
+
4ff291
+OSInfoStats() {
4ff291
+	local result
4ff291
+	local value
4ff291
+	local node
4ff291
+	local node_id
4ff291
+
4ff291
+	get_config
4ff291
+
4ff291
+	# Nova data: server ID
4ff291
+	node_id=$($OCF_RESKEY_curlcli \
4ff291
+		-s http://169.254.169.254/openstack/latest/meta_data.json |
4ff291
+		$OCF_RESKEY_pythoncli -m json.tool |
4ff291
+		grep -P '\"uuid\": \".*\",$' |
4ff291
+		grep -P -o '[0-9a-f]{8}-([0-9a-f]{4}-){3}[0-9a-f]{12}')
4ff291
+
4ff291
+	if [ $? -ne 0 ] ; then
4ff291
+		ocf_exit_reason "Cannot find server ID"
4ff291
+		exit $OCF_ERR_GENERIC
4ff291
+	fi
4ff291
+
4ff291
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -n openstack_id -v "$node_id"
4ff291
+
4ff291
+	# Nova data: flavor
4ff291
+	value=$($OCF_RESKEY_openstackcli server show \
4ff291
+		--format value \
4ff291
+		--column flavor \
4ff291
+		$node_id)
4ff291
+
4ff291
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -n openstack_flavor -v "$value"
4ff291
+
4ff291
+	# Nova data: availability zone
4ff291
+	value=$($OCF_RESKEY_openstackcli server show \
4ff291
+		--format value \
4ff291
+		--column OS-EXT-AZ:availability_zone \
4ff291
+		$node_id)
4ff291
+
4ff291
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -n openstack_az -v "$value"
4ff291
+
4ff291
+	# Network data: ports
4ff291
+	value=""
4ff291
+	for port_id in $($OCF_RESKEY_openstackcli port list \
4ff291
+		--format value \
4ff291
+		--column id \
4ff291
+		--server $node_id); do
4ff291
+		subnet_id=$($OCF_RESKEY_openstackcli port show \
4ff291
+			--format json \
4ff291
+			--column fixed_ips \
4ff291
+			${port_id} | grep -P '\"subnet_id\": \".*\",$' |
4ff291
+			grep -P -o '[0-9a-f]{8}-([0-9a-f]{4}-){3}[0-9a-f]{12}')
4ff291
+		value+="${subnet_id}:${port_id},"
4ff291
+	done
4ff291
+	value=$(echo ${value} | sed -e 's/,$//g')
4ff291
+
4ff291
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -n openstack_ports -v "$value"
4ff291
+
4ff291
+	if [ ! -z "$OS_REGION_NAME" ] ; then
4ff291
+		${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -n openstack_region -v "$OS_REGION_NAME"
4ff291
+	fi
4ff291
+
4ff291
+	if [ ! -z "$OS_TENANT_ID" ] ; then
4ff291
+		${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -n openstack_tenant_id -v "$OS_TENANT_ID"
4ff291
+
4ff291
+		if [ ! -z "$OS_TENANT_NAME" ] ; then
4ff291
+			${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -n openstack_tenant_name -v "$OS_TENANT_NAME"
4ff291
+		fi
4ff291
+	else
4ff291
+		${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -n openstack_project_id -v "$OS_PROJECT_ID"
4ff291
+
4ff291
+		if [ ! -z "$OS_PROJECT_NAME" ] ; then
4ff291
+			${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -n openstack_project_name -v "$OS_PROJECT_NAME"
4ff291
+		fi
4ff291
+	fi
4ff291
+
4ff291
+}
4ff291
+
4ff291
+OSInfo_usage() {
4ff291
+	cat <
4ff291
+usage: $0 {start|stop|monitor|validate-all|meta-data}
4ff291
+
4ff291
+Expects to have a fully populated OCF RA-compliant environment set.
4ff291
+END
4ff291
+}
4ff291
+
4ff291
+OSInfo_start() {
4ff291
+	echo $OCF_RESKEY_clone > $OCF_RESKEY_pidfile
4ff291
+	OSInfoStats
4ff291
+	exit $OCF_SUCCESS
4ff291
+}
4ff291
+
4ff291
+OSInfo_stop() {
4ff291
+	rm -f $OCF_RESKEY_pidfile
4ff291
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -D -n openstack_id
4ff291
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -D -n openstack_flavor
4ff291
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -D -n openstack_az
4ff291
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -D -n openstack_ports
4ff291
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -D -n openstack_region
4ff291
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -D -n openstack_tenant_id
4ff291
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -D -n openstack_tenant_name
4ff291
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -D -n openstack_project_id
4ff291
+	${HA_SBIN_DIR}/attrd_updater ${OCF_RESKEY_delay} -D -n openstack_project_name
4ff291
+	exit $OCF_SUCCESS
4ff291
+}
4ff291
+
4ff291
+OSInfo_monitor() {
4ff291
+	if [ -f "$OCF_RESKEY_pidfile" ] ; then
4ff291
+		OSInfoStats
4ff291
+		exit $OCF_RUNNING
4ff291
+	fi
4ff291
+	exit $OCF_NOT_RUNNING
4ff291
+}
4ff291
+
4ff291
+OSInfo_validate() {
4ff291
+	check_binary "$OCF_RESKEY_curlcli"
4ff291
+	check_binary "$OCF_RESKEY_openstackcli"
4ff291
+	check_binary "$OCF_RESKEY_pythoncli"
4ff291
+
4ff291
+	return $OCF_SUCCESS
4ff291
+}
4ff291
+
4ff291
+if [ $# -ne 1 ]; then
4ff291
+	OSInfo_usage
4ff291
+	exit $OCF_ERR_ARGS
4ff291
+fi
4ff291
+
4ff291
+if [ x != x${OCF_RESKEY_delay} ]; then
4ff291
+	OCF_RESKEY_delay="-d ${OCF_RESKEY_delay}"
4ff291
+fi
4ff291
+
4ff291
+case $__OCF_ACTION in
4ff291
+meta-data)	meta_data
4ff291
+		exit $OCF_SUCCESS
4ff291
+		;;
4ff291
+start)		OSInfo_validate || exit $?
4ff291
+		OSInfo_start
4ff291
+		;;
4ff291
+stop)		OSInfo_stop
4ff291
+		;;
4ff291
+monitor)	OSInfo_monitor
4ff291
+		;;
4ff291
+validate-all)	OSInfo_validate
4ff291
+		;;
4ff291
+usage|help)	OSInfo_usage
4ff291
+		exit $OCF_SUCCESS
4ff291
+		;;
4ff291
+*)		OSInfo_usage
4ff291
+		exit $OCF_ERR_UNIMPLEMENTED
4ff291
+		;;
4ff291
+esac
4ff291
+
4ff291
+exit $?
4ff291
diff --color -uNr a/heartbeat/openstack-info.in b/heartbeat/openstack-info.in
4ff291
--- a/heartbeat/openstack-info.in	2022-03-15 16:14:29.370209063 +0100
4ff291
+++ b/heartbeat/openstack-info.in	2022-03-15 16:17:36.234840018 +0100
4ff291
@@ -32,16 +32,16 @@
4ff291
 : ${OCF_FUNCTIONS_DIR=${OCF_ROOT}/lib/heartbeat}
4ff291
 . ${OCF_FUNCTIONS_DIR}/ocf-shellfuncs
4ff291
 
4ff291
+. ${OCF_FUNCTIONS_DIR}/openstack-common.sh
4ff291
+
4ff291
 # Defaults
4ff291
 OCF_RESKEY_pidfile_default="$HA_RSCTMP/OSInfo-${OCF_RESOURCE_HOSTNAME}"
4ff291
 OCF_RESKEY_delay_default="0"
4ff291
 OCF_RESKEY_clone_default="0"
4ff291
 OCF_RESKEY_curlcli_default="/usr/bin/curl"
4ff291
-OCF_RESKEY_openstackcli_default="/usr/bin/openstack"
4ff291
 OCF_RESKEY_pythoncli_default="@PYTHON@"
4ff291
 
4ff291
 : ${OCF_RESKEY_curlcli=${OCF_RESKEY_curlcli_default}}
4ff291
-: ${OCF_RESKEY_openstackcli=${OCF_RESKEY_openstackcli_default}}
4ff291
 : ${OCF_RESKEY_pythoncli=${OCF_RESKEY_pythoncli_default}}
4ff291
 : ${OCF_RESKEY_pidfile=${OCF_RESKEY_pidfile_default}}
4ff291
 : ${OCF_RESKEY_delay=${OCF_RESKEY_delay_default}}
4ff291
@@ -70,25 +70,23 @@
4ff291
 <shortdesc lang="en">Records various node attributes in the CIB</shortdesc>
4ff291
 
4ff291
 <parameters>
4ff291
+END
4ff291
+
4ff291
+common_meta_data
4ff291
+
4ff291
+	cat <
4ff291
 <parameter name="pidfile" unique="0">
4ff291
 <longdesc lang="en">PID file</longdesc>
4ff291
 <shortdesc lang="en">PID file</shortdesc>
4ff291
 <content type="string" default="${OCF_RESKEY_pidfile_default}" />
4ff291
 </parameter>
4ff291
+
4ff291
 <parameter name="delay" unique="0">
4ff291
 <longdesc lang="en">Interval to allow values to stabilize</longdesc>
4ff291
 <shortdesc lang="en">Dampening Delay</shortdesc>
4ff291
 <content type="string" default="${OCF_RESKEY_delay_default}" />
4ff291
 </parameter>
4ff291
 
4ff291
-<parameter name="openrc" required="1">
4ff291
-<longdesc lang="en">
4ff291
-Valid Openstack credentials as openrc file from api_access/openrc.
4ff291
-</longdesc>
4ff291
-<shortdesc lang="en">openrc file</shortdesc>
4ff291
-<content type="string" />
4ff291
-</parameter>
4ff291
-
4ff291
 <parameter name="curlcli">
4ff291
 <longdesc lang="en">
4ff291
 Path to command line cURL binary.
4ff291
@@ -97,14 +95,6 @@
4ff291
 <content type="string" default="${OCF_RESKEY_curlcli_default}" />
4ff291
 </parameter>
4ff291
 
4ff291
-<parameter name="openstackcli">
4ff291
-<longdesc lang="en">
4ff291
-Path to command line tools for openstack.
4ff291
-</longdesc>
4ff291
-<shortdesc lang="en">Path to Openstack CLI tool</shortdesc>
4ff291
-<content type="string" default="${OCF_RESKEY_openstackcli_default}" />
4ff291
-</parameter>
4ff291
-
4ff291
 <parameter name="pythoncli">
4ff291
 <longdesc lang="en">
4ff291
 Path to command line Python interpreter.
4ff291
@@ -116,9 +106,9 @@
4ff291
 </parameters>
4ff291
 
4ff291
 <actions>
4ff291
-<action name="start"  timeout="20s" />
4ff291
-<action name="stop" timeout="20s" />
4ff291
-<action name="monitor" timeout="20s" interval="60s"/>
4ff291
+<action name="start"  timeout="180s" />
4ff291
+<action name="stop" timeout="180s" />
4ff291
+<action name="monitor" timeout="180s" interval="60s"/>
4ff291
 <action name="meta-data" timeout="5s" />
4ff291
 <action name="validate-all" timeout="20s" />
4ff291
 </actions>
4ff291
@@ -134,7 +124,7 @@
4ff291
 	local node
4ff291
 	local node_id
4ff291
 
4ff291
-	. $OCF_RESKEY_openrc
4ff291
+	get_config
4ff291
 
4ff291
 	# Nova data: server ID
4ff291
 	node_id=$($OCF_RESKEY_curlcli \
4ff291
@@ -244,16 +234,6 @@
4ff291
 	check_binary "$OCF_RESKEY_openstackcli"
4ff291
 	check_binary "$OCF_RESKEY_pythoncli"
4ff291
 
4ff291
-	if [ -z "$OCF_RESKEY_openrc" ]; then
4ff291
-		ocf_exit_reason "openrc parameter not set"
4ff291
-		return $OCF_ERR_CONFIGURED
4ff291
-	fi
4ff291
-
4ff291
-	if [ ! -f "$OCF_RESKEY_openrc" ] ; then
4ff291
-		ocf_exit_reason "openrc file not found"
4ff291
-		return $OCF_ERR_CONFIGURED
4ff291
-	fi
4ff291
-
4ff291
 	return $OCF_SUCCESS
4ff291
 }
4ff291
 
4ff291
diff --color -uNr a/heartbeat/openstack-virtual-ip b/heartbeat/openstack-virtual-ip
4ff291
--- a/heartbeat/openstack-virtual-ip	2022-03-15 16:14:29.370209063 +0100
4ff291
+++ b/heartbeat/openstack-virtual-ip	2022-03-15 16:17:36.235840021 +0100
4ff291
@@ -34,10 +34,9 @@
4ff291
 : ${OCF_FUNCTIONS_DIR=${OCF_ROOT}/lib/heartbeat}
4ff291
 . ${OCF_FUNCTIONS_DIR}/ocf-shellfuncs
4ff291
 
4ff291
-# Defaults
4ff291
-OCF_RESKEY_openstackcli_default="/usr/bin/openstack"
4ff291
+. ${OCF_FUNCTIONS_DIR}/openstack-common.sh
4ff291
 
4ff291
-: ${OCF_RESKEY_openstackcli=${OCF_RESKEY_openstackcli_default}}
4ff291
+# Defaults
4ff291
 
4ff291
 #######################################################################
4ff291
 
4ff291
@@ -68,22 +67,11 @@
4ff291
 <shortdesc lang="en">Move a virtual IP</shortdesc>
4ff291
 
4ff291
 <parameters>
4ff291
-<parameter name="openstackcli">
4ff291
-<longdesc lang="en">
4ff291
-Path to command line tools for openstack.
4ff291
-</longdesc>
4ff291
-<shortdesc lang="en">Path to Openstack CLI tool</shortdesc>
4ff291
-<content type="string" default="${OCF_RESKEY_openstackcli_default}" />
4ff291
-</parameter>
4ff291
+END
4ff291
 
4ff291
-<parameter name="openrc" required="1">
4ff291
-<longdesc lang="en">
4ff291
-Valid Openstack credentials as openrc file from api_access/openrc.
4ff291
-</longdesc>
4ff291
-<shortdesc lang="en">openrc file</shortdesc>
4ff291
-<content type="string" />
4ff291
-</parameter>
4ff291
+common_meta_data
4ff291
 
4ff291
+cat <
4ff291
 <parameter name="ip" required="1">
4ff291
 <longdesc lang="en">
4ff291
 Virtual IP Address.
4ff291
@@ -105,7 +93,7 @@
4ff291
 <actions>
4ff291
 <action name="start" timeout="180s" />
4ff291
 <action name="stop" timeout="180s" />
4ff291
-<action name="monitor" depth="0" timeout="30s" interval="60s" />
4ff291
+<action name="monitor" depth="0" timeout="180s" interval="60s" />
4ff291
 <action name="validate-all" timeout="5s" />
4ff291
 <action name="meta-data" timeout="5s" />
4ff291
 </actions>
4ff291
@@ -128,17 +116,7 @@
4ff291
 osvip_validate() {
4ff291
 	check_binary "$OCF_RESKEY_openstackcli"
4ff291
 
4ff291
-	if [ -z "$OCF_RESKEY_openrc" ]; then
4ff291
-		ocf_exit_reason "openrc parameter not set"
4ff291
-		return $OCF_ERR_CONFIGURED
4ff291
-	fi
4ff291
-
4ff291
-	if [ ! -f "$OCF_RESKEY_openrc" ] ; then
4ff291
-		ocf_exit_reason "openrc file not found"
4ff291
-		return $OCF_ERR_CONFIGURED
4ff291
-	fi
4ff291
-
4ff291
-	. $OCF_RESKEY_openrc
4ff291
+	get_config
4ff291
 
4ff291
 	${HA_SBIN_DIR}/attrd_updater --query -n openstack_ports -N $(crm_node -n) > /dev/null 2>&1
4ff291
 	if [ $? -ne 0 ] ; then