Blame SOURCES/bz1755760-NovaEvacuate-evacuate_delay.patch

9cf66a
From 8b9c49fd965f73709d5a6e2c21987ba26af4856b Mon Sep 17 00:00:00 2001
9cf66a
From: Luca Miccini <lmiccini@redhat.com>
9cf66a
Date: Wed, 25 Sep 2019 17:12:39 +0200
9cf66a
Subject: [PATCH] Add a configurable delay to Nova Evacuate calls
9cf66a
9cf66a
In case /var/lib/nova/instances resides on NFS we have seen migrations
9cf66a
failing with 'Failed to get "write" lock - Is another process using the
9cf66a
image' errors.
9cf66a
9cf66a
This has been tracked down to grace/lease timeouts not having expired
9cf66a
before attempting the migration/evacuate, so in this cases it might be
9cf66a
desirable to delay the nova evacuate call to give the storage time to
9cf66a
release the locks.
9cf66a
9cf66a
Change-Id: Ie2fe784202d754eda38092479b1ab3ff4d02136a
9cf66a
Resolves: rhbz#1740069
9cf66a
---
9cf66a
9cf66a
diff --git a/heartbeat/NovaEvacuate b/heartbeat/NovaEvacuate
9cf66a
index 810f30a..596f520 100644
9cf66a
--- a/heartbeat/NovaEvacuate
9cf66a
+++ b/heartbeat/NovaEvacuate
9cf66a
@@ -125,6 +125,15 @@
9cf66a
 <content type="boolean" default="0" />
9cf66a
 </parameter>
9cf66a
 
9cf66a
+<parameter name="evacuate_delay" unique="0" required="0">
9cf66a
+<longdesc lang="en">
9cf66a
+Allows delaying the nova evacuate API call, e.g. to give a storage array time to clean
9cf66a
+up eventual locks/leases.
9cf66a
+</longdesc>
9cf66a
+<shortdesc lang="en">Nova evacuate delay</shortdesc>
9cf66a
+<content type="integer" default="0" />
9cf66a
+</parameter>
9cf66a
+
9cf66a
 </parameters>
9cf66a
 
9cf66a
 <actions>
9cf66a
@@ -216,6 +225,11 @@
9cf66a
 		fence_agent="fence_evacuate"
9cf66a
 	    fi
9cf66a
 
9cf66a
+            if [ ${OCF_RESKEY_evacuate_delay} != 0 ]; then
9cf66a
+                ocf_log info "Delaying nova evacuate by $OCF_RESKEY_evacuate_delay seconds"
9cf66a
+                sleep ${OCF_RESKEY_evacuate_delay}
9cf66a
+            fi
9cf66a
+
9cf66a
 	    ocf_log notice "Initiating evacuation of $node with $fence_agent"
9cf66a
 	    $fence_agent ${fence_options} -o status -n ${node}
9cf66a
 	    if [ $? = 1 ]; then