From f413ee60dcd538603f0db608899799113fba053f Mon Sep 17 00:00:00 2001 From: Sumit Bose Date: Tue, 14 Aug 2018 14:09:48 +0200 Subject: [PATCH] Fix issues found by Coverity --- service/realm-kerberos.c | 5 ++++- service/realm-packages.c | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/service/realm-kerberos.c b/service/realm-kerberos.c index d6d109f..252e256 100644 --- a/service/realm-kerberos.c +++ b/service/realm-kerberos.c @@ -980,7 +980,10 @@ realm_kerberos_set_details (RealmKerberos *self, if (name == NULL) break; value = va_arg (va, const gchar *); - g_return_if_fail (value != NULL); + if (value == NULL) { + va_end (va); + g_return_if_reached (); + } values[0] = g_variant_new_string (name); values[1] = g_variant_new_string (value); diff --git a/service/realm-packages.c b/service/realm-packages.c index 9a6984c..5976439 100644 --- a/service/realm-packages.c +++ b/service/realm-packages.c @@ -567,7 +567,7 @@ lookup_required_files_and_packages (const gchar **package_sets, g_ptr_array_add (packages, NULL); *result_packages = (gchar **)g_ptr_array_free (packages, FALSE); } else { - g_ptr_array_free (files, TRUE); + g_ptr_array_free (packages, TRUE); } if (result_files) { -- 2.17.1