Blame SOURCES/0001-service-Add-nss-and-pam-sssd.conf-services-after-joi.patch

4d12ff
From 402cbab6e8267fcd959bcfa84a47f4871b59944d Mon Sep 17 00:00:00 2001
4d12ff
From: Stef Walter <stefw@redhat.com>
4d12ff
Date: Fri, 28 Oct 2016 20:27:48 +0200
4d12ff
Subject: [PATCH] service: Add nss and pam sssd.conf services after joining
4d12ff
4d12ff
After adding a domain to sssd.conf add the nss and pam services
4d12ff
to the [sssd] block.
4d12ff
4d12ff
https://bugs.freedesktop.org/show_bug.cgi?id=98479
4d12ff
---
4d12ff
 service/realm-sssd-ad.c     | 3 +++
4d12ff
 service/realm-sssd-config.c | 2 --
4d12ff
 service/realm-sssd-ipa.c    | 3 +++
4d12ff
 tests/test-sssd-config.c    | 4 ++--
4d12ff
 4 files changed, 8 insertions(+), 4 deletions(-)
4d12ff
4d12ff
diff --git a/service/realm-sssd-ad.c b/service/realm-sssd-ad.c
4d12ff
index 5ed384d..5fa81ce 100644
4d12ff
--- a/service/realm-sssd-ad.c
4d12ff
+++ b/service/realm-sssd-ad.c
4d12ff
@@ -160,6 +160,7 @@ configure_sssd_for_domain (RealmIniConfig *config,
4d12ff
                            gboolean use_adcli,
4d12ff
                            GError **error)
4d12ff
 {
4d12ff
+	const gchar *services[] = { "nss", "pam", NULL };
4d12ff
 	GString *realmd_tags;
4d12ff
 	const gchar *access_provider;
4d12ff
 	const gchar *shell;
4d12ff
@@ -206,6 +207,8 @@ configure_sssd_for_domain (RealmIniConfig *config,
4d12ff
 	                                    "ldap_sasl_authid", authid,
4d12ff
 	                                    NULL);
4d12ff
 
4d12ff
+	realm_ini_config_set_list_diff (config, "sssd", "services", ", ", services, NULL);
4d12ff
+
4d12ff
 	g_free (authid);
4d12ff
 	g_string_free (realmd_tags, TRUE);
4d12ff
 
4d12ff
diff --git a/service/realm-sssd-config.c b/service/realm-sssd-config.c
4d12ff
index 2096afd..d4398b9 100644
4d12ff
--- a/service/realm-sssd-config.c
4d12ff
+++ b/service/realm-sssd-config.c
4d12ff
@@ -154,8 +154,6 @@ realm_sssd_config_add_domain (RealmIniConfig *config,
4d12ff
 	g_strfreev (already);
4d12ff
 
4d12ff
 	/* Setup a default sssd section */
4d12ff
-	if (!realm_ini_config_have (config, "section", "services"))
4d12ff
-		realm_ini_config_set (config, "sssd", "services", "nss, pam", NULL);
4d12ff
 	if (!realm_ini_config_have (config, "sssd", "config_file_version"))
4d12ff
 		realm_ini_config_set (config, "sssd", "config_file_version", "2", NULL);
4d12ff
 
4d12ff
diff --git a/service/realm-sssd-ipa.c b/service/realm-sssd-ipa.c
4d12ff
index b12136e..001870d 100644
4d12ff
--- a/service/realm-sssd-ipa.c
4d12ff
+++ b/service/realm-sssd-ipa.c
4d12ff
@@ -156,6 +156,7 @@ on_ipa_client_do_restart (GObject *source,
4d12ff
                           GAsyncResult *result,
4d12ff
                           gpointer user_data)
4d12ff
 {
4d12ff
+	const gchar *services[] = { "nss", "pam", NULL };
4d12ff
 	GTask *task = G_TASK (user_data);
4d12ff
 	EnrollClosure *enroll = g_task_get_task_data (task);
4d12ff
 	RealmSssd *sssd = g_task_get_source_object (task);
4d12ff
@@ -207,6 +208,8 @@ on_ipa_client_do_restart (GObject *source,
4d12ff
 		                                 "realmd_tags", realmd_tags,
4d12ff
 		                                 NULL);
4d12ff
 
4d12ff
+		realm_ini_config_set_list_diff (config, "sssd", "services", ", ", services, NULL);
4d12ff
+
4d12ff
 		g_free (home);
4d12ff
 	}
4d12ff
 
4d12ff
diff --git a/tests/test-sssd-config.c b/tests/test-sssd-config.c
4d12ff
index 59eab75..892b9d5 100644
4d12ff
--- a/tests/test-sssd-config.c
4d12ff
+++ b/tests/test-sssd-config.c
4d12ff
@@ -90,7 +90,7 @@ test_add_domain (Test *test,
4d12ff
                  gconstpointer unused)
4d12ff
 {
4d12ff
 	const gchar *data = "[domain/one]\nval=1\n[sssd]\ndomains=one";
4d12ff
-	const gchar *check = "[domain/one]\nval=1\n[sssd]\ndomains = one, two\nconfig_file_version = 2\nservices = nss, pam\n\n[domain/two]\ndos = 2\n";
4d12ff
+	const gchar *check = "[domain/one]\nval=1\n[sssd]\ndomains = one, two\nconfig_file_version = 2\n\n[domain/two]\ndos = 2\n";
4d12ff
 	GError *error = NULL;
4d12ff
 	gchar *output;
4d12ff
 	gboolean ret;
4d12ff
@@ -140,7 +140,7 @@ static void
4d12ff
 test_add_domain_only (Test *test,
4d12ff
                       gconstpointer unused)
4d12ff
 {
4d12ff
-	const gchar *check = "\n[sssd]\ndomains = two\nconfig_file_version = 2\nservices = nss, pam\n\n[domain/two]\ndos = 2\n";
4d12ff
+	const gchar *check = "\n[sssd]\ndomains = two\nconfig_file_version = 2\n\n[domain/two]\ndos = 2\n";
4d12ff
 	GError *error = NULL;
4d12ff
 	gchar *output;
4d12ff
 	gboolean ret;
4d12ff
-- 
4d12ff
2.9.3
4d12ff