|
 |
3a7434 |
From f413ee60dcd538603f0db608899799113fba053f Mon Sep 17 00:00:00 2001
|
|
|
3a7434 |
From: Sumit Bose <sbose@redhat.com>
|
|
|
3a7434 |
Date: Tue, 14 Aug 2018 14:09:48 +0200
|
|
|
3a7434 |
Subject: [PATCH] Fix issues found by Coverity
|
|
|
3a7434 |
|
|
|
3a7434 |
---
|
|
|
3a7434 |
service/realm-kerberos.c | 5 ++++-
|
|
|
3a7434 |
service/realm-packages.c | 2 +-
|
|
|
3a7434 |
2 files changed, 5 insertions(+), 2 deletions(-)
|
|
|
3a7434 |
|
|
|
3a7434 |
diff --git a/service/realm-kerberos.c b/service/realm-kerberos.c
|
|
|
3a7434 |
index d6d109f..252e256 100644
|
|
|
3a7434 |
--- a/service/realm-kerberos.c
|
|
|
3a7434 |
+++ b/service/realm-kerberos.c
|
|
|
3a7434 |
@@ -980,7 +980,10 @@ realm_kerberos_set_details (RealmKerberos *self,
|
|
|
3a7434 |
if (name == NULL)
|
|
|
3a7434 |
break;
|
|
|
3a7434 |
value = va_arg (va, const gchar *);
|
|
|
3a7434 |
- g_return_if_fail (value != NULL);
|
|
|
3a7434 |
+ if (value == NULL) {
|
|
|
3a7434 |
+ va_end (va);
|
|
|
3a7434 |
+ g_return_if_reached ();
|
|
|
3a7434 |
+ }
|
|
|
3a7434 |
|
|
|
3a7434 |
values[0] = g_variant_new_string (name);
|
|
|
3a7434 |
values[1] = g_variant_new_string (value);
|
|
|
3a7434 |
diff --git a/service/realm-packages.c b/service/realm-packages.c
|
|
|
3a7434 |
index 9a6984c..5976439 100644
|
|
|
3a7434 |
--- a/service/realm-packages.c
|
|
|
3a7434 |
+++ b/service/realm-packages.c
|
|
|
3a7434 |
@@ -567,7 +567,7 @@ lookup_required_files_and_packages (const gchar **package_sets,
|
|
|
3a7434 |
g_ptr_array_add (packages, NULL);
|
|
|
3a7434 |
*result_packages = (gchar **)g_ptr_array_free (packages, FALSE);
|
|
|
3a7434 |
} else {
|
|
|
3a7434 |
- g_ptr_array_free (files, TRUE);
|
|
|
3a7434 |
+ g_ptr_array_free (packages, TRUE);
|
|
|
3a7434 |
}
|
|
|
3a7434 |
|
|
|
3a7434 |
if (result_files) {
|
|
|
3a7434 |
--
|
|
|
3a7434 |
2.17.1
|
|
|
3a7434 |
|