|
 |
d9e469 |
From 349da4c3d63ec6dceef66a405561984561d31582 Mon Sep 17 00:00:00 2001
|
|
|
d9e469 |
From: Seiichi Ikarashi <s.ikarashi@jp.fujitsu.com>
|
|
|
d9e469 |
Date: Wed, 10 Jun 2015 20:49:55 -0300
|
|
|
d9e469 |
Subject: [PATCH 3/5] rasdaemon: unnecessary comma for empty mc_location string
|
|
|
d9e469 |
|
|
|
d9e469 |
Into the /var/log/messages, rasdaemon sometimes prints an unnecessary
|
|
|
d9e469 |
comma ", " between mca= and cpu_type= like below:
|
|
|
d9e469 |
|
|
|
d9e469 |
Jun 9 02:44:39 localhost rasdaemon: <...>-4585 [1638893312] 1031.109000: mce_record: 2015-06-08 10:07:28 +0900 bank=3, status= 9c0000000000017a, mci=Corrected_error Error_enabled, mca=Generic CACHE Level-2 Eviction Error, , cpu_type= Intel Xeon v3 (Haswell) EP/EX, cpu= 1, socketid= 0, misc= 4004000000000080, addr= 204fffffff, mcgstatus= 0, mcgcap= 7000c16, apicid= 2
|
|
|
d9e469 |
|
|
|
d9e469 |
That's the comma for mc_location which is printed even if mc_location is
|
|
|
d9e469 |
empty due to a wrong if condition.
|
|
|
d9e469 |
|
|
|
d9e469 |
Signed-off-by: Seiichi Ikarashi <s.ikarashi@jp.fujitsu.com>
|
|
|
d9e469 |
Acked-by: Aristeu Rozanski <aris@redhat.com>
|
|
|
d9e469 |
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
|
|
|
d9e469 |
---
|
|
|
d9e469 |
ras-mce-handler.c | 2 +-
|
|
|
d9e469 |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
d9e469 |
|
|
|
d9e469 |
diff --git a/ras-mce-handler.c b/ras-mce-handler.c
|
|
|
d9e469 |
index fb6db8a..07252a0 100644
|
|
|
d9e469 |
--- a/ras-mce-handler.c
|
|
|
d9e469 |
+++ b/ras-mce-handler.c
|
|
|
d9e469 |
@@ -278,7 +278,7 @@ static void report_mce_event(struct ras_events *ras,
|
|
|
d9e469 |
if (*e->user_action)
|
|
|
d9e469 |
trace_seq_printf(s, " %s", e->user_action);
|
|
|
d9e469 |
|
|
|
d9e469 |
- if (e->mc_location)
|
|
|
d9e469 |
+ if (*e->mc_location)
|
|
|
d9e469 |
trace_seq_printf(s, ", %s", e->mc_location);
|
|
|
d9e469 |
|
|
|
d9e469 |
#if 0
|
|
|
d9e469 |
--
|
|
|
d9e469 |
1.8.3.1
|
|
|
d9e469 |
|