Blame SOURCES/0027-Client-Avoid-processing-of-events-when-showing-windo.patch

869fe3
From b736b4488dcaa1a3c6b0c6059e5b85881f74c52b Mon Sep 17 00:00:00 2001
9fb289
From: David Edmundson <davidedmundson@kde.org>
9fb289
Date: Sun, 14 Nov 2021 13:54:19 +0000
869fe3
Subject: [PATCH 27/40] Client: Avoid processing of events when showing windows
9fb289
9fb289
The only time we want to dispatch events from the wayland socket is when
9fb289
the application is waiting for external events. Doing so at any other
9fb289
time will cause unpredictable behavior in client code.
9fb289
9fb289
This caused a crash downstream where we had outputs get altered whilst
9fb289
itterating through outputs, which shouldn't happen.
9fb289
9fb289
There is no benefit to flushing here, it won't make anything appear
9fb289
faster as we haven't attached the buffer yet.
9fb289
9fb289
Change-Id: Ie13eae4012dab96a93d8810f468d1343402b8c28
9fb289
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
9fb289
Reviewed-by: Aleix Pol Gonzalez <aleixpol@kde.org>
9fb289
(cherry picked from commit 46ed85a80b28d519cf5887bbdce55d1bf57886c3)
9fb289
---
9fb289
 src/client/qwaylandwindow.cpp | 1 -
9fb289
 1 file changed, 1 deletion(-)
9fb289
9fb289
diff --git a/src/client/qwaylandwindow.cpp b/src/client/qwaylandwindow.cpp
9fb289
index ba881cb3..1597f67e 100644
9fb289
--- a/src/client/qwaylandwindow.cpp
9fb289
+++ b/src/client/qwaylandwindow.cpp
9fb289
@@ -436,7 +436,6 @@ void QWaylandWindow::setVisible(bool visible)
9fb289
         if (window()->type() == Qt::Popup || window()->type() == Qt::ToolTip)
9fb289
             activePopups << this;
9fb289
         initWindow();
9fb289
-        mDisplay->flushRequests();
9fb289
 
9fb289
         setGeometry(windowGeometry());
9fb289
         // Don't flush the events here, or else the newly visible window may start drawing, but since
9fb289
-- 
9fb289
2.35.1
9fb289