Blame SOURCES/0013-Client-Send-set_window_geometry-only-once-configured.patch

de89c0
From 7db4f83c39d2a0c709bc0b9c0de3946d3b4ebfd5 Mon Sep 17 00:00:00 2001
c54cd9
From: David Edmundson <davidedmundson@kde.org>
c54cd9
Date: Mon, 16 Nov 2020 14:57:36 +0000
de89c0
Subject: [PATCH 13/36] Client: Send set_window_geometry only once configured
c54cd9
c54cd9
The geometry only makes sense when a buffer exists, our currently send
c54cd9
value is somewhat meaningless, but till now harmless.
c54cd9
c54cd9
A specification clarification implies that it is an error if the
c54cd9
calculated effective window geometry is null, rather than just checking
c54cd9
the sent value. This is the case if set_window_geometry is sent before a
c54cd9
buffer is attached.
c54cd9
c54cd9
On our first configure call we enter resizeFromApplyConfigure which will
c54cd9
hit this path and send the initial state.
c54cd9
c54cd9
Pick-to: 5.15
c54cd9
Pick-to: 6.1
c54cd9
Pick-to: 6.0
c54cd9
Change-Id: Ib57ebe8b64210eae86e79dfdd6b5cb8a986b020b
c54cd9
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
c54cd9
---
c54cd9
 src/client/qwaylandwindow.cpp | 2 +-
c54cd9
 1 file changed, 1 insertion(+), 1 deletion(-)
c54cd9
c54cd9
diff --git a/src/client/qwaylandwindow.cpp b/src/client/qwaylandwindow.cpp
de89c0
index 9b343702..e875af3a 100644
c54cd9
--- a/src/client/qwaylandwindow.cpp
c54cd9
+++ b/src/client/qwaylandwindow.cpp
de89c0
@@ -365,7 +365,7 @@ void QWaylandWindow::setGeometry(const QRect &rect)
c54cd9
     if (isExposed() && !mInResizeFromApplyConfigure && exposeGeometry != mLastExposeGeometry)
c54cd9
         sendExposeEvent(exposeGeometry);
c54cd9
 
c54cd9
-    if (mShellSurface)
c54cd9
+    if (mShellSurface && isExposed())
c54cd9
         mShellSurface->setWindowGeometry(windowContentGeometry());
c54cd9
 
c54cd9
     if (isOpaque() && mMask.isEmpty())
de89c0
-- 
de89c0
2.33.1
de89c0