Blame 0106-net-check-packet-payload-length.patch

54cb13
From: Prasad J Pandit <pjp@fedoraproject.org>
54cb13
Date: Wed, 2 Mar 2016 17:29:58 +0530
54cb13
Subject: [PATCH] net: check packet payload length
54cb13
54cb13
While computing IP checksum, 'net_checksum_calculate' reads
54cb13
payload length from the packet. It could exceed the given 'data'
54cb13
buffer size. Add a check to avoid it.
54cb13
54cb13
Reported-by: Liu Ling <liuling-it@360.cn>
54cb13
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
54cb13
Signed-off-by: Jason Wang <jasowang@redhat.com>
54cb13
(cherry picked from commit 362786f14a753d8a5256ef97d7c10ed576d6572b)
54cb13
---
54cb13
 net/checksum.c | 10 ++++++++--
54cb13
 1 file changed, 8 insertions(+), 2 deletions(-)
54cb13
54cb13
diff --git a/net/checksum.c b/net/checksum.c
54cb13
index 14c0855..0942437 100644
54cb13
--- a/net/checksum.c
54cb13
+++ b/net/checksum.c
54cb13
@@ -59,6 +59,11 @@ void net_checksum_calculate(uint8_t *data, int length)
54cb13
     int hlen, plen, proto, csum_offset;
54cb13
     uint16_t csum;
54cb13
 
54cb13
+    /* Ensure data has complete L2 & L3 headers. */
54cb13
+    if (length < 14 + 20) {
54cb13
+        return;
54cb13
+    }
54cb13
+
54cb13
     if ((data[14] & 0xf0) != 0x40)
54cb13
 	return; /* not IPv4 */
54cb13
     hlen  = (data[14] & 0x0f) * 4;
54cb13
@@ -76,8 +81,9 @@ void net_checksum_calculate(uint8_t *data, int length)
54cb13
 	return;
54cb13
     }
54cb13
 
54cb13
-    if (plen < csum_offset+2)
54cb13
-	return;
54cb13
+    if (plen < csum_offset + 2 || 14 + hlen + plen > length) {
54cb13
+        return;
54cb13
+    }
54cb13
 
54cb13
     data[14+hlen+csum_offset]   = 0;
54cb13
     data[14+hlen+csum_offset+1] = 0;