From c766165206c5618768075d1d37204b2500ad2420 Mon Sep 17 00:00:00 2001 From: Alex Williamson Date: Tue, 12 Jun 2018 19:04:07 +0100 Subject: [PATCH 01/15] vfio/pci: Default display option to "off" RH-Author: Alex Williamson Message-id: <20180612190329.21103.32803.stgit@gimli.home> Patchwork-id: 80646 O-Subject: [virt212 qemu-kvm PATCH] vfio/pci: Default display option to "off" Bugzilla: 1590511 RH-Acked-by: Auger Eric RH-Acked-by: Gerd Hoffmann RH-Acked-by: Laszlo Ersek Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1590511 Brew: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=16695604 Testing: RHEL-7.6 version tested by QE Commit a9994687cb9b ("vfio/display: core & wireup") added display support to vfio-pci with the default being "auto", which breaks existing VMs when the vGPU requires GL support but had no previous requirement for a GL compatible configuration. "Off" is the safer default as we impose no new requirements to VM configurations. Fixes: a9994687cb9b ("vfio/display: core & wireup") Cc: qemu-stable@nongnu.org Cc: Gerd Hoffmann Signed-off-by: Alex Williamson (cherry picked from commit 8151a9c56d31eeeea872b8103c8b86d03c411667) Signed-off-by: Danilo C. L. de Paula --- hw/vfio/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 34b9d19..4683eb4 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -3167,7 +3167,7 @@ static Property vfio_pci_dev_properties[] = { DEFINE_PROP_PCI_HOST_DEVADDR("host", VFIOPCIDevice, host), DEFINE_PROP_STRING("sysfsdev", VFIOPCIDevice, vbasedev.sysfsdev), DEFINE_PROP_ON_OFF_AUTO("display", VFIOPCIDevice, - display, ON_OFF_AUTO_AUTO), + display, ON_OFF_AUTO_OFF), DEFINE_PROP_UINT32("x-intx-mmap-timeout-ms", VFIOPCIDevice, intx.mmap_timeout, 1100), DEFINE_PROP_BIT("x-vga", VFIOPCIDevice, features, -- 1.8.3.1