From 35f8992f043687db739ccaf363b3f3686eeba398 Mon Sep 17 00:00:00 2001 From: Thomas Huth Date: Tue, 22 Jan 2019 17:40:28 +0000 Subject: [PATCH 10/11] s390x: Return specification exception for unimplemented diag 308 subcodes RH-Author: Thomas Huth Message-id: <1548178828-21117-2-git-send-email-thuth@redhat.com> Patchwork-id: 84086 O-Subject: [RHEL8/rhel qemu-kvm PATCH 1/1] s390x: Return specification exception for unimplemented diag 308 subcodes Bugzilla: 1668261 RH-Acked-by: David Hildenbrand RH-Acked-by: Cornelia Huck RH-Acked-by: Jens Freimann From: Janosch Frank The architecture specifies specification exceptions for all unavailable subcodes. The presence of subcodes is indicated by checking some query subcode. For example 6 will indicate that 3-6 are available. So future systems might call new subcodes to check for new features. This should not trigger a hw error, instead we return the architectured specification exception. Signed-off-by: Janosch Frank Cc: qemu-stable@nongnu.org Message-Id: <20190111113657.66195-3-frankja@linux.ibm.com> Reviewed-by: Christian Borntraeger Reviewed-by: David Hildenbrand Signed-off-by: Cornelia Huck (cherry picked from commit 37dbd1f4d4805edcd18d94eb202bb3461b3cd52d) Signed-off-by: Danilo C. L. de Paula --- target/s390x/diag.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/diag.c b/target/s390x/diag.c index a755837..50b58df 100644 --- a/target/s390x/diag.c +++ b/target/s390x/diag.c @@ -182,7 +182,7 @@ out: } return; default: - hw_error("Unhandled diag308 subcode %" PRIx64, subcode); + s390_program_interrupt(env, PGM_SPECIFICATION, ILEN_AUTO, ra); break; } } -- 1.8.3.1