From 9c1134e8923157059587541b4f318e63ad8c39fe Mon Sep 17 00:00:00 2001 From: Laszlo Ersek Date: Fri, 7 Nov 2014 17:17:49 +0100 Subject: [PATCH 02/41] dump-guest-memory: Check for the correct return value Message-id: <1415380693-16593-3-git-send-email-lersek@redhat.com> Patchwork-id: 62188 O-Subject: [RHEL-7.1 qemu-kvm PATCH 02/26] dump-guest-memory: Check for the correct return value Bugzilla: 1157798 RH-Acked-by: Stefan Hajnoczi RH-Acked-by: Luiz Capitulino RH-Acked-by: dgibson From: "Aneesh Kumar K.V" We should check for error with s->note_size Signed-off-by: Aneesh Kumar K.V Signed-off-by: Alexander Graf (cherry picked from commit bb6b684363e83586c90d20127b0d0a79793ab1e2) Signed-off-by: Laszlo Ersek Signed-off-by: Miroslav Rezanina --- dump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dump.c b/dump.c index a2b6e45..8c31386 100644 --- a/dump.c +++ b/dump.c @@ -66,7 +66,7 @@ typedef struct DumpState { uint32_t sh_info; bool have_section; bool resume; - size_t note_size; + ssize_t note_size; hwaddr memory_offset; int fd; @@ -771,7 +771,7 @@ static int dump_init(DumpState *s, int fd, bool paging, bool has_filter, s->note_size = cpu_get_note_size(s->dump_info.d_class, s->dump_info.d_machine, nr_cpus); - if (ret < 0) { + if (s->note_size < 0) { error_set(errp, QERR_UNSUPPORTED); goto cleanup; } -- 1.8.3.1