From 31c38d22c1d0e852c05eb8d74295f940fc93aaa8 Mon Sep 17 00:00:00 2001 From: Fam Zheng Date: Mon, 14 Jul 2014 02:38:04 -0500 Subject: [CHANGE 23/29] virtio-pci: Report an error when msix vectors init fails To: rhvirt-patches@redhat.com, jen@redhat.com RH-Author: Fam Zheng Message-id: <1405305484-12175-1-git-send-email-famz@redhat.com> Patchwork-id: 59873 O-Subject: [RHEL-7 qemu-kvm PATCH] virtio-pci: Report an error when msix vectors init fails Bugzilla: 1095645 RH-Acked-by: Markus Armbruster RH-Acked-by: Stefan Hajnoczi RH-Acked-by: Dr. David Alan Gilbert (git) Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1095645 Brew: http://brewweb.devel.redhat.com/brew/taskinfo?taskID=7695836 Currently vectors silently cleared to 0 if the initialization is failed, but user should at least have one way to notice this. Signed-off-by: Fam Zheng Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin (cherry picked from commit c7ff54825b74f27c3aac85aad540542801630d0a) Signed-off-by: Fam Zheng --- hw/virtio/virtio-pci.c | 2 ++ 1 file changed, 2 insertions(+) Signed-off-by: jen --- hw/virtio/virtio-pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 00df4aa..7c09ac4 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c @@ -981,6 +981,8 @@ static void virtio_pci_device_plugged(DeviceState *d) if (proxy->nvectors && msix_init_exclusive_bar(&proxy->pci_dev, proxy->nvectors, 1)) { + error_report("unable to init msix vectors to %" PRIu32, + proxy->nvectors); proxy->nvectors = 0; } -- 1.9.3