From c9b1eb9d6c0da9098d5410d90d290d6fca6ea7dc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Date: Wed, 16 Dec 2020 16:06:14 -0500 Subject: [PATCH 13/14] qga: fix missing closedir() in qmp_guest_get_disks() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit RH-Author: Marc-André Lureau Message-id: <20201216160615.324213-10-marcandre.lureau@redhat.com> Patchwork-id: 100481 O-Subject: [RHEL-8.4.0 qemu-kvm PATCH v2 09/10] qga: fix missing closedir() in qmp_guest_get_disks() Bugzilla: 1859494 RH-Acked-by: Danilo de Paula RH-Acked-by: Sergio Lopez Pascual RH-Acked-by: Stefan Hajnoczi From: Michael Roth We opendir("/sys/block") at the beginning of the function, but we never close it prior to returning. Fixes: Coverity CID 1436130 Fixes: fed3956429d5 ("qga: add implementation of guest-get-disks for Linux") Reported-by: Peter Maydell Cc: Marc-André Lureau Cc: Tomáš Golembiovský Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Michael Roth (cherry-picked from commit b1b9ab1c04d560f86d8da3dfca4d8b21de75fee6) Signed-off-by: Marc-André Lureau Signed-off-by: Danilo C. L. de Paula --- qga/commands-posix.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 96f5ddafd3a..9a170dee14c 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -1445,6 +1445,9 @@ GuestDiskInfoList *qmp_guest_get_disks(Error **errp) get_disk_deps(disk_dir, disk); ret = get_disk_partitions(ret, de->d_name, disk_dir, dev_name); } + + closedir(dp); + return ret; } -- 2.27.0