From 4b889f33761a4447998b16846bfb983519def96d Mon Sep 17 00:00:00 2001 From: Thomas Huth Date: Wed, 28 Nov 2018 07:23:59 +0000 Subject: [PATCH 07/16] Declare cirrus-vga as deprecated RH-Author: Thomas Huth Message-id: <1543389839-8995-1-git-send-email-thuth@redhat.com> Patchwork-id: 83178 O-Subject: [RHEL8 qemu-kvm PATCH v2] Declare cirrus-vga as deprecated Bugzilla: 1651994 RH-Acked-by: Gerd Hoffmann RH-Acked-by: Markus Armbruster RH-Acked-by: Laszlo Ersek BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1651994 Brew: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=19300792 Upstream: n/a (downstream only) Branch: rhel8/master-2.12.0 Branch: rhel8/master-3.0.0 The "cirrus" device in qemu-kvm is considered as a legacy device, which also had a lot of security issues in the past. KVM guest should preferably use "stdvga", "virtio-vga" or "qxl" as graphics card nowadays instead. To avoid that we have to carry along the legacy "cirrus" device in downstream qemu-kvm forever, let's mark it as deprecated in RHEL8 now, so that we can finally remove it in RHEL9. Signed-off-by: Thomas Huth Signed-off-by: Danilo C. L. de Paula --- hw/display/cirrus_vga.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c index 014268a..29d6055 100644 --- a/hw/display/cirrus_vga.c +++ b/hw/display/cirrus_vga.c @@ -3098,6 +3098,9 @@ static void pci_cirrus_vga_realize(PCIDevice *dev, Error **errp) PCIDeviceClass *pc = PCI_DEVICE_GET_CLASS(dev); int16_t device_id = pc->device_id; + warn_report("'cirrus-vga' is deprecated, " + "please use a different VGA card instead"); + /* follow real hardware, cirrus card emulated has 4 MB video memory. Also accept 8 MB/16 MB for backward compatibility. */ if (s->vga.vram_size_mb != 4 && s->vga.vram_size_mb != 8 && -- 1.8.3.1