Blob Blame Raw
From 425f93585b5a8f45198e91acce68bc0e921c0bf5 Mon Sep 17 00:00:00 2001
From: Max Reitz <>
Date: Mon, 18 Jun 2018 18:00:54 +0200
Subject: [PATCH 057/268] qcow2: Do not mark inactive images corrupt

RH-Author: Max Reitz <>
Message-id: <>
Patchwork-id: 80793
O-Subject: [RHV-7.6 qemu-kvm-rhev PATCH 2/3] qcow2: Do not mark inactive images corrupt
Bugzilla: 1588039
RH-Acked-by: Jeffrey Cody <>
RH-Acked-by: Kevin Wolf <>
RH-Acked-by: John Snow <>

When signaling a corruption on a read-only image, qcow2 already makes
fatal events non-fatal (i.e., they will not result in the image being
closed, and the image header's corrupt flag will not be set).  This is
necessary because we cannot set the corrupt flag on read-only images,
and it is possible because further corruption of read-only images is

Inactive images are effectively read-only, too, so we should do the same
for them.  bdrv_is_writable() can tell us whether an image can actually
be written to, so use its result instead of !bs->read_only.

(Otherwise, the assert(!(bs->open_flags & BDRV_O_INACTIVE)) in
bdrv_co_pwritev() will fail, crashing qemu.)

Signed-off-by: Max Reitz <>
Reviewed-by: John Snow <>
Reviewed-by: Jeff Cody <>
Signed-off-by: Max Reitz <>
(cherry picked from commit ddf3b47ef4b5ed0bf6558d4c2c8ae130b8d8a580)
Signed-off-by: Max Reitz <>
Signed-off-by: Miroslav Rezanina <>
 block/qcow2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/qcow2.c b/block/qcow2.c
index 35842c5..26a6a7f 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -4383,7 +4383,7 @@ void qcow2_signal_corruption(BlockDriverState *bs, bool fatal, int64_t offset,
     char *message;
     va_list ap;
-    fatal = fatal && !bs->read_only;
+    fatal = fatal && bdrv_is_writable(bs);
     if (s->signaled_corruption &&
         (!fatal || (s->incompatible_features & QCOW2_INCOMPAT_CORRUPT)))