Blob Blame Raw
From 22ab26a5dcda3ff217d543a4eff8dbad9160ce1c Mon Sep 17 00:00:00 2001
From: Xiao Wang <>
Date: Fri, 11 Jan 2019 07:58:56 +0000
Subject: [PATCH 01/11] ne2000: fix possible out of bound access in
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

RH-Author: Xiao Wang <>
Message-id: <>
Patchwork-id: 83976
O-Subject: [RHEL8 qemu-kvm PATCH 1/9] ne2000: fix possible out of bound access in ne2000_receive
Bugzilla: 1636784
RH-Acked-by: Thomas Huth <>
RH-Acked-by: Philippe Mathieu-Daudé <>
RH-Acked-by: Jens Freimann <>
RH-Acked-by: Maxime Coquelin <>
RH-Acked-by: Michael S. Tsirkin <>

In ne2000_receive(), we try to assign size_ to size which converts
from size_t to integer. This will cause troubles when size_ is greater
INT_MAX, this will lead a negative value in size and it can then pass
the check of size < MIN_BUF_SIZE which may lead out of bound access of
for both buf and buf1.

Fixing by converting the type of size to size_t.

Reported-by: Daniel Shapira <>
Reviewed-by: Michael S. Tsirkin <>
Signed-off-by: Jason Wang <>
(cherry picked from commit fdc89e90fac40c5ca2686733df17b6423fb8d8fb)
Signed-off-by: Danilo C. L. de Paula <>
 hw/net/ne2000.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/net/ne2000.c b/hw/net/ne2000.c
index 3a9fc89..19fac06 100644
--- a/hw/net/ne2000.c
+++ b/hw/net/ne2000.c
@@ -173,7 +173,7 @@ static int ne2000_buffer_full(NE2000State *s)
 ssize_t ne2000_receive(NetClientState *nc, const uint8_t *buf, size_t size_)
     NE2000State *s = qemu_get_nic_opaque(nc);
-    int size = size_;
+    size_t size = size_;
     uint8_t *p;
     unsigned int total_len, next, avail, len, index, mcast_idx;
     uint8_t buf1[60];
@@ -181,7 +181,7 @@ ssize_t ne2000_receive(NetClientState *nc, const uint8_t *buf, size_t size_)
         { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff };
 #if defined(DEBUG_NE2000)
-    printf("NE2000: received len=%d\n", size);
+    printf("NE2000: received len=%zu\n", size);
     if (s->cmd & E8390_STOP || ne2000_buffer_full(s))