|
 |
586cba |
From 019d5a0ca5d13f837a59b9e2815e2fd7ac120807 Mon Sep 17 00:00:00 2001
|
|
|
586cba |
From: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
586cba |
Date: Tue, 17 May 2022 09:28:06 +0100
|
|
|
586cba |
Subject: [PATCH 11/16] virtio-scsi: clean up virtio_scsi_handle_event_vq()
|
|
|
586cba |
|
|
|
586cba |
RH-Author: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
586cba |
RH-MergeRequest: 88: virtio-scsi: fix 100% CPU consumption with IOThreads
|
|
|
586cba |
RH-Commit: [3/6] f8dbc4c1991c61e4cf8dea50942c3cd509c9c4bd (stefanha/centos-stream-qemu-kvm)
|
|
|
586cba |
RH-Bugzilla: 2079347
|
|
|
586cba |
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
586cba |
RH-Acked-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
586cba |
RH-Acked-by: Stefano Garzarella <sgarzare@redhat.com>
|
|
|
586cba |
|
|
|
586cba |
virtio_scsi_handle_event_vq() is only called from hw/scsi/virtio-scsi.c
|
|
|
586cba |
now and its return value is no longer used. Remove the function
|
|
|
586cba |
prototype from virtio-scsi.h and drop the return value.
|
|
|
586cba |
|
|
|
586cba |
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
586cba |
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
586cba |
Message-id: 20220427143541.119567-4-stefanha@redhat.com
|
|
|
586cba |
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
586cba |
(cherry picked from commit 37ce2de95169dacab3fb53d11bd4509b9c2e3a4c)
|
|
|
586cba |
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
586cba |
---
|
|
|
586cba |
hw/scsi/virtio-scsi.c | 4 +---
|
|
|
586cba |
include/hw/virtio/virtio-scsi.h | 1 -
|
|
|
586cba |
2 files changed, 1 insertion(+), 4 deletions(-)
|
|
|
586cba |
|
|
|
586cba |
diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
|
|
|
586cba |
index 7b69eeed64..dd2185b943 100644
|
|
|
586cba |
--- a/hw/scsi/virtio-scsi.c
|
|
|
586cba |
+++ b/hw/scsi/virtio-scsi.c
|
|
|
586cba |
@@ -856,13 +856,11 @@ void virtio_scsi_push_event(VirtIOSCSI *s, SCSIDevice *dev,
|
|
|
586cba |
virtio_scsi_complete_req(req);
|
|
|
586cba |
}
|
|
|
586cba |
|
|
|
586cba |
-bool virtio_scsi_handle_event_vq(VirtIOSCSI *s, VirtQueue *vq)
|
|
|
586cba |
+static void virtio_scsi_handle_event_vq(VirtIOSCSI *s, VirtQueue *vq)
|
|
|
586cba |
{
|
|
|
586cba |
if (s->events_dropped) {
|
|
|
586cba |
virtio_scsi_push_event(s, NULL, VIRTIO_SCSI_T_NO_EVENT, 0);
|
|
|
586cba |
- return true;
|
|
|
586cba |
}
|
|
|
586cba |
- return false;
|
|
|
586cba |
}
|
|
|
586cba |
|
|
|
586cba |
static void virtio_scsi_handle_event(VirtIODevice *vdev, VirtQueue *vq)
|
|
|
586cba |
diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h
|
|
|
586cba |
index 543681bc18..5957597825 100644
|
|
|
586cba |
--- a/include/hw/virtio/virtio-scsi.h
|
|
|
586cba |
+++ b/include/hw/virtio/virtio-scsi.h
|
|
|
586cba |
@@ -151,7 +151,6 @@ void virtio_scsi_common_realize(DeviceState *dev,
|
|
|
586cba |
Error **errp);
|
|
|
586cba |
|
|
|
586cba |
void virtio_scsi_common_unrealize(DeviceState *dev);
|
|
|
586cba |
-bool virtio_scsi_handle_event_vq(VirtIOSCSI *s, VirtQueue *vq);
|
|
|
586cba |
bool virtio_scsi_handle_cmd_vq(VirtIOSCSI *s, VirtQueue *vq);
|
|
|
586cba |
bool virtio_scsi_handle_ctrl_vq(VirtIOSCSI *s, VirtQueue *vq);
|
|
|
586cba |
void virtio_scsi_init_req(VirtIOSCSI *s, VirtQueue *vq, VirtIOSCSIReq *req);
|
|
|
586cba |
--
|
|
|
586cba |
2.31.1
|
|
|
586cba |
|