|
 |
4841a6 |
From 9a62319b973ec33f9ccbeeae7f2f3b4b31db0c26 Mon Sep 17 00:00:00 2001
|
|
|
719b13 |
From: Si-Wei Liu <si-wei.liu@oracle.com>
|
|
|
719b13 |
Date: Fri, 6 May 2022 19:28:15 -0700
|
|
|
4841a6 |
Subject: [PATCH 17/24] vhost-net: fix improper cleanup in vhost_net_start
|
|
|
719b13 |
MIME-Version: 1.0
|
|
|
719b13 |
Content-Type: text/plain; charset=UTF-8
|
|
|
719b13 |
Content-Transfer-Encoding: 8bit
|
|
|
719b13 |
|
|
|
4841a6 |
RH-Author: Jason Wang <jasowang@redhat.com>
|
|
|
4841a6 |
RH-MergeRequest: 187: Multiqueue fixes for vhost-vDPA
|
|
|
4841a6 |
RH-Commit: [4/7] bebe7990a12e901fbb84e5e4b7a62744d75c9d9e
|
|
|
4841a6 |
RH-Bugzilla: 2069946
|
|
|
719b13 |
RH-Acked-by: Eugenio Pérez <eperezma@redhat.com>
|
|
|
4841a6 |
RH-Acked-by: Cindy Lu <lulu@redhat.com>
|
|
|
4841a6 |
RH-Acked-by: Laurent Vivier <lvivier@redhat.com>
|
|
|
719b13 |
|
|
|
719b13 |
vhost_net_start() missed a corresponding stop_one() upon error from
|
|
|
719b13 |
vhost_set_vring_enable(). While at it, make the error handling for
|
|
|
719b13 |
err_start more robust. No real issue was found due to this though.
|
|
|
719b13 |
|
|
|
719b13 |
Signed-off-by: Si-Wei Liu <si-wei.liu@oracle.com>
|
|
|
719b13 |
Acked-by: Jason Wang <jasowang@redhat.com>
|
|
|
719b13 |
Message-Id: <1651890498-24478-5-git-send-email-si-wei.liu@oracle.com>
|
|
|
719b13 |
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
|
|
|
719b13 |
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
|
|
|
719b13 |
(cherry picked from commit 6f3910b5eee00b8cc959e94659c0d524c482a418)
|
|
|
4841a6 |
Signed-off-by: Jason Wang <jasowang@redhat.com>
|
|
|
719b13 |
---
|
|
|
719b13 |
hw/net/vhost_net.c | 4 +++-
|
|
|
719b13 |
1 file changed, 3 insertions(+), 1 deletion(-)
|
|
|
719b13 |
|
|
|
719b13 |
diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
|
|
|
719b13 |
index 30379d2ca4..d6d7c51f62 100644
|
|
|
719b13 |
--- a/hw/net/vhost_net.c
|
|
|
719b13 |
+++ b/hw/net/vhost_net.c
|
|
|
719b13 |
@@ -381,6 +381,7 @@ int vhost_net_start(VirtIODevice *dev, NetClientState *ncs,
|
|
|
719b13 |
r = vhost_set_vring_enable(peer, peer->vring_enable);
|
|
|
719b13 |
|
|
|
719b13 |
if (r < 0) {
|
|
|
719b13 |
+ vhost_net_stop_one(get_vhost_net(peer), dev);
|
|
|
719b13 |
goto err_start;
|
|
|
719b13 |
}
|
|
|
719b13 |
}
|
|
|
719b13 |
@@ -390,7 +391,8 @@ int vhost_net_start(VirtIODevice *dev, NetClientState *ncs,
|
|
|
719b13 |
|
|
|
719b13 |
err_start:
|
|
|
719b13 |
while (--i >= 0) {
|
|
|
719b13 |
- peer = qemu_get_peer(ncs , i);
|
|
|
719b13 |
+ peer = qemu_get_peer(ncs, i < data_queue_pairs ?
|
|
|
719b13 |
+ i : n->max_queue_pairs);
|
|
|
719b13 |
vhost_net_stop_one(get_vhost_net(peer), dev);
|
|
|
719b13 |
}
|
|
|
719b13 |
e = k->set_guest_notifiers(qbus->parent, total_notifiers, false);
|
|
|
719b13 |
--
|
|
|
4841a6 |
2.35.3
|
|
|
719b13 |
|