7f1c5b
From 0f3a28e1e128754184c4af6a578f27e16c6a61d5 Mon Sep 17 00:00:00 2001
7f1c5b
From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= <eperezma@redhat.com>
7f1c5b
Date: Thu, 15 Dec 2022 12:31:37 +0100
7f1c5b
Subject: [PATCH 05/14] vdpa: add vhost_vdpa_net_valid_svq_features
7f1c5b
MIME-Version: 1.0
7f1c5b
Content-Type: text/plain; charset=UTF-8
7f1c5b
Content-Transfer-Encoding: 8bit
7f1c5b
7f1c5b
RH-Author: Eugenio Pérez <eperezma@redhat.com>
7f1c5b
RH-MergeRequest: 136: vDPA ASID support in Qemu
7f1c5b
RH-Bugzilla: 2104412
7f1c5b
RH-Acked-by: Laurent Vivier <lvivier@redhat.com>
7f1c5b
RH-Acked-by: Cindy Lu <lulu@redhat.com>
7f1c5b
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
7f1c5b
RH-Commit: [5/13] 0b27e04f178ec73cb800f4fb05c17a92576142e4 (eperezmartin/qemu-kvm)
7f1c5b
7f1c5b
It will be reused at vdpa device start so let's extract in its own
7f1c5b
function.
7f1c5b
7f1c5b
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
7f1c5b
Acked-by: Jason Wang <jasowang@redhat.com>
7f1c5b
Message-Id: <20221215113144.322011-6-eperezma@redhat.com>
7f1c5b
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
7f1c5b
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
7f1c5b
(cherry picked from commit 36e4647247f200b6fa4d2f656133f567036e8a85)
7f1c5b
---
7f1c5b
 net/vhost-vdpa.c | 26 +++++++++++++++++---------
7f1c5b
 1 file changed, 17 insertions(+), 9 deletions(-)
7f1c5b
7f1c5b
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
7f1c5b
index b06540ac89..16a5ebe2dd 100644
7f1c5b
--- a/net/vhost-vdpa.c
7f1c5b
+++ b/net/vhost-vdpa.c
7f1c5b
@@ -106,6 +106,22 @@ VHostNetState *vhost_vdpa_get_vhost_net(NetClientState *nc)
7f1c5b
     return s->vhost_net;
7f1c5b
 }
7f1c5b
 
7f1c5b
+static bool vhost_vdpa_net_valid_svq_features(uint64_t features, Error **errp)
7f1c5b
+{
7f1c5b
+    uint64_t invalid_dev_features =
7f1c5b
+        features & ~vdpa_svq_device_features &
7f1c5b
+        /* Transport are all accepted at this point */
7f1c5b
+        ~MAKE_64BIT_MASK(VIRTIO_TRANSPORT_F_START,
7f1c5b
+                         VIRTIO_TRANSPORT_F_END - VIRTIO_TRANSPORT_F_START);
7f1c5b
+
7f1c5b
+    if (invalid_dev_features) {
7f1c5b
+        error_setg(errp, "vdpa svq does not work with features 0x%" PRIx64,
7f1c5b
+                   invalid_dev_features);
7f1c5b
+    }
7f1c5b
+
7f1c5b
+    return !invalid_dev_features;
7f1c5b
+}
7f1c5b
+
7f1c5b
 static int vhost_vdpa_net_check_device_id(struct vhost_net *net)
7f1c5b
 {
7f1c5b
     uint32_t device_id;
7f1c5b
@@ -684,15 +700,7 @@ int net_init_vhost_vdpa(const Netdev *netdev, const char *name,
7f1c5b
     if (opts->x_svq) {
7f1c5b
         struct vhost_vdpa_iova_range iova_range;
7f1c5b
 
7f1c5b
-        uint64_t invalid_dev_features =
7f1c5b
-            features & ~vdpa_svq_device_features &
7f1c5b
-            /* Transport are all accepted at this point */
7f1c5b
-            ~MAKE_64BIT_MASK(VIRTIO_TRANSPORT_F_START,
7f1c5b
-                             VIRTIO_TRANSPORT_F_END - VIRTIO_TRANSPORT_F_START);
7f1c5b
-
7f1c5b
-        if (invalid_dev_features) {
7f1c5b
-            error_setg(errp, "vdpa svq does not work with features 0x%" PRIx64,
7f1c5b
-                       invalid_dev_features);
7f1c5b
+        if (!vhost_vdpa_net_valid_svq_features(features, errp)) {
7f1c5b
             goto err_svq;
7f1c5b
         }
7f1c5b
 
7f1c5b
-- 
7f1c5b
2.31.1
7f1c5b