From 2e02d49769291dda0436ec3d113c5b4917037f3f Mon Sep 17 00:00:00 2001

From: Gerd Hoffmann <kraxel@redhat.com>

Date: Mon, 15 Sep 2014 13:08:20 +0200

Subject: [PATCH 1/4] vbe: make bochs dispi interface return the correct memory size with qxl

Message-id: <1410786503-19794-2-git-send-email-kraxel@redhat.com>

Patchwork-id: 61135

O-Subject: [RHEL-7.1 qemu-kvm PATCH 1/4] vbe: make bochs dispi interface return the correct memory size with qxl

Bugzilla: 1139118

RH-Acked-by: Markus Armbruster <armbru@redhat.com>

RH-Acked-by: Paolo Bonzini <pbonzini@redhat.com>

RH-Acked-by: Laszlo Ersek <lersek@redhat.com>

VgaState->vram_size is the size of the pci bar.  In case of qxl not the

whole pci bar can be used as vga framebuffer.  Add a new variable

vbe_size to handle that case.  By default (if unset) it equals

vram_size, but qxl can set vbe_size to something else.

This makes sure VBE_DISPI_INDEX_VIDEO_MEMORY_64K returns correct results

and sanity checks are done with the correct size too.

Cc: qemu-stable@nongnu.org

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

(cherry picked from commit 54a85d462447c1cb8a1638578a7fd086350b4d2d)

Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>

---

 hw/display/qxl.c     |    1 +

 hw/display/vga.c     |    7 +++++--

 hw/display/vga_int.h |    1 +

 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/hw/display/qxl.c b/hw/display/qxl.c

index 6f8adc8..f11210c 100644

--- a/hw/display/qxl.c

+++ b/hw/display/qxl.c

@@ -2056,6 +2056,7 @@ static int qxl_init_primary(PCIDevice *dev)

     qxl->id = 0;

     qxl_init_ramsize(qxl);

+    vga->vbe_size = qxl->vgamem_size;

     vga->vram_size_mb = qxl->vga.vram_size >> 20;

     vga_common_init(vga);

     vga_init(vga, pci_address_space(dev), pci_address_space_io(dev), false);

diff --git a/hw/display/vga.c b/hw/display/vga.c

index 21a108d..d703d90 100644

--- a/hw/display/vga.c

+++ b/hw/display/vga.c

@@ -613,7 +613,7 @@ uint32_t vbe_ioport_read_data(void *opaque, uint32_t addr)

             val = s->vbe_regs[s->vbe_index];

         }

     } else if (s->vbe_index == VBE_DISPI_INDEX_VIDEO_MEMORY_64K) {

-        val = s->vram_size / (64 * 1024);

+        val = s->vbe_size / (64 * 1024);

     } else {

         val = 0;

     }

@@ -752,7 +752,7 @@ void vbe_ioport_write_data(void *opaque, uint32_t addr, uint32_t val)

                     line_offset = w >> 1;

                 else

                     line_offset = w * ((s->vbe_regs[VBE_DISPI_INDEX_BPP] + 7) >> 3);

-                h = s->vram_size / line_offset;

+                h = s->vbe_size / line_offset;

                 /* XXX: support weird bochs semantics ? */

                 if (h < s->vbe_regs[VBE_DISPI_INDEX_YRES])

                     return;

@@ -2290,6 +2290,9 @@ void vga_common_init(VGACommonState *s)

         s->vram_size <<= 1;

     }

     s->vram_size_mb = s->vram_size >> 20;

+    if (!s->vbe_size) {

+        s->vbe_size = s->vram_size;

+    }

     s->is_vbe_vmstate = 1;

     memory_region_init_ram(&s->vram, "vga.vram", s->vram_size);

diff --git a/hw/display/vga_int.h b/hw/display/vga_int.h

index 66f9f3c..5a2f466 100644

--- a/hw/display/vga_int.h

+++ b/hw/display/vga_int.h

@@ -93,6 +93,7 @@ typedef struct VGACommonState {

     MemoryRegion vram_vbe;

     uint32_t vram_size;

     uint32_t vram_size_mb; /* property */

+    uint32_t vbe_size;

     uint32_t latch;

     MemoryRegion *chain4_alias;

     uint8_t sr_index;

-- 

1.7.1