From af89b472e5fb4743a41cd7304ac831e777eadaa4 Mon Sep 17 00:00:00 2001

From: Stefan Hajnoczi <stefanha@redhat.com>

Date: Tue, 7 Oct 2014 14:06:51 +0200

Subject: [PATCH 33/43] trace: add pid field to simpletrace record

Message-id: <1412690820-31016-3-git-send-email-stefanha@redhat.com>

Patchwork-id: 61607

O-Subject: [RHEL7.1 qemu-kvm PATCH 02/11] trace: add pid field to simpletrace record

Bugzilla: 1088112

RH-Acked-by: Laszlo Ersek <lersek@redhat.com>

RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>

RH-Acked-by: Paolo Bonzini <pbonzini@redhat.com>

It is useful to know the QEMU process ID when working with traces from

multiple VMs.  Although the trace filename may contain the pid, tools

that aggregate traces or even trace globally need somewhere to record

the pid.

There is a reserved field in the trace event header struct that we can

use.

It is not necessary to bump the simpletrace file format version number

because it has already been incremented for the QEMU 2.1 release cycle

in commit "trace: [simple] Bump up log version number".

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

(cherry picked from commit 26896cbf353e3017f76da8193074839b6e875250)

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>

Conflicts:

	trace/simple.c

Downstream still has a g_thread_init() call in trace/simple.c so there

is a context conflict.  Easy to resolve.

---

 trace/simple.c | 8 ++++++--

 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/trace/simple.c b/trace/simple.c

index 64e196a..479b7d2 100644

--- a/trace/simple.c

+++ b/trace/simple.c

@@ -64,6 +64,7 @@ uint8_t trace_buf[TRACE_BUF_LEN];

 static volatile gint trace_idx;

 static unsigned int writeout_idx;

 static volatile gint dropped_events;

+static uint32_t trace_pid;

 static FILE *trace_fp;

 static char *trace_file_name;

@@ -72,7 +73,7 @@ typedef struct {

     uint64_t event; /*   TraceEventID */

     uint64_t timestamp_ns;

     uint32_t length;   /*    in bytes */

-    uint32_t reserved; /*    unused */

+    uint32_t pid;

     uint64_t arguments[];

 } TraceRecord;

@@ -180,7 +181,7 @@ static gpointer writeout_thread(gpointer opaque)

             dropped.rec.event = DROPPED_EVENT_ID,

             dropped.rec.timestamp_ns = get_clock();

             dropped.rec.length = sizeof(TraceRecord) + sizeof(uint64_t),

-            dropped.rec.reserved = 0;

+            dropped.rec.pid = trace_pid;

             do {

                 dropped_count = g_atomic_int_get(&dropped_events);

             } while (!g_atomic_int_compare_and_exchange(&dropped_events,

@@ -239,6 +240,7 @@ int trace_record_start(TraceBufferRecord *rec, TraceEventID event, size_t datasi

     rec_off = write_to_buffer(rec_off, &event_u64, sizeof(event_u64));

     rec_off = write_to_buffer(rec_off, &timestamp_ns, sizeof(timestamp_ns));

     rec_off = write_to_buffer(rec_off, &rec_len, sizeof(rec_len));

+    rec_off = write_to_buffer(rec_off, &trace_pid, sizeof(trace_pid));

     rec->tbuf_idx = idx;

     rec->rec_off  = (idx + sizeof(TraceRecord)) % TRACE_BUF_LEN;

@@ -413,6 +415,8 @@ bool trace_backend_init(const char *events, const char *file)

 #endif

     }

+    trace_pid = getpid();

+

 #if !GLIB_CHECK_VERSION(2, 31, 0)

     trace_available_cond = g_cond_new();

     trace_empty_cond = g_cond_new();

-- 

1.8.3.1