|
 |
9ae3a8 |
From 2c90d2f3ad8d299df7df7c055c66fa6711397f4a Mon Sep 17 00:00:00 2001
|
|
|
9ae3a8 |
From: Xiao Wang <jasowang@redhat.com>
|
|
|
9ae3a8 |
Date: Mon, 30 Jul 2018 06:31:57 +0200
|
|
|
9ae3a8 |
Subject: [PATCH 8/8] slirp: correct size computation while concatenating mbuf
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
RH-Author: Xiao Wang <jasowang@redhat.com>
|
|
|
9ae3a8 |
Message-id: <1532932317-6100-3-git-send-email-jasowang@redhat.com>
|
|
|
9ae3a8 |
Patchwork-id: 81543
|
|
|
9ae3a8 |
O-Subject: [RHEL7.6/7.5.z qemu-kvm PATCH 2/2] slirp: correct size computation while concatenating mbuf
|
|
|
9ae3a8 |
Bugzilla: 1586253
|
|
|
9ae3a8 |
RH-Acked-by: wexu@redhat.com
|
|
|
9ae3a8 |
RH-Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Michael S. Tsirkin <mst@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
From: Prasad J Pandit <pjp@fedoraproject.org>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Upstream: 70f2e64e4dde slirp: Convert mbufs to use g_malloc() and g_free()
|
|
|
9ae3a8 |
Notes: Conflict since we lacks 70f2e64e4dde
|
|
|
9ae3a8 |
("slirp: Convert mbufs to use g_malloc() and g_free()")
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
While reassembling incoming fragmented datagrams, 'm_cat' routine
|
|
|
9ae3a8 |
extends the 'mbuf' buffer, if it has insufficient room. It computes
|
|
|
9ae3a8 |
a wrong buffer size, which leads to overwriting adjacent heap buffer
|
|
|
9ae3a8 |
area. Correct this size computation in m_cat.
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Reported-by: ZDI Disclosures <zdi-disclosures@trendmicro.com>
|
|
|
9ae3a8 |
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
|
|
|
9ae3a8 |
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
|
|
|
9ae3a8 |
Signed-off-by: Jason Wang <jasowang@redhat.com>
|
|
|
9ae3a8 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
---
|
|
|
9ae3a8 |
slirp/mbuf.c | 11 +++++------
|
|
|
9ae3a8 |
slirp/mbuf.h | 8 +++-----
|
|
|
9ae3a8 |
2 files changed, 8 insertions(+), 11 deletions(-)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
diff --git a/slirp/mbuf.c b/slirp/mbuf.c
|
|
|
9ae3a8 |
index 5565fd1..ced2033 100644
|
|
|
9ae3a8 |
--- a/slirp/mbuf.c
|
|
|
9ae3a8 |
+++ b/slirp/mbuf.c
|
|
|
9ae3a8 |
@@ -139,7 +139,7 @@ m_cat(struct mbuf *m, struct mbuf *n)
|
|
|
9ae3a8 |
* If there's no room, realloc
|
|
|
9ae3a8 |
*/
|
|
|
9ae3a8 |
if (M_FREEROOM(m) < n->m_len)
|
|
|
9ae3a8 |
- m_inc(m,m->m_size+MINCSIZE);
|
|
|
9ae3a8 |
+ m_inc(m, m->m_len + n->m_len);
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
memcpy(m->m_data+m->m_len, n->m_data, n->m_len);
|
|
|
9ae3a8 |
m->m_len += n->m_len;
|
|
|
9ae3a8 |
@@ -148,7 +148,7 @@ m_cat(struct mbuf *m, struct mbuf *n)
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
-/* make m size bytes large */
|
|
|
9ae3a8 |
+/* make m 'size' bytes large from m_data */
|
|
|
9ae3a8 |
void
|
|
|
9ae3a8 |
m_inc(struct mbuf *m, int size)
|
|
|
9ae3a8 |
{
|
|
|
9ae3a8 |
@@ -159,12 +159,12 @@ m_inc(struct mbuf *m, int size)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
if (m->m_flags & M_EXT) {
|
|
|
9ae3a8 |
datasize = m->m_data - m->m_ext;
|
|
|
9ae3a8 |
- m->m_ext = (char *)realloc(m->m_ext,size);
|
|
|
9ae3a8 |
+ m->m_ext = (char *)realloc(m->m_ext, size + datasize);
|
|
|
9ae3a8 |
m->m_data = m->m_ext + datasize;
|
|
|
9ae3a8 |
} else {
|
|
|
9ae3a8 |
char *dat;
|
|
|
9ae3a8 |
datasize = m->m_data - m->m_dat;
|
|
|
9ae3a8 |
- dat = (char *)malloc(size);
|
|
|
9ae3a8 |
+ dat = (char *)malloc(size + datasize);
|
|
|
9ae3a8 |
memcpy(dat, m->m_dat, m->m_size);
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
m->m_ext = dat;
|
|
|
9ae3a8 |
@@ -172,8 +172,7 @@ m_inc(struct mbuf *m, int size)
|
|
|
9ae3a8 |
m->m_flags |= M_EXT;
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
- m->m_size = size;
|
|
|
9ae3a8 |
-
|
|
|
9ae3a8 |
+ m->m_size = size + datasize;
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
diff --git a/slirp/mbuf.h b/slirp/mbuf.h
|
|
|
9ae3a8 |
index b144f1c..32e5120 100644
|
|
|
9ae3a8 |
--- a/slirp/mbuf.h
|
|
|
9ae3a8 |
+++ b/slirp/mbuf.h
|
|
|
9ae3a8 |
@@ -33,8 +33,6 @@
|
|
|
9ae3a8 |
#ifndef _MBUF_H_
|
|
|
9ae3a8 |
#define _MBUF_H_
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
-#define MINCSIZE 4096 /* Amount to increase mbuf if too small */
|
|
|
9ae3a8 |
-
|
|
|
9ae3a8 |
/*
|
|
|
9ae3a8 |
* Macros for type conversion
|
|
|
9ae3a8 |
* mtod(m,t) - convert mbuf pointer to data pointer of correct type
|
|
|
9ae3a8 |
@@ -72,11 +70,11 @@ struct mbuf {
|
|
|
9ae3a8 |
struct mbuf *m_prevpkt; /* Flags aren't used in the output queue */
|
|
|
9ae3a8 |
int m_flags; /* Misc flags */
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
- int m_size; /* Size of data */
|
|
|
9ae3a8 |
+ int m_size; /* Size of mbuf, from m_dat or m_ext */
|
|
|
9ae3a8 |
struct socket *m_so;
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
- caddr_t m_data; /* Location of data */
|
|
|
9ae3a8 |
- int m_len; /* Amount of data in this mbuf */
|
|
|
9ae3a8 |
+ caddr_t m_data; /* Current location of data */
|
|
|
9ae3a8 |
+ int m_len; /* Amount of data in this mbuf, from m_data */
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Slirp *slirp;
|
|
|
9ae3a8 |
bool arp_requested;
|
|
|
9ae3a8 |
--
|
|
|
9ae3a8 |
1.8.3.1
|
|
|
9ae3a8 |
|